mbox series

[0/9] btrfs: some header cleanups and move things around

Message ID cover.1734368270.git.fdmanana@suse.com (mailing list archive)
Headers show
Series btrfs: some header cleanups and move things around | expand

Message

Filipe Manana Dec. 16, 2024, 5:17 p.m. UTC
From: Filipe Manana <fdmanana@suse.com>

Move some misplaced prototypes, macros and functions around and some
header cleanups. Trivial changes, details in the change logs.

Filipe Manana (9):
  btrfs: move abort_should_print_stack() to transaction.h
  btrfs: move csum related functions from ctree.c into fs.c
  btrfs: move the exclusive operation functions into fs.c
  btrfs: move btrfs_is_empty_uuid() from ioctl.c into fs.c
  btrfs: move the folio ordered helpers from ctree.h into fs.h
  btrfs: move BTRFS_BYTES_TO_BLKS() into fs.h
  btrfs: move btrfs_alloc_write_mask() into fs.h
  btrfs: move extent-tree function declarations out of ctree.h
  btrfs: remove pointless comment from ctree.h

 fs/btrfs/ctree.c            |  67 -----------------
 fs/btrfs/ctree.h            |  29 --------
 fs/btrfs/extent-tree.h      |   4 ++
 fs/btrfs/free-space-cache.c |   2 +-
 fs/btrfs/fs.c               | 139 ++++++++++++++++++++++++++++++++++++
 fs/btrfs/fs.h               |  24 +++++++
 fs/btrfs/ioctl.c            |  91 -----------------------
 fs/btrfs/ioctl.h            |   1 -
 fs/btrfs/transaction.h      |  18 ++++-
 fs/btrfs/volumes.c          |   2 +-
 10 files changed, 185 insertions(+), 192 deletions(-)

Comments

Qu Wenruo Dec. 17, 2024, 4:08 a.m. UTC | #1
在 2024/12/17 03:47, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Move some misplaced prototypes, macros and functions around and some
> header cleanups. Trivial changes, details in the change logs.

Except some minor comments on possible inline functions and a possible 
optimization using mem_is_zero(), all mentioned in the corresponding 
patches, the series looks good to me.

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> 
> Filipe Manana (9):
>    btrfs: move abort_should_print_stack() to transaction.h
>    btrfs: move csum related functions from ctree.c into fs.c
>    btrfs: move the exclusive operation functions into fs.c
>    btrfs: move btrfs_is_empty_uuid() from ioctl.c into fs.c
>    btrfs: move the folio ordered helpers from ctree.h into fs.h
>    btrfs: move BTRFS_BYTES_TO_BLKS() into fs.h
>    btrfs: move btrfs_alloc_write_mask() into fs.h
>    btrfs: move extent-tree function declarations out of ctree.h
>    btrfs: remove pointless comment from ctree.h
> 
>   fs/btrfs/ctree.c            |  67 -----------------
>   fs/btrfs/ctree.h            |  29 --------
>   fs/btrfs/extent-tree.h      |   4 ++
>   fs/btrfs/free-space-cache.c |   2 +-
>   fs/btrfs/fs.c               | 139 ++++++++++++++++++++++++++++++++++++
>   fs/btrfs/fs.h               |  24 +++++++
>   fs/btrfs/ioctl.c            |  91 -----------------------
>   fs/btrfs/ioctl.h            |   1 -
>   fs/btrfs/transaction.h      |  18 ++++-
>   fs/btrfs/volumes.c          |   2 +-
>   10 files changed, 185 insertions(+), 192 deletions(-)
>
Johannes Thumshirn Dec. 17, 2024, 11:57 a.m. UTC | #2
On 16.12.24 18:18, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> Move some misplaced prototypes, macros and functions around and some
> header cleanups. Trivial changes, details in the change logs.
> 
> Filipe Manana (9):
>    btrfs: move abort_should_print_stack() to transaction.h
>    btrfs: move csum related functions from ctree.c into fs.c
>    btrfs: move the exclusive operation functions into fs.c
>    btrfs: move btrfs_is_empty_uuid() from ioctl.c into fs.c
>    btrfs: move the folio ordered helpers from ctree.h into fs.h
>    btrfs: move BTRFS_BYTES_TO_BLKS() into fs.h
>    btrfs: move btrfs_alloc_write_mask() into fs.h
>    btrfs: move extent-tree function declarations out of ctree.h
>    btrfs: remove pointless comment from ctree.h
> 
>   fs/btrfs/ctree.c            |  67 -----------------
>   fs/btrfs/ctree.h            |  29 --------
>   fs/btrfs/extent-tree.h      |   4 ++
>   fs/btrfs/free-space-cache.c |   2 +-
>   fs/btrfs/fs.c               | 139 ++++++++++++++++++++++++++++++++++++
>   fs/btrfs/fs.h               |  24 +++++++
>   fs/btrfs/ioctl.c            |  91 -----------------------
>   fs/btrfs/ioctl.h            |   1 -
>   fs/btrfs/transaction.h      |  18 ++++-
>   fs/btrfs/volumes.c          |   2 +-
>   10 files changed, 185 insertions(+), 192 deletions(-)
> 

For the series,
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>