TI Ethernet Driver TI_K3_AM65_CPSW_NUSS

Commit Message

Da Shi Cao Dec. 17, 2024, 1:40 p.m. UTC

The driver of TI K3 ethernet port depends on PAGE_POOL configuration option. There should be a select PAGE_POOL under it configuration.


Dashi Cao

Comments

Greg KH Dec. 17, 2024, 1:57 p.m. UTC | #1

On Tue, Dec 17, 2024 at 01:40:12PM +0000, Da Shi Cao wrote:
> The driver of TI K3 ethernet port depends on PAGE_POOL configuration option. There should be a select PAGE_POOL under it configuration.
> 
> --- a/drivers/net/ethernet/ti/Kconfig
> +++ b/drivers/net/ethernet/ti/Kconfig
> @@ -114,6 +114,7 @@ config TI_K3_AM65_CPSW_NUSS
>         select TI_DAVINCI_MDIO
>         select PHYLINK
>         select TI_K3_CPPI_DESC_POOL
> +       select PAGE_POOL
>         imply PHY_TI_GMII_SEL
>         depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS
>         help
> 
> Dashi Cao


Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch contains warnings and/or errors noticed by the
  scripts/checkpatch.pl tool.

- Your patch is malformed (tabs converted to spaces, linewrapped, etc.)
  and can not be applied.  Please read the file,
  Documentation/process/email-clients.rst in order to fix this.

- Your patch does not have a Signed-off-by: line.  Please read the
  kernel file, Documentation/process/submitting-patches.rst and resend
  it after adding that line.  Note, the line needs to be in the body of
  the email, before the patch, not at the bottom of the patch or in the
  email signature.

- You did not specify a description of why the patch is needed, or
  possibly, any description at all, in the email body.  Please read the
  section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what is needed in
  order to properly describe the change.

- You did not write a descriptive Subject: for the patch, allowing Greg,
  and everyone else, to know what this patch is all about.  Please read
  the section entitled "The canonical patch format" in the kernel file,
  Documentation/process/submitting-patches.rst for what a proper
  Subject: line should look like.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

Andrew Lunn Dec. 17, 2024, 3:35 p.m. UTC | #2

On Tue, Dec 17, 2024 at 01:40:12PM +0000, Da Shi Cao wrote:
> The driver of TI K3 ethernet port depends on PAGE_POOL configuration option. There should be a select PAGE_POOL under it configuration.

Please wrap the commit message to around 75 characters.

Please take a read of:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

You need a Fixes: tag, please use the correct networking tree, etc.

	Andrew

Patch

--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -114,6 +114,7 @@  config TI_K3_AM65_CPSW_NUSS
        select TI_DAVINCI_MDIO
        select PHYLINK
        select TI_K3_CPPI_DESC_POOL
+       select PAGE_POOL
        imply PHY_TI_GMII_SEL
        depends on TI_K3_AM65_CPTS || !TI_K3_AM65_CPTS
        help