| Message ID | 20241217-csi_dcmipp_mp25_enhancements-v1-2-2b432805d17d@foss.st.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: stm32: csi / dcmipp corrections | expand |
On Tue, Dec 17, 2024 at 06:39:19PM +0100, Alain Volmat wrote: > Clarify the description of the stm32 csi by mentioning CSI-2 and > D-PHY. > Remove the bus-type property from the example. Why? What's there to gain from the example being (seemingly?) less comprehensive? > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > --- > Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > index 33bedfe41924..e9fa3cfea5d2 100644 > --- a/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > @@ -7,8 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > title: STMicroelectronics STM32 CSI controller > > description: > - The STM32 CSI controller allows connecting a CSI based > - camera to the DCMIPP camera pipeline. > + The STM32 CSI controller, coupled with a D-PHY allows connecting a CSI-2 > + based camera to the DCMIPP camera pipeline. > > maintainers: > - Alain Volmat <alain.volmat@foss.st.com> > @@ -109,7 +109,6 @@ examples: > endpoint { > remote-endpoint = <&imx335_ep>; > data-lanes = <1 2>; > - bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>; > }; > }; > > > -- > 2.34.1 >
Hi Conor, On Tue, Dec 17, 2024 at 06:24:42PM +0000, Conor Dooley wrote: > On Tue, Dec 17, 2024 at 06:39:19PM +0100, Alain Volmat wrote: > > Clarify the description of the stm32 csi by mentioning CSI-2 and > > D-PHY. > > > Remove the bus-type property from the example. > > Why? What's there to gain from the example being (seemingly?) less > comprehensive? As the device has D-PHY, other options are excluded. I.e. that property is redundant for this device. > > > > > Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> > > --- > > Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > > index 33bedfe41924..e9fa3cfea5d2 100644 > > --- a/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > > +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml > > @@ -7,8 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# > > title: STMicroelectronics STM32 CSI controller > > > > description: > > - The STM32 CSI controller allows connecting a CSI based > > - camera to the DCMIPP camera pipeline. > > + The STM32 CSI controller, coupled with a D-PHY allows connecting a CSI-2 > > + based camera to the DCMIPP camera pipeline. > > > > maintainers: > > - Alain Volmat <alain.volmat@foss.st.com> > > @@ -109,7 +109,6 @@ examples: > > endpoint { > > remote-endpoint = <&imx335_ep>; > > data-lanes = <1 2>; > > - bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>; > > }; > > }; > > > >
On Tue, Dec 17, 2024 at 09:12:55PM +0000, Sakari Ailus wrote: > Hi Conor, > > On Tue, Dec 17, 2024 at 06:24:42PM +0000, Conor Dooley wrote: > > On Tue, Dec 17, 2024 at 06:39:19PM +0100, Alain Volmat wrote: > > > Clarify the description of the stm32 csi by mentioning CSI-2 and > > > D-PHY. > > > > > Remove the bus-type property from the example. > > > > Why? What's there to gain from the example being (seemingly?) less > > comprehensive? > > As the device has D-PHY, other options are excluded. I.e. that property is > redundant for this device. That should be mentioned in the commit message.
diff --git a/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml index 33bedfe41924..e9fa3cfea5d2 100644 --- a/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml +++ b/Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml @@ -7,8 +7,8 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# title: STMicroelectronics STM32 CSI controller description: - The STM32 CSI controller allows connecting a CSI based - camera to the DCMIPP camera pipeline. + The STM32 CSI controller, coupled with a D-PHY allows connecting a CSI-2 + based camera to the DCMIPP camera pipeline. maintainers: - Alain Volmat <alain.volmat@foss.st.com> @@ -109,7 +109,6 @@ examples: endpoint { remote-endpoint = <&imx335_ep>; data-lanes = <1 2>; - bus-type = <MEDIA_BUS_TYPE_CSI2_DPHY>; }; };
Clarify the description of the stm32 csi by mentioning CSI-2 and D-PHY. Remove the bus-type property from the example. Signed-off-by: Alain Volmat <alain.volmat@foss.st.com> --- Documentation/devicetree/bindings/media/st,stm32mp25-csi.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)