| Message ID | 20241217-rcar-v4h-vspx-v1-4-de04ea044ed4@ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | renesas: r8a779g0: Enable VSPX on R-Car V4H | expand |
Hi Jacopo, Thank you for the patch. On Tue, Dec 17, 2024 at 06:53:17PM +0100, Jacopo Mondi wrote: > Add device nodes for the VSPX instances on R-Car V4H (R8A779G0) SoC. > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi > index e49748563e2f5706ed982d6c9cc1df59f27bd0dc..bf4ec5fb7bbdba55e2994f332fcbd623839079c2 100644 > --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi > @@ -2211,6 +2211,28 @@ vspd1: vsp@fea28000 { > renesas,fcp = <&fcpvd1>; > }; > > + vspx0: vsp@fedd0000 { Please keep those sorted by unit address too. > + compatible = "renesas,vsp2"; > + reg = <0 0xfedd0000 0 0x8000>; > + interrupts = <GIC_SPI 556 IRQ_TYPE_LEVEL_HIGH>; The interrupts are listed as "negative level sensitive" in the documentation. Tomi encountered a similar situation with the V4M VSP, and setting the level to low in the DT didn't work. I assume this will be fine, but if you encounter interrupt issues, this is one possible area to investigate. Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > + clocks = <&cpg CPG_MOD 1028>; > + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; > + resets = <&cpg 1028>; > + > + renesas,fcp = <&fcpvx0>; > + }; > + > + vspx1: vsp@fedd8000 { > + compatible = "renesas,vsp2"; > + reg = <0 0xfedd8000 0 0x8000>; > + interrupts = <GIC_SPI 557 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 1029>; > + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; > + resets = <&cpg 1029>; > + > + renesas,fcp = <&fcpvx1>; > + }; > + > du: display@feb00000 { > compatible = "renesas,du-r8a779g0"; > reg = <0 0xfeb00000 0 0x40000>;
Hi Laurent On Wed, Dec 18, 2024 at 01:42:15AM +0200, Laurent Pinchart wrote: > Hi Jacopo, > > Thank you for the patch. > > On Tue, Dec 17, 2024 at 06:53:17PM +0100, Jacopo Mondi wrote: > > Add device nodes for the VSPX instances on R-Car V4H (R8A779G0) SoC. > > > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> > > --- > > arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 22 ++++++++++++++++++++++ > > 1 file changed, 22 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi > > index e49748563e2f5706ed982d6c9cc1df59f27bd0dc..bf4ec5fb7bbdba55e2994f332fcbd623839079c2 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi > > @@ -2211,6 +2211,28 @@ vspd1: vsp@fea28000 { > > renesas,fcp = <&fcpvd1>; > > }; > > > > + vspx0: vsp@fedd0000 { > > Please keep those sorted by unit address too. > > > + compatible = "renesas,vsp2"; > > + reg = <0 0xfedd0000 0 0x8000>; > > + interrupts = <GIC_SPI 556 IRQ_TYPE_LEVEL_HIGH>; > > The interrupts are listed as "negative level sensitive" in the > documentation. Tomi encountered a similar situation with the V4M VSP, > and setting the level to low in the DT didn't work. I assume this will > be fine, but if you encounter interrupt issues, this is one possible > area to investigate. Yes, I noticed that the documentation says "negative", but I've done the same here as it's done for the VSPD instances (which are equally documented as negative), assuming that path had been tested. > > Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Thanks j > > > + clocks = <&cpg CPG_MOD 1028>; > > + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; > > + resets = <&cpg 1028>; > > + > > + renesas,fcp = <&fcpvx0>; > > + }; > > + > > + vspx1: vsp@fedd8000 { > > + compatible = "renesas,vsp2"; > > + reg = <0 0xfedd8000 0 0x8000>; > > + interrupts = <GIC_SPI 557 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&cpg CPG_MOD 1029>; > > + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; > > + resets = <&cpg 1029>; > > + > > + renesas,fcp = <&fcpvx1>; > > + }; > > + > > du: display@feb00000 { > > compatible = "renesas,du-r8a779g0"; > > reg = <0 0xfeb00000 0 0x40000>; > > -- > Regards, > > Laurent Pinchart
diff --git a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi index e49748563e2f5706ed982d6c9cc1df59f27bd0dc..bf4ec5fb7bbdba55e2994f332fcbd623839079c2 100644 --- a/arch/arm64/boot/dts/renesas/r8a779g0.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779g0.dtsi @@ -2211,6 +2211,28 @@ vspd1: vsp@fea28000 { renesas,fcp = <&fcpvd1>; }; + vspx0: vsp@fedd0000 { + compatible = "renesas,vsp2"; + reg = <0 0xfedd0000 0 0x8000>; + interrupts = <GIC_SPI 556 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 1028>; + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; + resets = <&cpg 1028>; + + renesas,fcp = <&fcpvx0>; + }; + + vspx1: vsp@fedd8000 { + compatible = "renesas,vsp2"; + reg = <0 0xfedd8000 0 0x8000>; + interrupts = <GIC_SPI 557 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cpg CPG_MOD 1029>; + power-domains = <&sysc R8A779G0_PD_ALWAYS_ON>; + resets = <&cpg 1029>; + + renesas,fcp = <&fcpvx1>; + }; + du: display@feb00000 { compatible = "renesas,du-r8a779g0"; reg = <0 0xfeb00000 0 0x40000>;
Add device nodes for the VSPX instances on R-Car V4H (R8A779G0) SoC. Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a779g0.dtsi | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+)