mbox

[PULL,00/18] loongarch-to-apply queue

Message ID 20241216015607.1795880-1-maobibo@loongson.cn (mailing list archive)
State New
Headers show

Pull-request

https://gitlab.com/bibo-mao/qemu.git tags/pull-loongarch-20241216

Message

bibo mao Dec. 16, 2024, 1:55 a.m. UTC 
The following changes since commit ca80a5d026a280762e0772615f1988db542b3ade:

  Merge tag 'hw-misc-20241214' of https://github.com/philmd/qemu into staging (2024-12-14 08:42:53 -0500)

are available in the Git repository at:

  https://gitlab.com/bibo-mao/qemu.git tags/pull-loongarch-20241216

for you to fetch changes up to efada537c6c49e414ae87ce66803d6d8543ad140:

  hw/intc/loongarch_extioi: Code cleanup about loongarch_extioi (2024-12-16 09:05:14 +0800)

----------------------------------------------------------------
pull-loongarch-20241216
  v1 .. v2: Push patch again since forgot to push to upstream

----------------------------------------------------------------
Bibo Mao (18):
      include: Add loongarch_pic_common header file
      include: Move struct LoongArchPCHPIC to loongarch_pic_common header file
      hw/intc/loongarch_pch: Merge instance_init() into realize()
      hw/intc/loongarch_pch: Rename LoongArchPCHPIC with LoongArchPICCommonState
      hw/intc/loongarch_pch: Move some functions to file loongarch_pic_common
      hw/intc/loongarch_pch: Inherit from loongarch_pic_common
      hw/intc/loongarch_pch: Add pre_save and post_load interfaces
      hw/intc/loongarch_pch: Code cleanup about loongarch_pch_pic
      include: Add loongarch_extioi_common header file
      include: Move struct LoongArchExtIOI to header file loongarch_extioi_common
      include: Rename LoongArchExtIOI with LoongArchExtIOICommonState
      hw/intc/loongarch_extioi: Rename LoongArchExtIOI with LoongArchExtIOICommonState
      hw/intc/loongarch_extioi: Add common realize interface
      hw/intc/loongarch_extioi: Add unrealize interface
      hw/intc/loongarch_extioi: Add common file loongarch_extioi_common
      hw/intc/loongarch_extioi: Inherit from loongarch_extioi_common
      hw/intc/loongarch_extioi: Add pre_save interface
      hw/intc/loongarch_extioi: Code cleanup about loongarch_extioi

 hw/intc/loongarch_extioi.c                | 110 +++++++++--------------------
 hw/intc/loongarch_extioi_common.c         | 113 ++++++++++++++++++++++++++++++
 hw/intc/loongarch_pch_pic.c               | 106 +++++++++-------------------
 hw/intc/loongarch_pic_common.c            |  97 +++++++++++++++++++++++++
 hw/intc/meson.build                       |   4 +-
 hw/loongarch/virt.c                       |   2 +-
 include/hw/intc/loongarch_extioi.h        |  84 +++-------------------
 include/hw/intc/loongarch_extioi_common.h |  98 ++++++++++++++++++++++++++
 include/hw/intc/loongarch_pch_pic.h       |  70 ++++--------------
 include/hw/intc/loongarch_pic_common.h    |  82 ++++++++++++++++++++++
 10 files changed, 488 insertions(+), 278 deletions(-)
 create mode 100644 hw/intc/loongarch_extioi_common.c
 create mode 100644 hw/intc/loongarch_pic_common.c
 create mode 100644 include/hw/intc/loongarch_extioi_common.h
 create mode 100644 include/hw/intc/loongarch_pic_common.h

Comments

Stefan Hajnoczi Dec. 16, 2024, 7:19 p.m. UTC | #1 
On Sun, 15 Dec 2024 at 20:56, Bibo Mao <maobibo@loongson.cn> wrote:
>
> The following changes since commit ca80a5d026a280762e0772615f1988db542b3ade:
>
>   Merge tag 'hw-misc-20241214' of https://github.com/philmd/qemu into staging (2024-12-14 08:42:53 -0500)
>
> are available in the Git repository at:
>
>   https://gitlab.com/bibo-mao/qemu.git tags/pull-loongarch-20241216
>
> for you to fetch changes up to efada537c6c49e414ae87ce66803d6d8543ad140:
>
>   hw/intc/loongarch_extioi: Code cleanup about loongarch_extioi (2024-12-16 09:05:14 +0800)
>
> ----------------------------------------------------------------
> pull-loongarch-20241216
>   v1 .. v2: Push patch again since forgot to push to upstream

Please take a look at following qtest failure from the
x64-freebsd-14-build CI job:

8/730 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/qom-test ERROR
0.84s killed by signal 6 SIGABRT
――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
stderr:
Broken pipe
../tests/qtest/libqtest.c:205: kill_qemu() detected QEMU death from
signal 11 (Segmentation fault) (core dumped)
(test program exited with status code -6)
TAP parsing error: Too few tests run (expected 2, got 0)

https://gitlab.com/qemu-project/qemu/-/jobs/8656122662/viewer

You can reproduce the FreeBSD 14 environment using `make
vm-build-freebsd`. See `make vm-help` for more options.

Here is the merge tag where this happened. It probably also happens on
your pull request tag:
https://gitlab.com/qemu-project/qemu/-/commit/466535ecb37d28ef79aecc4550b7cd1160c6beac

If you find that there was an issue with the commits in your pull
request, please send a new pull request revision. If you find that the
issue was not caused by a commit in your pull request, please reply
here so we can discuss how to solve it.

Thanks,
Stefan

>
> ----------------------------------------------------------------
> Bibo Mao (18):
>       include: Add loongarch_pic_common header file
>       include: Move struct LoongArchPCHPIC to loongarch_pic_common header file
>       hw/intc/loongarch_pch: Merge instance_init() into realize()
>       hw/intc/loongarch_pch: Rename LoongArchPCHPIC with LoongArchPICCommonState
>       hw/intc/loongarch_pch: Move some functions to file loongarch_pic_common
>       hw/intc/loongarch_pch: Inherit from loongarch_pic_common
>       hw/intc/loongarch_pch: Add pre_save and post_load interfaces
>       hw/intc/loongarch_pch: Code cleanup about loongarch_pch_pic
>       include: Add loongarch_extioi_common header file
>       include: Move struct LoongArchExtIOI to header file loongarch_extioi_common
>       include: Rename LoongArchExtIOI with LoongArchExtIOICommonState
>       hw/intc/loongarch_extioi: Rename LoongArchExtIOI with LoongArchExtIOICommonState
>       hw/intc/loongarch_extioi: Add common realize interface
>       hw/intc/loongarch_extioi: Add unrealize interface
>       hw/intc/loongarch_extioi: Add common file loongarch_extioi_common
>       hw/intc/loongarch_extioi: Inherit from loongarch_extioi_common
>       hw/intc/loongarch_extioi: Add pre_save interface
>       hw/intc/loongarch_extioi: Code cleanup about loongarch_extioi
>
>  hw/intc/loongarch_extioi.c                | 110 +++++++++--------------------
>  hw/intc/loongarch_extioi_common.c         | 113 ++++++++++++++++++++++++++++++
>  hw/intc/loongarch_pch_pic.c               | 106 +++++++++-------------------
>  hw/intc/loongarch_pic_common.c            |  97 +++++++++++++++++++++++++
>  hw/intc/meson.build                       |   4 +-
>  hw/loongarch/virt.c                       |   2 +-
>  include/hw/intc/loongarch_extioi.h        |  84 +++-------------------
>  include/hw/intc/loongarch_extioi_common.h |  98 ++++++++++++++++++++++++++
>  include/hw/intc/loongarch_pch_pic.h       |  70 ++++--------------
>  include/hw/intc/loongarch_pic_common.h    |  82 ++++++++++++++++++++++
>  10 files changed, 488 insertions(+), 278 deletions(-)
>  create mode 100644 hw/intc/loongarch_extioi_common.c
>  create mode 100644 hw/intc/loongarch_pic_common.c
>  create mode 100644 include/hw/intc/loongarch_extioi_common.h
>  create mode 100644 include/hw/intc/loongarch_pic_common.h
>
bibo mao Dec. 18, 2024, 8:55 a.m. UTC | #2 
On 2024/12/17 上午3:19, Stefan Hajnoczi wrote:
> On Sun, 15 Dec 2024 at 20:56, Bibo Mao <maobibo@loongson.cn> wrote:
>>
>> The following changes since commit ca80a5d026a280762e0772615f1988db542b3ade:
>>
>>    Merge tag 'hw-misc-20241214' of https://github.com/philmd/qemu into staging (2024-12-14 08:42:53 -0500)
>>
>> are available in the Git repository at:
>>
>>    https://gitlab.com/bibo-mao/qemu.git tags/pull-loongarch-20241216
>>
>> for you to fetch changes up to efada537c6c49e414ae87ce66803d6d8543ad140:
>>
>>    hw/intc/loongarch_extioi: Code cleanup about loongarch_extioi (2024-12-16 09:05:14 +0800)
>>
>> ----------------------------------------------------------------
>> pull-loongarch-20241216
>>    v1 .. v2: Push patch again since forgot to push to upstream
> 
> Please take a look at following qtest failure from the
> x64-freebsd-14-build CI job:
> 
> 8/730 qemu:qtest+qtest-loongarch64 / qtest-loongarch64/qom-test ERROR
> 0.84s killed by signal 6 SIGABRT
> ――――――――――――――――――――――――――――――――――――― ✀ ―――――――――――――――――――――――――――――――――――――
> stderr:
> Broken pipe
> ../tests/qtest/libqtest.c:205: kill_qemu() detected QEMU death from
> signal 11 (Segmentation fault) (core dumped)
> (test program exited with status code -6)
> TAP parsing error: Too few tests run (expected 2, got 0)
> 
> https://gitlab.com/qemu-project/qemu/-/jobs/8656122662/viewer
> 
> You can reproduce the FreeBSD 14 environment using `make
> vm-build-freebsd`. See `make vm-help` for more options.
> 
> Here is the merge tag where this happened. It probably also happens on
> your pull request tag:
> https://gitlab.com/qemu-project/qemu/-/commit/466535ecb37d28ef79aecc4550b7cd1160c6beac
> 
> If you find that there was an issue with the commits in your pull
> request, please send a new pull request revision. If you find that the
> issue was not caused by a commit in your pull request, please reply
> here so we can discuss how to solve it.
Sorry, there is problem on FreeBSD and it can be reproduced on my 
FreeBSD VM. Will fresh the patch.

Regards
Bibo Mao
> 
> Thanks,
> Stefan
> 
>>
>> ----------------------------------------------------------------
>> Bibo Mao (18):
>>        include: Add loongarch_pic_common header file
>>        include: Move struct LoongArchPCHPIC to loongarch_pic_common header file
>>        hw/intc/loongarch_pch: Merge instance_init() into realize()
>>        hw/intc/loongarch_pch: Rename LoongArchPCHPIC with LoongArchPICCommonState
>>        hw/intc/loongarch_pch: Move some functions to file loongarch_pic_common
>>        hw/intc/loongarch_pch: Inherit from loongarch_pic_common
>>        hw/intc/loongarch_pch: Add pre_save and post_load interfaces
>>        hw/intc/loongarch_pch: Code cleanup about loongarch_pch_pic
>>        include: Add loongarch_extioi_common header file
>>        include: Move struct LoongArchExtIOI to header file loongarch_extioi_common
>>        include: Rename LoongArchExtIOI with LoongArchExtIOICommonState
>>        hw/intc/loongarch_extioi: Rename LoongArchExtIOI with LoongArchExtIOICommonState
>>        hw/intc/loongarch_extioi: Add common realize interface
>>        hw/intc/loongarch_extioi: Add unrealize interface
>>        hw/intc/loongarch_extioi: Add common file loongarch_extioi_common
>>        hw/intc/loongarch_extioi: Inherit from loongarch_extioi_common
>>        hw/intc/loongarch_extioi: Add pre_save interface
>>        hw/intc/loongarch_extioi: Code cleanup about loongarch_extioi
>>
>>   hw/intc/loongarch_extioi.c                | 110 +++++++++--------------------
>>   hw/intc/loongarch_extioi_common.c         | 113 ++++++++++++++++++++++++++++++
>>   hw/intc/loongarch_pch_pic.c               | 106 +++++++++-------------------
>>   hw/intc/loongarch_pic_common.c            |  97 +++++++++++++++++++++++++
>>   hw/intc/meson.build                       |   4 +-
>>   hw/loongarch/virt.c                       |   2 +-
>>   include/hw/intc/loongarch_extioi.h        |  84 +++-------------------
>>   include/hw/intc/loongarch_extioi_common.h |  98 ++++++++++++++++++++++++++
>>   include/hw/intc/loongarch_pch_pic.h       |  70 ++++--------------
>>   include/hw/intc/loongarch_pic_common.h    |  82 ++++++++++++++++++++++
>>   10 files changed, 488 insertions(+), 278 deletions(-)
>>   create mode 100644 hw/intc/loongarch_extioi_common.c
>>   create mode 100644 hw/intc/loongarch_pic_common.c
>>   create mode 100644 include/hw/intc/loongarch_extioi_common.h
>>   create mode 100644 include/hw/intc/loongarch_pic_common.h
>>