| Message ID | 20241213064035.1427811-2-thippeswamy.havalige@amd.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Krzysztof Wilczyński |
| Headers | show |
| Series | Add support for AMD MDB IP as Root Port | expand |
On Fri, Dec 13, 2024 at 12:10:33PM +0530, Thippeswamy Havalige wrote: > Add support for mdb slcr aperture that is only supported for AMD Versal2 > devices. > > Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com> > --- > Changes in v3: > ------------- > - Introduced below changes in dwc yaml schema. > Changes in v5: > ------------- > - Modify mdb_pcie_slcr as constant. > --- > Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > index 548f59d76ef2..696568e81cfc 100644 > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > @@ -113,6 +113,8 @@ properties: > enum: [ smu, mpu ] > - description: Tegra234 aperture > enum: [ ecam ] > + - description: AMD MDB PCIe slcr region > + const: mdb_pcie_slcr Including the block name is redundant. Just 'slcr' is sufficient. > allOf: > - contains: > const: dbi > -- > 2.34.1 >
Hi Rob, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: Tuesday, December 17, 2024 8:31 PM > To: Havalige, Thippeswamy <thippeswamy.havalige@amd.com> > Cc: bhelgaas@google.com; lpieralisi@kernel.org; kw@linux.com; > manivannan.sadhasivam@linaro.org; krzk+dt@kernel.org; conor+dt@kernel.org; > linux-pci@vger.kernel.org; devicetree@vger.kernel.org; linux- > kernel@vger.kernel.org; jingoohan1@gmail.com; Simek, Michal > <michal.simek@amd.com>; Gogada, Bharat Kumar > <bharat.kumar.gogada@amd.com> > Subject: Re: [RESEND PATCH v5 1/3] dt-bindings: PCI: dwc: Add AMD Versal2 mdb > slcr support > > On Fri, Dec 13, 2024 at 12:10:33PM +0530, Thippeswamy Havalige wrote: > > Add support for mdb slcr aperture that is only supported for AMD > > Versal2 devices. > > > > Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com> > > --- > > Changes in v3: > > ------------- > > - Introduced below changes in dwc yaml schema. > > Changes in v5: > > ------------- > > - Modify mdb_pcie_slcr as constant. > > --- > > Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > > b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > > index 548f59d76ef2..696568e81cfc 100644 > > --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > > +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml > > @@ -113,6 +113,8 @@ properties: > > enum: [ smu, mpu ] > > - description: Tegra234 aperture > > enum: [ ecam ] > > + - description: AMD MDB PCIe slcr region > > + const: mdb_pcie_slcr > > Including the block name is redundant. Just 'slcr' is sufficient. Thank you for your comments, I'll update this in next patch. > > > allOf: > > - contains: > > const: dbi > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml index 548f59d76ef2..696568e81cfc 100644 --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml @@ -113,6 +113,8 @@ properties: enum: [ smu, mpu ] - description: Tegra234 aperture enum: [ ecam ] + - description: AMD MDB PCIe slcr region + const: mdb_pcie_slcr allOf: - contains: const: dbi
Add support for mdb slcr aperture that is only supported for AMD Versal2 devices. Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com> --- Changes in v3: ------------- - Introduced below changes in dwc yaml schema. Changes in v5: ------------- - Modify mdb_pcie_slcr as constant. --- Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 2 ++ 1 file changed, 2 insertions(+)