| Message ID | 20241218004058.GA24802@pendragon.ideasonboard.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [GIT,PULL,FOR,v6.14] imx8-isi fixes and improvements | expand |
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/project/linux-media/patch/20241218004058.GA24802@pendragon.ideasonboard.com/
Build log: https://builder.linuxtv.org/job/patchwork/408806/
Build time: 00:14:03
Link: https://lore.kernel.org/linux-media/20241218004058.GA24802@pendragon.ideasonboard.com
gpg: Signature made Wed 18 Dec 2024 12:29:26 AM UTC
gpg: using EDDSA key 7804022A38B7D13F41738C3685F1965061424BE1
gpg: issuer "laurent.pinchart@ideasonboard.com"
gpg: Good signature from "Laurent Pinchart <laurent.pinchart@ideasonboard.com>" [full]
gpg: laurent.pinchart@ideasonboard.com: Verified 6 signatures in the past
5 months. Encrypted 0 messages.
Summary: no issues. All 3 looked fine.
On Tue, Dec 17, 2024 at 05:54:08PM -0800, Patchwork Integration wrote: > Dear Laurent Pinchart: > > Thanks for your patches! Unfortunately media-ci detected some issues: > > # Test media-patchstyle:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch media style > WARNING: Commit cf21f328fcafacf4f96e7a30ef9dceede1076378 found in the stable tree, but stable@vger.kernel.org not in Cc: > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' > #16: > Fixes: cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver") I don't think Cc: stable makes sense for this particular commit. > total: 0 errors, 1 warnings, 15 lines checked > WARNING: ./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch: Fails some mandatory checkpatch tests > > # Test checkpatch:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch checkpatch > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' > #16: > Fixes: cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver") > > total: 0 errors, 1 warnings, 0 checks, 15 lines checked This I can fix. I'll wait for replies to the above though. > Please fix your series, and upload a new version. If you have a patchwork > account, do not forget to mark the current series as Superseded. > > For more details, check the full report at: > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/68354451/artifacts/report.htm . > > > > Best regards, and Happy Hacking! > Media CI robot on behalf of the linux-media community. > > --- > Check the latest rules for contributing your patches at: > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html > > If you believe that the CI is wrong, kindly open an issue at > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all > to this message.
Em Wed, 18 Dec 2024 04:18:47 +0200 Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu: > On Tue, Dec 17, 2024 at 05:54:08PM -0800, Patchwork Integration wrote: > > Dear Laurent Pinchart: > > > > Thanks for your patches! Unfortunately media-ci detected some issues: > > > > # Test media-patchstyle:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch media style > > WARNING: Commit cf21f328fcafacf4f96e7a30ef9dceede1076378 found in the stable tree, but stable@vger.kernel.org not in Cc: > > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' > > #16: > > Fixes: cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver") > > I don't think Cc: stable makes sense for this particular commit. Sure, not all commits are actually fixing things, but, in this particular case, it sounds that it contains a real problem: Running the v4l2-compliance (1.27.0-5208, SHA: af114250d48d) on the m2m device fails on the MMAP streaming tests, with the following messages: fail: v4l2-test-buffers.cpp(240): g_field() == V4L2_FIELD_ANY fail: v4l2-test-buffers.cpp(1508): buf.qbuf(node) causing userspace to fail. For me, it seems that such patch needs to be backported. In doubt, please add c/c stable when fixes is used. If there are good reasons why not doing it, please place the rationale at the patch. > > total: 0 errors, 1 warnings, 15 lines checked > > WARNING: ./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch: Fails some mandatory checkpatch tests > > > > # Test checkpatch:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch checkpatch > > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' > > #16: > > Fixes: cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver") > > > > total: 0 errors, 1 warnings, 0 checks, 15 lines checked > > This I can fix. I'll wait for replies to the above though. Please do it. The rest of the PR sounds OK on my eyes. Thanks, Mauro
Hi Mauro, On Wed, Dec 18, 2024 at 04:23:41PM +0100, Mauro Carvalho Chehab wrote: > Em Wed, 18 Dec 2024 04:18:47 +0200 Laurent Pinchart escreveu: > > On Tue, Dec 17, 2024 at 05:54:08PM -0800, Patchwork Integration wrote: > > > Dear Laurent Pinchart: > > > > > > Thanks for your patches! Unfortunately media-ci detected some issues: > > > > > > # Test media-patchstyle:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch media style > > > WARNING: Commit cf21f328fcafacf4f96e7a30ef9dceede1076378 found in the stable tree, but stable@vger.kernel.org not in Cc: > > > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' > > > #16: > > > Fixes: cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver") > > > > I don't think Cc: stable makes sense for this particular commit. > > Sure, not all commits are actually fixing things, but, in this > particular case, it sounds that it contains a real problem: > > Running the v4l2-compliance (1.27.0-5208, SHA: af114250d48d) on the m2m > device fails on the MMAP streaming tests, with the following messages: > > fail: v4l2-test-buffers.cpp(240): g_field() == V4L2_FIELD_ANY > fail: v4l2-test-buffers.cpp(1508): buf.qbuf(node) > > causing userspace to fail. For me, it seems that such patch needs to > be backported. If the fix wasn't fixing a problem, it wouldn't be a fix :-) The reason why I don't think this is worth a backport is that it only fixes an issue reported by v4l2-compliance, that hasn't to my knowledge affected anyone in other use cases. Given that the driver evolves, backporting this change blindly, testing compilation only but not runtime operation, has a higher risk of introducing failures in stable kernels than it has a chance to fix issues that affect people. > In doubt, please add c/c stable when fixes is used. If there are good > reasons why not doing it, please place the rationale at the patch. > > > > total: 0 errors, 1 warnings, 15 lines checked > > > WARNING: ./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch: Fails some mandatory checkpatch tests > > > > > > # Test checkpatch:./0001-media-nxp-imx8-isi-fix-v4l2-compliance-test-errors.patch checkpatch > > > WARNING: Please use correct Fixes: style 'Fixes: <12 chars of sha1> ("<title line>")' - ie: 'Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver")' > > > #16: > > > Fixes: cf21f328fcafac ("media: nxp: Add i.MX8 ISI driver") > > > > > > total: 0 errors, 1 warnings, 0 checks, 15 lines checked > > > > This I can fix. I'll wait for replies to the above though. > > Please do it. > > The rest of the PR sounds OK on my eyes.
Hi Mauro, Hans, The following changes since commit 40384c840ea1944d7c5a392e8975ed088ecf0b37: Linux 6.13-rc1 (2024-12-01 14:28:56 -0800) are available in the Git repository at: https://gitlab.freedesktop.org/linux-media/users/pinchartl.git tags/next-media-nxp-20241218 for you to fetch changes up to ee8b722db9a4d4b370ecf9a0b2a6ad39e254daee: media: nxp: imx8-isi: Add i.MX8ULP support (2024-12-04 18:50:05 +0200) ---------------------------------------------------------------- Miscellaneous imx8-isi fixes and improvements ---------------------------------------------------------------- Guoniu.zhou (2): dt-bindings: media: nxp,imx8-isi: Add i.MX8ULP ISI compatible string media: nxp: imx8-isi: Add i.MX8ULP support Laurentiu Palcu (1): media: nxp: imx8-isi: fix v4l2-compliance test errors Documentation/devicetree/bindings/media/nxp,imx8-isi.yaml | 2 ++ drivers/media/platform/nxp/imx8-isi/imx8-isi-core.c | 14 ++++++++++++++ drivers/media/platform/nxp/imx8-isi/imx8-isi-core.h | 1 + drivers/media/platform/nxp/imx8-isi/imx8-isi-video.c | 3 +++ 4 files changed, 20 insertions(+)