diff mbox series

[net-next] sfc: remove efx_writed_page_locked

Message ID 20241218135930.2350358-1-edward.cree@amd.com (mailing list archive)
State New
Delegated to: Netdev Maintainers
Headers show
Series [net-next] sfc: remove efx_writed_page_locked | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1 this patch: 1
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 1 maintainers not CCed: andrew+netdev@lunn.ch
netdev/build_clang success Errors and warnings before: 13 this patch: 13
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 2 this patch: 2
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 28 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest fail net-next-2024-12-18--18-00 (tests: 880)

Commit Message

edward.cree@amd.com Dec. 18, 2024, 1:59 p.m. UTC 
From: Andy Moreton <andy.moreton@amd.com>

From: Andy Moreton <andy.moreton@amd.com>

efx_writed_page_locked is a workaround for Siena hardware that is not
needed on later adapters, and has no callers. Remove it.

Signed-off-by: Andy Moreton <andy.moreton@amd.com>
Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
---
 drivers/net/ethernet/sfc/io.h | 24 ------------------------
 1 file changed, 24 deletions(-)

Comments

Alexander Lobakin Dec. 18, 2024, 3:42 p.m. UTC | #1 
From: Edward.cree <edward.cree@amd.com>
Date: Wed, 18 Dec 2024 13:59:30 +0000

> From: Andy Moreton <andy.moreton@amd.com>
> 
> From: Andy Moreton <andy.moreton@amd.com>

The patch is fine, but here clearly should be only one "From:" line.

> 
> efx_writed_page_locked is a workaround for Siena hardware that is not
> needed on later adapters, and has no callers. Remove it.
> 
> Signed-off-by: Andy Moreton <andy.moreton@amd.com>
> Signed-off-by: Edward Cree <ecree.xilinx@gmail.com>
> ---
>  drivers/net/ethernet/sfc/io.h | 24 ------------------------
>  1 file changed, 24 deletions(-)
> 
> diff --git a/drivers/net/ethernet/sfc/io.h b/drivers/net/ethernet/sfc/io.h
> index 4cc7b501135f..ef374a8e05c3 100644
> --- a/drivers/net/ethernet/sfc/io.h
> +++ b/drivers/net/ethernet/sfc/io.h
> @@ -217,28 +217,4 @@ _efx_writed_page(struct efx_nic *efx, const efx_dword_t *value,
>  					   (reg) != 0xa1c),		\
>  			 page)
>  
> -/* Write TIMER_COMMAND.  This is a page-mapped 32-bit CSR, but a bug
> - * in the BIU means that writes to TIMER_COMMAND[0] invalidate the
> - * collector register.
> - */
> -static inline void _efx_writed_page_locked(struct efx_nic *efx,
> -					   const efx_dword_t *value,
> -					   unsigned int reg,
> -					   unsigned int page)
> -{
> -	unsigned long flags __attribute__ ((unused));
> -
> -	if (page == 0) {
> -		spin_lock_irqsave(&efx->biu_lock, flags);
> -		efx_writed(efx, value, efx_paged_reg(efx, page, reg));
> -		spin_unlock_irqrestore(&efx->biu_lock, flags);
> -	} else {
> -		efx_writed(efx, value, efx_paged_reg(efx, page, reg));
> -	}
> -}
> -#define efx_writed_page_locked(efx, value, reg, page)			\
> -	_efx_writed_page_locked(efx, value,				\
> -				reg + BUILD_BUG_ON_ZERO((reg) != 0x420), \
> -				page)
> -
>  #endif /* EFX_IO_H */

Thanks,
Olek
diff mbox series

Patch

diff --git a/drivers/net/ethernet/sfc/io.h b/drivers/net/ethernet/sfc/io.h
index 4cc7b501135f..ef374a8e05c3 100644
--- a/drivers/net/ethernet/sfc/io.h
+++ b/drivers/net/ethernet/sfc/io.h
@@ -217,28 +217,4 @@  _efx_writed_page(struct efx_nic *efx, const efx_dword_t *value,
 					   (reg) != 0xa1c),		\
 			 page)
 
-/* Write TIMER_COMMAND.  This is a page-mapped 32-bit CSR, but a bug
- * in the BIU means that writes to TIMER_COMMAND[0] invalidate the
- * collector register.
- */
-static inline void _efx_writed_page_locked(struct efx_nic *efx,
-					   const efx_dword_t *value,
-					   unsigned int reg,
-					   unsigned int page)
-{
-	unsigned long flags __attribute__ ((unused));
-
-	if (page == 0) {
-		spin_lock_irqsave(&efx->biu_lock, flags);
-		efx_writed(efx, value, efx_paged_reg(efx, page, reg));
-		spin_unlock_irqrestore(&efx->biu_lock, flags);
-	} else {
-		efx_writed(efx, value, efx_paged_reg(efx, page, reg));
-	}
-}
-#define efx_writed_page_locked(efx, value, reg, page)			\
-	_efx_writed_page_locked(efx, value,				\
-				reg + BUILD_BUG_ON_ZERO((reg) != 0x420), \
-				page)
-
 #endif /* EFX_IO_H */