[net-next,0/3] net: add and use phy_disable_eee

Message

Heiner Kallweit Dec. 16, 2024, 9:29 p.m. UTC

If a MAC driver doesn't support EEE, then the PHY shouldn't advertise it.
Add phy_disable_eee() for this purpose, and use it in cpsw driver.

Heiner Kallweit (3):
  net: phy: add phy_disable_eee
  net: ethernet: ti: cpsw: disable PHY EEE advertisement
  ARM: dts: ti/omap: remove eee-broken properties

 arch/arm/boot/dts/ti/omap/am335x-baltos.dtsi     |  2 --
 .../arm/boot/dts/ti/omap/am335x-myirtech-myd.dts |  1 -
 .../arm/boot/dts/ti/omap/am5729-beagleboneai.dts |  2 --
 drivers/net/ethernet/ti/cpsw.c                   |  3 ++-
 drivers/net/ethernet/ti/cpsw_ethtool.c           | 12 ------------
 drivers/net/ethernet/ti/cpsw_new.c               |  3 ++-
 drivers/net/ethernet/ti/cpsw_priv.h              |  1 -
 drivers/net/phy/phy_device.c                     | 16 ++++++++++++++++
 include/linux/phy.h                              |  1 +
 9 files changed, 21 insertions(+), 20 deletions(-)

Comments

[e-mail] Dec. 20, 2024, 3:30 a.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Mon, 16 Dec 2024 22:29:58 +0100 you wrote:
> If a MAC driver doesn't support EEE, then the PHY shouldn't advertise it.
> Add phy_disable_eee() for this purpose, and use it in cpsw driver.
> 
> Heiner Kallweit (3):
>   net: phy: add phy_disable_eee
>   net: ethernet: ti: cpsw: disable PHY EEE advertisement
>   ARM: dts: ti/omap: remove eee-broken properties
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] net: phy: add phy_disable_eee
    https://git.kernel.org/netdev/net-next/c/b55498ff14bd
  - [net-next,2/3] net: ethernet: ti: cpsw: disable PHY EEE advertisement
    https://git.kernel.org/netdev/net-next/c/c9f5a5dabbf5
  - [net-next,3/3] ARM: dts: ti/omap: remove eee-broken properties
    (no matching commit)

You are awesome, thank you!

Heiner Kallweit Dec. 20, 2024, 8:26 a.m. UTC | #2

On 20.12.2024 04:30, [e-mail] wrote:
> Hello:
> 
> This series was applied to netdev/net-next.git (main)
> by Jakub Kicinski <[e-mail]>:
> 
> On Mon, 16 Dec 2024 22:29:58 +0100 you wrote:
>> If a MAC driver doesn't support EEE, then the PHY shouldn't advertise it.
>> Add phy_disable_eee() for this purpose, and use it in cpsw driver.
>>
>> Heiner Kallweit (3):
>>   net: phy: add phy_disable_eee
>>   net: ethernet: ti: cpsw: disable PHY EEE advertisement
>>   ARM: dts: ti/omap: remove eee-broken properties
>>
>> [...]
> 
> Here is the summary with links:
>   - [net-next,1/3] net: phy: add phy_disable_eee
>     https://git.kernel.org/netdev/net-next/c/b55498ff14bd
>   - [net-next,2/3] net: ethernet: ti: cpsw: disable PHY EEE advertisement
>     https://git.kernel.org/netdev/net-next/c/c9f5a5dabbf5
>   - [net-next,3/3] ARM: dts: ti/omap: remove eee-broken properties
>     (no matching commit)
> 
Patch 3 is marked "not applicable" in patchwork and didn't make it to net-next.
Any issue with this patch?

> You are awesome, thank you!

Andrew Lunn Dec. 20, 2024, 8:40 a.m. UTC | #3

On Fri, Dec 20, 2024 at 09:26:54AM +0100, Heiner Kallweit wrote:
> On 20.12.2024 04:30, [e-mail] wrote:
> > Hello:
> > 
> > This series was applied to netdev/net-next.git (main)
> > by Jakub Kicinski <[e-mail]>:
> > 
> > On Mon, 16 Dec 2024 22:29:58 +0100 you wrote:
> >> If a MAC driver doesn't support EEE, then the PHY shouldn't advertise it.
> >> Add phy_disable_eee() for this purpose, and use it in cpsw driver.
> >>
> >> Heiner Kallweit (3):
> >>   net: phy: add phy_disable_eee
> >>   net: ethernet: ti: cpsw: disable PHY EEE advertisement
> >>   ARM: dts: ti/omap: remove eee-broken properties
> >>
> >> [...]
> > 
> > Here is the summary with links:
> >   - [net-next,1/3] net: phy: add phy_disable_eee
> >     https://git.kernel.org/netdev/net-next/c/b55498ff14bd
> >   - [net-next,2/3] net: ethernet: ti: cpsw: disable PHY EEE advertisement
> >     https://git.kernel.org/netdev/net-next/c/c9f5a5dabbf5
> >   - [net-next,3/3] ARM: dts: ti/omap: remove eee-broken properties
> >     (no matching commit)
> > 
> Patch 3 is marked "not applicable" in patchwork and didn't make it to net-next.
> Any issue with this patch?

Maybe Jakub wants you to submit it to the TI DT Maintainer? Or get an
Acked-by: from said Maintainer.

	Andrew

Jakub Kicinski Dec. 20, 2024, 2:25 p.m. UTC | #4

On Fri, 20 Dec 2024 09:40:38 +0100 Andrew Lunn wrote:
> > Patch 3 is marked "not applicable" in patchwork and didn't make it to net-next.
> > Any issue with this patch?  
> 
> Maybe Jakub wants you to submit it to the TI DT Maintainer? Or get an
> Acked-by: from said Maintainer.

Indeed, we got screamed at once for applying dts changes.
I filter them out now 

Heiner Kallweit Dec. 20, 2024, 10:14 p.m. UTC | #5

On 20.12.2024 15:25, Jakub Kicinski wrote:
> On Fri, 20 Dec 2024 09:40:38 +0100 Andrew Lunn wrote:
>>> Patch 3 is marked "not applicable" in patchwork and didn't make it to net-next.
>>> Any issue with this patch?  
>>
>> Maybe Jakub wants you to submit it to the TI DT Maintainer? Or get an
>> Acked-by: from said Maintainer.
> 
> Indeed, we got screamed at once for applying dts changes.
> I filter them out now