diff mbox series

[v2,3/3] net/can/dev: Remove dead code

Message ID 20241221111454.1074285-4-ariel.otilibili-anieli@eurecom.fr (mailing list archive)
State New
Headers show
Series broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and dead code | expand

Commit Message

Ariel Otilibili-Anieli Dec. 21, 2024, 11:06 a.m. UTC
The default switch case ends with a return; meaning this return is never
reached.

Coverity-ID: 1497123
Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
---
 drivers/net/can/dev/dev.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Marc Kleine-Budde Dec. 22, 2024, 4:37 p.m. UTC | #1
On 21.12.2024 12:06:49, Ariel Otilibili wrote:
> The default switch case ends with a return; meaning this return is never
> reached.
> 
> Coverity-ID: 1497123
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>

Applied this patch only to linux-can-next/testing.

Thanks,
Marc
Ariel Otilibili-Anieli Dec. 22, 2024, 5:27 p.m. UTC | #2
On Sunday, December 22, 2024 17:37 CET, Marc Kleine-Budde <mkl@pengutronix.de> wrote:

> On 21.12.2024 12:06:49, Ariel Otilibili wrote:
> > The default switch case ends with a return; meaning this return is never
> > reached.
> > 
> > Coverity-ID: 1497123
> > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr>
> 
> Applied this patch only to linux-can-next/testing.

Great, Marc; thanks for the feedback.
> 
> Thanks,
> Marc
> 
> -- 
> Pengutronix e.K.                 | Marc Kleine-Budde          |
> Embedded Linux                   | https://www.pengutronix.de |
> Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
> Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |
diff mbox series

Patch

diff --git a/drivers/net/can/dev/dev.c b/drivers/net/can/dev/dev.c
index 681643ab3780..5ec3170b896a 100644
--- a/drivers/net/can/dev/dev.c
+++ b/drivers/net/can/dev/dev.c
@@ -85,8 +85,6 @@  const char *can_get_state_str(const enum can_state state)
 	default:
 		return "<unknown>";
 	}
-
-	return "<unknown>";
 }
 EXPORT_SYMBOL_GPL(can_get_state_str);