| Message ID | 20241225090113.17027-3-bo.kong@mediatek.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add AIE Driver | expand |
On Wed, 25 Dec 2024 17:00:21 +0800, bo.kong wrote: > From: Bo Kong <Bo.Kong@mediatek.com> > > Add YAML device tree bindings for MT8188 AIE. > > Signed-off-by: Bo Kong <Bo.Kong@mediatek.com> > --- > > Changes in v3: > none > > Changes in v2: > 1. Fix coding style > --- > .../bindings/media/mediatek,mt8188-aie.yaml | 97 +++++++++++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename $id: http://devicetree.org/schemas/media/mediatek-aie.yaml file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.example.dtb: aie@15310000: reg: [[0, 355532800], [0, 4096]] is too long from schema $id: http://devicetree.org/schemas/media/mediatek-aie.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.example.dtb: aie@15310000: '#address-cells', '#size-cells' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/media/mediatek-aie.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241225090113.17027-3-bo.kong@mediatek.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 25/12/2024 10:00, bo.kong wrote: > From: Bo Kong <Bo.Kong@mediatek.com> > > Add YAML device tree bindings for MT8188 AIE. > > Signed-off-by: Bo Kong <Bo.Kong@mediatek.com> > --- > > Changes in v3: > none > > Changes in v2: > 1. Fix coding style Coding style? So none of my specific comments were implemented? No improvements in compatibles, properties, all these things I pointed out? Please be more specific or just go back to previous email and implement all the comments. Best regards, Krzysztof
On Wed, 2024-12-25 at 17:00 +0800, bo.kong wrote: > From: Bo Kong <Bo.Kong@mediatek.com> > > Add YAML device tree bindings for MT8188 AIE. > > Signed-off-by: Bo Kong <Bo.Kong@mediatek.com> > --- > > Changes in v3: > none > > Changes in v2: > 1. Fix coding style > --- > .../bindings/media/mediatek,mt8188-aie.yaml | 97 +++++++++++++++++++ > 1 file changed, 97 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml > new file mode 100644 > index 000000000000..63dd720ef6ec > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/media/mediatek-aie.yaml*__;Iw!!CTRNKA9wMg0ARbw!mOYiAQ4L35rPpndZaS91tTcFgaV6wdNoQ9CsIK5IH6Hpjt5SjsdcXX4Z0--LVVUOz4WCe_eOfyRJmJH9$ > +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!mOYiAQ4L35rPpndZaS91tTcFgaV6wdNoQ9CsIK5IH6Hpjt5SjsdcXX4Z0--LVVUOz4WCe_eOf2v9y9FU$ > + > +title: The AI Engine Unit of MediaTek Camera System > + > +maintainers: > + - Bo Kong <bo.kong@mediatek.com> > + > +description: > + AIE(AI Engine) is one of the units in mt8188 ISP which > + provides hardware accelerated face detection function, > + it can detect different sizes of faces in a raw image. > + > +properties: > + compatible: > + items: > + - const: mediatek,mt8188-aie > + > + reg: > + maxItems: 1 > + description: Physical base address and length of the register space. > + > + interrupts: > + maxItems: 1 > + > + mediatek,larb: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Must contain the local arbiters in the current SoCs, see > + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml > + for details. > + > + iommus: > + maxItems: 4 > + description: > + Points to the respective IOMMU block with master port as argument, see > + Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details. > + Ports are according to the HW. > + > + power-domains: > + maxItems: 1 > + > + clocks: > + items: > + - description: clock for imgsys main ipe > + - description: clock for ipe fdvt > + - description: clock for ipe smi larb12 > + - description: clock for ipe top > + > + clock-names: > + items: > + - const: img_ipe > + - const: ipe_fdvt > + - const: ipe_smi_larb12 > + - const: ipe_top > + > +required: > + - compatible > + - reg > + - interrupts > + - iommus > + - power-domains > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/memory/mediatek,mt8188-memory-port.h> > + #include <dt-bindings/power/mediatek,mt8188-power.h> > + #include <dt-bindings/clock/mediatek,mt8188-clk.h> > + aie@15310000 { > + #address-cells = <2>; > + #size-cells = <2>; > + compatible = "mediatek,mt8188-aie"; > + reg = <0 0x15310000 0 0x1000>; > + interrupts = <GIC_SPI 787 IRQ_TYPE_LEVEL_HIGH 0>; > + mediatek,larb = <&larb12>; larb is processed by iommu device, so it's not necessary to point to larb device here. Regards, CK > + iommus = <&vpp_iommu M4U_PORT_L12_FDVT_RDA_0>, > + <&vpp_iommu M4U_PORT_L12_FDVT_RDB_0>, > + <&vpp_iommu M4U_PORT_L12_FDVT_WRA_0>, > + <&vpp_iommu M4U_PORT_L12_FDVT_WRB_0>; > + power-domains = <&spm MT8188_POWER_DOMAIN_IPE>; > + clocks = <&imgsys CLK_IMGSYS_MAIN_IPE>, > + <&ipesys CLK_IPE_FDVT>, > + <&ipesys CLK_IPE_SMI_LARB12>, > + <&ipesys CLK_IPESYS_TOP>; > + clock-names = "img_ipe", > + "ipe_fdvt", > + "ipe_smi_larb12", > + "ipe_top"; > + };
diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml b/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml new file mode 100644 index 000000000000..63dd720ef6ec --- /dev/null +++ b/Documentation/devicetree/bindings/media/mediatek,mt8188-aie.yaml @@ -0,0 +1,97 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/mediatek-aie.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: The AI Engine Unit of MediaTek Camera System + +maintainers: + - Bo Kong <bo.kong@mediatek.com> + +description: + AIE(AI Engine) is one of the units in mt8188 ISP which + provides hardware accelerated face detection function, + it can detect different sizes of faces in a raw image. + +properties: + compatible: + items: + - const: mediatek,mt8188-aie + + reg: + maxItems: 1 + description: Physical base address and length of the register space. + + interrupts: + maxItems: 1 + + mediatek,larb: + $ref: /schemas/types.yaml#/definitions/phandle + description: + Must contain the local arbiters in the current SoCs, see + Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.yaml + for details. + + iommus: + maxItems: 4 + description: + Points to the respective IOMMU block with master port as argument, see + Documentation/devicetree/bindings/iommu/mediatek,iommu.yaml for details. + Ports are according to the HW. + + power-domains: + maxItems: 1 + + clocks: + items: + - description: clock for imgsys main ipe + - description: clock for ipe fdvt + - description: clock for ipe smi larb12 + - description: clock for ipe top + + clock-names: + items: + - const: img_ipe + - const: ipe_fdvt + - const: ipe_smi_larb12 + - const: ipe_top + +required: + - compatible + - reg + - interrupts + - iommus + - power-domains + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/memory/mediatek,mt8188-memory-port.h> + #include <dt-bindings/power/mediatek,mt8188-power.h> + #include <dt-bindings/clock/mediatek,mt8188-clk.h> + aie@15310000 { + #address-cells = <2>; + #size-cells = <2>; + compatible = "mediatek,mt8188-aie"; + reg = <0 0x15310000 0 0x1000>; + interrupts = <GIC_SPI 787 IRQ_TYPE_LEVEL_HIGH 0>; + mediatek,larb = <&larb12>; + iommus = <&vpp_iommu M4U_PORT_L12_FDVT_RDA_0>, + <&vpp_iommu M4U_PORT_L12_FDVT_RDB_0>, + <&vpp_iommu M4U_PORT_L12_FDVT_WRA_0>, + <&vpp_iommu M4U_PORT_L12_FDVT_WRB_0>; + power-domains = <&spm MT8188_POWER_DOMAIN_IPE>; + clocks = <&imgsys CLK_IMGSYS_MAIN_IPE>, + <&ipesys CLK_IPE_FDVT>, + <&ipesys CLK_IPE_SMI_LARB12>, + <&ipesys CLK_IPESYS_TOP>; + clock-names = "img_ipe", + "ipe_fdvt", + "ipe_smi_larb12", + "ipe_top"; + };