| Message ID | 20241224091919.267698-1-andyshrk@163.com |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings: phy: add rk3576 hdptx phy | expand |
On Tue, Dec 24, 2024 at 05:19:13PM +0800, Andy Yan wrote: > From: Andy Yan <andy.yan@rock-chips.com> > > The HDPTX PHY on rk3576 is compatible with it on > rk3588. Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > > Add compatible for it. "Add compatible for the HDPTX PHY on rk3576, which is fully compatible with foo bar." One sentence. > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > --- > > .../devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml > index 84fe59dbcf48..364db2049ce2 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml > @@ -11,8 +11,11 @@ maintainers: > > properties: > compatible: > - enum: > - - rockchip,rk3588-hdptx-phy > + oneOf: > + - const: rockchip,rk3588-hdptx-phy > + - items: Why items? > + - enum: Why enum? > + - rockchip,rk3576-hdptx-phy So that's just enum with previous entry... but you said compatible, yet nothing is here. Test your patches - DTS will fail on this. Driver as well (assuming you expressed properly compatibility). Best regards, Krzysztof
On Tue, Dec 24, 2024 at 05:19:13PM +0800, Andy Yan wrote: > From: Andy Yan <andy.yan@rock-chips.com> > > The HDPTX PHY on rk3576 is compatible with it on > rk3588. > > Add compatible for it. > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > --- > > .../devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Also: where are any users of this binding? We don't take bindings without *UPSTREAM* users. Best regards, Krzysztof
Hi Krzysztof, At 2024-12-27 16:55:27, "Krzysztof Kozlowski" <krzk@kernel.org> wrote: >On Tue, Dec 24, 2024 at 05:19:13PM +0800, Andy Yan wrote: >> From: Andy Yan <andy.yan@rock-chips.com> >> >> The HDPTX PHY on rk3576 is compatible with it on >> rk3588. > >Please wrap commit message according to Linux coding style / submission >process (neither too early nor over the limit): >https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > >> >> Add compatible for it. > >"Add compatible for the HDPTX PHY on rk3576, which is fully compatible >with foo bar." > >One sentence. Will do in V2, thanks. > >> >> Signed-off-by: Andy Yan <andy.yan@rock-chips.com> >> --- >> >> .../devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml >> index 84fe59dbcf48..364db2049ce2 100644 >> --- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml >> +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml >> @@ -11,8 +11,11 @@ maintainers: >> >> properties: >> compatible: >> - enum: >> - - rockchip,rk3588-hdptx-phy >> + oneOf: >> + - const: rockchip,rk3588-hdptx-phy >> + - items: > >Why items? > >> + - enum: > >Why enum? > >> + - rockchip,rk3576-hdptx-phy > >So that's just enum with previous entry... but you said compatible, yet >nothing is here. Test your patches - DTS will fail on this. Driver as >well (assuming you expressed properly compatibility). Is this the right way to write it ？： properties: compatible: - enum: - - rockchip,rk3588-hdptx-phy + oneOf: + - enum: + - rockchip,rk3588-hdptx-phy + - items: + - enum: + - rockchip,rk3576-hdptx-phy + - const: rockchip,rk3588-hdptx-phy > >Best regards, >Krzysztof
Hi Krzysztof, Andy, Am Freitag, 27. Dezember 2024, 09:55:59 CET schrieb Krzysztof Kozlowski: > On Tue, Dec 24, 2024 at 05:19:13PM +0800, Andy Yan wrote: > > From: Andy Yan <andy.yan@rock-chips.com> > > > > The HDPTX PHY on rk3576 is compatible with it on > > rk3588. > > > > Add compatible for it. > > > > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> > > --- > > > > .../devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > Also: where are any users of this binding? > > We don't take bindings without *UPSTREAM* users. Andy, can you do a (separate) DTS series that binds all the display stuff together on one rk3576 board? (iommu, hdptxphy, vop, hdmi) Depending on how the driver sides go, this may be need to be revised at the end, but should hopefully satisfy that "show a user" thing. I guess Kever's EVB-series [0] might be a good base to build upon, with it being a Rockchip EVB? For people reading along, that whole display chain consists of: - iommu [1] - core display-controller additions for the rk3576 [2] - this hdptxphy binding - additions for the dw-hdmi-qp glue [3] Heiko [0] https://lore.kernel.org/lkml/20241220101551.3505917-1-kever.yang@rock-chips.com/ [1] https://lore.kernel.org/lkml/20240920094947.7566-1-andyshrk@163.com/ [2] https://lore.kernel.org/lkml/20241214081831.3330714-1-andyshrk@163.com/ [3} https://lore.kernel.org/lkml/20241225103741.364597-1-andyshrk@163.com/
Hi Heikio, Krzysztof, At 2024-12-28 04:08:41, "Heiko Stübner" <heiko@sntech.de> wrote: >Hi Krzysztof, Andy, > >Am Freitag, 27. Dezember 2024, 09:55:59 CET schrieb Krzysztof Kozlowski: >> On Tue, Dec 24, 2024 at 05:19:13PM +0800, Andy Yan wrote: >> > From: Andy Yan <andy.yan@rock-chips.com> >> > >> > The HDPTX PHY on rk3576 is compatible with it on >> > rk3588. >> > >> > Add compatible for it. >> > >> > Signed-off-by: Andy Yan <andy.yan@rock-chips.com> >> > --- >> > >> > .../devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml | 7 +++++-- >> > 1 file changed, 5 insertions(+), 2 deletions(-) >> >> Also: where are any users of this binding? >> >> We don't take bindings without *UPSTREAM* users. > >Andy, can you do a (separate) DTS series that binds all the display stuff >together on one rk3576 board? (iommu, hdptxphy, vop, hdmi) > >Depending on how the driver sides go, this may be need to be revised at >the end, but should hopefully satisfy that "show a user" thing. > >I guess Kever's EVB-series [0] might be a good base to build upon, with it >being a Rockchip EVB? As EVB patch series is still WIP, I will use rk3576-armsom-sige5.dts which is already in mainline as the base to collect all display related dts。 > > >For people reading along, that whole display chain consists of: >- iommu [1] >- core display-controller additions for the rk3576 [2] >- this hdptxphy binding >- additions for the dw-hdmi-qp glue [3] > >Heiko > > >[0] https://lore.kernel.org/lkml/20241220101551.3505917-1-kever.yang@rock-chips.com/ >[1] https://lore.kernel.org/lkml/20240920094947.7566-1-andyshrk@163.com/ >[2] https://lore.kernel.org/lkml/20241214081831.3330714-1-andyshrk@163.com/ >[3} https://lore.kernel.org/lkml/20241225103741.364597-1-andyshrk@163.com/ > > >
On 27/12/2024 11:46, Andy Yan wrote: >> >>> + - rockchip,rk3576-hdptx-phy >> >> So that's just enum with previous entry... but you said compatible, yet >> nothing is here. Test your patches - DTS will fail on this. Driver as >> well (assuming you expressed properly compatibility). > > Is this the right way to write it ？： > > properties: > compatible: > - enum: > - - rockchip,rk3588-hdptx-phy > + oneOf: > + - enum: > + - rockchip,rk3588-hdptx-phy > + - items: > + - enum: > + - rockchip,rk3576-hdptx-phy > + - const: rockchip,rk3588-hdptx-phy Yes, assuming they are compatible. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml index 84fe59dbcf48..364db2049ce2 100644 --- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-hdptx-phy.yaml @@ -11,8 +11,11 @@ maintainers: properties: compatible: - enum: - - rockchip,rk3588-hdptx-phy + oneOf: + - const: rockchip,rk3588-hdptx-phy + - items: + - enum: + - rockchip,rk3576-hdptx-phy reg: maxItems: 1