[0/2] test/qtest/migration: Use out-of-band execution for migrate-recover

Message

Juraj Marcin Jan. 7, 2025, 4:31 p.m. UTC

In real use cases, the migrate-recover command requires out-of-band
execution, because the main thread processing normal commands is blocked
by a page fault in the guest memory. Tests, however, do not reflect this
which might result in some bugs not being caught with tests.

The first patch in the series, adds a new qtest initialization function
which accepts capabilities the test wants to enable. This allows a test
to enable the oob capability.

The second patch then enables the oob capability in migration tests and
changes the execution of the migrate-recover command.

Juraj Marcin (2):
  tests/qtest: Introduce qtest_init_with_env_and_capabilities()
  tests/qtest/migration: Use out-of-band execution for migrate-recover

 tests/qtest/libqtest.c                | 18 ++++++++++++++++--
 tests/qtest/libqtest.h                | 17 +++++++++++++++++
 tests/qtest/migration/framework.c     | 23 +++++++++++++++++++++--
 tests/qtest/migration/framework.h     |  2 ++
 tests/qtest/migration/migration-qmp.c |  2 +-
 5 files changed, 57 insertions(+), 5 deletions(-)

Comments

Peter Xu Jan. 7, 2025, 9:12 p.m. UTC | #1

On Tue, Jan 07, 2025 at 05:31:52PM +0100, Juraj Marcin wrote:
> In real use cases, the migrate-recover command requires out-of-band
> execution, because the main thread processing normal commands is blocked
> by a page fault in the guest memory. Tests, however, do not reflect this
> which might result in some bugs not being caught with tests.
> 
> The first patch in the series, adds a new qtest initialization function
> which accepts capabilities the test wants to enable. This allows a test
> to enable the oob capability.
> 
> The second patch then enables the oob capability in migration tests and
> changes the execution of the migrate-recover command.
> 
> Juraj Marcin (2):
>   tests/qtest: Introduce qtest_init_with_env_and_capabilities()
>   tests/qtest/migration: Use out-of-band execution for migrate-recover
> 
>  tests/qtest/libqtest.c                | 18 ++++++++++++++++--
>  tests/qtest/libqtest.h                | 17 +++++++++++++++++
>  tests/qtest/migration/framework.c     | 23 +++++++++++++++++++++--
>  tests/qtest/migration/framework.h     |  2 ++
>  tests/qtest/migration/migration-qmp.c |  2 +-
>  5 files changed, 57 insertions(+), 5 deletions(-)

Looks all good, thanks!

Reviewed-by: Peter Xu <[e-mail]>