| Message ID | b67681db-76f2-46fa-9e87-48603b7ee081@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: realtek: add hwmon support | expand |
On Fri, Jan 10, 2025 at 12:47:39PM +0100, Heiner Kallweit wrote: > In preparation of adding a source file with hwmon support, rename > realtek.c to realtek_main.c. > > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/phy/Makefile | 1 + > drivers/net/phy/{realtek.c => realtek_main.c} | 0 > 2 files changed, 1 insertion(+) > rename drivers/net/phy/{realtek.c => realtek_main.c} (100%) Is it worth considering a vendor subdirectory when PHYs end up with multiple source files? We already have aquantia, mediatek, mscc, and qcom. Should we be considering it for this as well?
On 10.01.2025 13:40, Russell King (Oracle) wrote: > On Fri, Jan 10, 2025 at 12:47:39PM +0100, Heiner Kallweit wrote: >> In preparation of adding a source file with hwmon support, rename >> realtek.c to realtek_main.c. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> >> --- >> drivers/net/phy/Makefile | 1 + >> drivers/net/phy/{realtek.c => realtek_main.c} | 0 >> 2 files changed, 1 insertion(+) >> rename drivers/net/phy/{realtek.c => realtek_main.c} (100%) > > Is it worth considering a vendor subdirectory when PHYs end up with > multiple source files? > > We already have aquantia, mediatek, mscc, and qcom. Should we be > considering it for this as well? > Yes, I think this would make sense. I'll submit a v2.
diff --git a/drivers/net/phy/Makefile b/drivers/net/phy/Makefile index 39b72b464..ec480e733 100644 --- a/drivers/net/phy/Makefile +++ b/drivers/net/phy/Makefile @@ -95,6 +95,7 @@ obj-$(CONFIG_NXP_CBTX_PHY) += nxp-cbtx.o obj-$(CONFIG_NXP_TJA11XX_PHY) += nxp-tja11xx.o obj-y += qcom/ obj-$(CONFIG_QSEMI_PHY) += qsemi.o +realtek-y += realtek_main.o obj-$(CONFIG_REALTEK_PHY) += realtek.o obj-$(CONFIG_RENESAS_PHY) += uPD60620.o obj-$(CONFIG_ROCKCHIP_PHY) += rockchip.o diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek_main.c similarity index 100% rename from drivers/net/phy/realtek.c rename to drivers/net/phy/realtek_main.c
In preparation of adding a source file with hwmon support, rename realtek.c to realtek_main.c. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/Makefile | 1 + drivers/net/phy/{realtek.c => realtek_main.c} | 0 2 files changed, 1 insertion(+) rename drivers/net/phy/{realtek.c => realtek_main.c} (100%)