| Message ID | 20250113-sa8775p-iot-memory-map-v2-2-aa2bb544706e@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: sa8775p: Update memory map for derived IOT boards | expand |
On 13/01/2025 13:13, Pratyush Brahma wrote: > Update the iot specific memory map for qcs9100* boards. > > Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++ > arch/arm64/boot/dts/qcom/qcs9100-ride.dts | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts > index 759d1ec694b20e9cead674c1bd61c6a6627eeb27..06e57239bbe975b9c0b939d438095692243e39cf 100644 > --- a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts > +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts > @@ -5,6 +5,8 @@ > /dts-v1/; > > #include "sa8775p-ride-r3.dts" > +#include "sa8775p-iot.dtsi" No. Either this is car or iot. Cannot be both. In other threads I already complained you add some artificial split of DTS/DTSI and not describing the hardware. This is another example of that - you claim you have automotive board, which is derived from automotive board, but it is not automotive and instead it is iot. Decide about all this and come with DTS/DTSI structure reflecting actual hardware, not how you want to organize your device nodes. Best regards, Krzysztof
On 13/01/2025 13:13, Pratyush Brahma wrote: > Update the iot specific memory map for qcs9100* boards. Why? Every single time. Don't say what, we see it easily. Say why. > > Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++ > arch/arm64/boot/dts/qcom/qcs9100-ride.dts | 2 ++ > 2 files changed, 4 insertions(+) > Best regards, Krzysztof
On 1/13/2025 5:50 PM, Krzysztof Kozlowski wrote: > On 13/01/2025 13:13, Pratyush Brahma wrote: >> Update the iot specific memory map for qcs9100* boards. > Why? > > Every single time. Don't say what, we see it easily. Say why. I assumed incorrectly it would be perhaps enough to have mentioned this in patch 1 of this series and the cover letter, so didn't mention here. Can you please review the memory map changes in patch 1 as well? Once the strategy for the dts changes are baked in internally with the current reviews, I will send out another series incorporating the comments with the memory map changes. >> Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++ >> arch/arm64/boot/dts/qcom/qcs9100-ride.dts | 2 ++ >> 2 files changed, 4 insertions(+) >> > Best regards, > Krzysztof
On Mon, Jan 13, 2025 at 06:08:26PM +0530, Pratyush Brahma wrote: > > On 1/13/2025 5:50 PM, Krzysztof Kozlowski wrote: > > On 13/01/2025 13:13, Pratyush Brahma wrote: > > > Update the iot specific memory map for qcs9100* boards. > > Why? > > > > Every single time. Don't say what, we see it easily. Say why. > I assumed incorrectly it would be perhaps enough to have mentioned > this in patch 1 of this series and the cover letter, so didn't mention here. You wrote it in the patch 1, so it covered SA8775P-Ride boards. This patch concerns QCS9100 boards. So it is a completely separate topic. > Can you please review the memory map changes in patch 1 as well? > Once the strategy for the dts changes are baked in internally with the Please. Please. s/internally/externally/. Start discussing things on the MLs rather than baking the solution internally and then being surprised when the bakery isn't being accepted by the community. > current reviews, I will send out another series incorporating the comments > with the memory map changes. > > > Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com> > > > --- > > > arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++ > > > arch/arm64/boot/dts/qcom/qcs9100-ride.dts | 2 ++ > > > 2 files changed, 4 insertions(+) > > > > > Best regards, > > Krzysztof > > -- > Thanks and Regards > Pratyush Brahma >
diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts index 759d1ec694b20e9cead674c1bd61c6a6627eeb27..06e57239bbe975b9c0b939d438095692243e39cf 100644 --- a/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts @@ -5,6 +5,8 @@ /dts-v1/; #include "sa8775p-ride-r3.dts" +#include "sa8775p-iot.dtsi" + / { model = "Qualcomm QCS9100 Ride Rev3"; compatible = "qcom,qcs9100-ride-r3", "qcom,qcs9100", "qcom,sa8775p"; diff --git a/arch/arm64/boot/dts/qcom/qcs9100-ride.dts b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts index 979462dfec30ecbe6c437fd676c3da2d4386ff8e..27d5461acbf070d696cdad0c068f4e031f2beb67 100644 --- a/arch/arm64/boot/dts/qcom/qcs9100-ride.dts +++ b/arch/arm64/boot/dts/qcom/qcs9100-ride.dts @@ -5,6 +5,8 @@ /dts-v1/; #include "sa8775p-ride.dts" +#include "sa8775p-iot.dtsi" + / { model = "Qualcomm QCS9100 Ride"; compatible = "qcom,qcs9100-ride", "qcom,qcs9100", "qcom,sa8775p";
Update the iot specific memory map for qcs9100* boards. Signed-off-by: Pratyush Brahma <quic_pbrahma@quicinc.com> --- arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++ arch/arm64/boot/dts/qcom/qcs9100-ride.dts | 2 ++ 2 files changed, 4 insertions(+)