mbox series

[0/1] fix priv->dai_props indexing

Message ID 20250114184314.3583-1-laurentiumihalcea111@gmail.com (mailing list archive)
Headers show
Series fix priv->dai_props indexing | expand

Message

Laurentiu Mihalcea Jan. 14, 2025, 6:43 p.m. UTC
From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>

Fix priv->dai_props indexing in simple-card-utils.c by introducing
a new macro: runtime_simple_priv_to_props() that can be used when
dealing with PCM runtime data as rtd->id may be invalid.

Changes since RFC:
- added comment that should help clarify when the new macro
 should be used
- Link to RFC: https://lore.kernel.org/lkml/20241220151213.2462-1-laurentiumihalcea111@gmail.com/

Laurentiu Mihalcea (1):
  ASoC: simple-card-utils: fix priv->dai_props indexing

 include/sound/simple_card_utils.h     |  7 +++++++
 sound/soc/generic/simple-card-utils.c | 10 +++++-----
 2 files changed, 12 insertions(+), 5 deletions(-)

Comments

Mark Brown Jan. 14, 2025, 7:46 p.m. UTC | #1
On Tue, Jan 14, 2025 at 01:43:13PM -0500, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com>
> 
> Fix priv->dai_props indexing in simple-card-utils.c by introducing
> a new macro: runtime_simple_priv_to_props() that can be used when
> dealing with PCM runtime data as rtd->id may be invalid.

Please don't send cover letters for single patches, if there is anything
that needs saying put it in the changelog of the patch or after the ---
if it's administrative stuff.  This reduces mail volume and ensures that 
any important information is recorded in the changelog rather than being
lost.
Mark Brown Jan. 15, 2025, 7:49 p.m. UTC | #2
On Tue, 14 Jan 2025 13:43:13 -0500, Laurentiu Mihalcea wrote:
> Fix priv->dai_props indexing in simple-card-utils.c by introducing
> a new macro: runtime_simple_priv_to_props() that can be used when
> dealing with PCM runtime data as rtd->id may be invalid.
> 
> Changes since RFC:
> - added comment that should help clarify when the new macro
>  should be used
> - Link to RFC: https://lore.kernel.org/lkml/20241220151213.2462-1-laurentiumihalcea111@gmail.com/
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: simple-card-utils: fix priv->dai_props indexing
      commit: 04e97fa7dd7e3eda754712f92df2136acd1d9088

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark