[net-next,0/3] net: bcm: asp2: fix fallout from phylib EEE changes

Message

Russell King (Oracle) Jan. 14, 2025, 4:50 p.m. UTC

Hi,

This series addresses the fallout from the phylib changes in the
Broadcom ASP2 driver.

The first patch uses phylib's copy of the LPI timer setting, which
means the driver no longer has to track this. It will be set in
hardware each time the adjust_link function is called when the link
is up, and will be read at initialisation time to set the current
value.

The second patch removes the driver's storage of tx_lpi_enabled,
which has become redundant since phylib managed EEE was merged. The
driver does nothing with this flag other than storing it.

The last patch converts the driver to use phylib's enable_tx_lpi
flag rather than trying to maintain its own copy.

 drivers/net/ethernet/broadcom/asp2/bcmasp.h        |  3 --
 .../net/ethernet/broadcom/asp2/bcmasp_ethtool.c    | 39 ----------------------
 drivers/net/ethernet/broadcom/asp2/bcmasp_intf.c   | 22 +++++++-----
 3 files changed, 14 insertions(+), 50 deletions(-)

Comments

[e-mail] Jan. 15, 2025, 9:30 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <[e-mail]>:

On Tue, 14 Jan 2025 16:50:37 +0000 you wrote:
> Hi,
> 
> This series addresses the fallout from the phylib changes in the
> Broadcom ASP2 driver.
> 
> The first patch uses phylib's copy of the LPI timer setting, which
> means the driver no longer has to track this. It will be set in
> hardware each time the adjust_link function is called when the link
> is up, and will be read at initialisation time to set the current
> value.
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] net: bcm: asp2: fix LPI timer handling
    https://git.kernel.org/netdev/net-next/c/54033f551219
  - [net-next,2/3] net: bcm: asp2: remove tx_lpi_enabled
    https://git.kernel.org/netdev/net-next/c/df8017e8a19d
  - [net-next,3/3] net: bcm: asp2: convert to phylib managed EEE
    https://git.kernel.org/netdev/net-next/c/21f56ad1b211

You are awesome, thank you!