| Message ID | 20250114220147.757075-4-ninad@linux.ibm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | DTS updates for system1 BMC | expand |
On Tue, 14 Jan 2025 16:01:37 -0600, Ninad Palsule wrote: > Allow parsing GPIO controller children nodes with GPIO hogs. > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > --- > .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250114220147.757075-4-ninad@linux.ibm.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Tue, Jan 14, 2025 at 04:01:37PM -0600, Ninad Palsule wrote: > Allow parsing GPIO controller children nodes with GPIO hogs. > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > --- > .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > index b9afd07a9d24..b9bc4fe4d5a6 100644 > --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > @@ -46,6 +46,12 @@ properties: > minimum: 12 > maximum: 232 > > +patternProperties: > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": Choose one - suffix or prefix. More popular is suffix. Best regards, Krzysztof
On Wed, Jan 15, 2025 at 09:45:50AM +0100, Krzysztof Kozlowski wrote: > On Tue, Jan 14, 2025 at 04:01:37PM -0600, Ninad Palsule wrote: > > Allow parsing GPIO controller children nodes with GPIO hogs. > > > > Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > > --- > > .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > > index b9afd07a9d24..b9bc4fe4d5a6 100644 > > --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > > +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml > > @@ -46,6 +46,12 @@ properties: > > minimum: 12 > > maximum: 232 > > > > +patternProperties: > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > > Choose one - suffix or prefix. More popular is suffix. I was about to say that, but this matches what gpio-hog.yaml defines. Why we did both, I don't remember. We could probably eliminate 'hog-[0-9]+' as that doesn't appear to be used much. Long term, I want to make all gpio controllers reference a gpio controller schema and put the hog stuff there. Then we have the node names defined in 1 place. Rob
On 15/01/2025 15:24, Rob Herring wrote: >>> >>> +patternProperties: >>> + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": >> >> Choose one - suffix or prefix. More popular is suffix. > > I was about to say that, but this matches what gpio-hog.yaml defines. > Why we did both, I don't remember. We could probably eliminate > 'hog-[0-9]+' as that doesn't appear to be used much. Only one case: arch/arm64/boot/dts/nvidia/tegra210-p2894.dtsi: hog-0 { Although there are few "hog" prefixes followed by alphanumeric, so not matching above pattern. > > Long term, I want to make all gpio controllers reference a gpio > controller schema and put the hog stuff there. Then we have the node > names defined in 1 place. Best regards, Krzysztof
On Wed, Jan 15, 2025 at 03:53:38PM -0600, Ninad Palsule wrote: > > > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > > > Choose one - suffix or prefix. More popular is suffix. > > I was about to say that, but this matches what gpio-hog.yaml defines. > > Why we did both, I don't remember. We could probably eliminate > > 'hog-[0-9]+' as that doesn't appear to be used much. > > > > Long term, I want to make all gpio controllers reference a gpio > > controller schema and put the hog stuff there. Then we have the node > > names defined in 1 place. > > Which one of the following are you suggesting? > > "^(.+-hog(-[0-9]+)?)$" This. The second part of pattern. I'll send a patch for dtschema to drop the prefix version. Best regards, Krzysztof
On Thu, Jan 16, 2025 at 08:19:25AM -0600, Ninad Palsule wrote: > Hi Krzysztof, > > On 1/16/25 04:38, Krzysztof Kozlowski wrote: > > On Wed, Jan 15, 2025 at 03:53:38PM -0600, Ninad Palsule wrote: > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > > Choose one - suffix or prefix. More popular is suffix. > > I was about to say that, but this matches what gpio-hog.yaml defines. > Why we did both, I don't remember. We could probably eliminate > 'hog-[0-9]+' as that doesn't appear to be used much. > > Long term, I want to make all gpio controllers reference a gpio > controller schema and put the hog stuff there. Then we have the node > names defined in 1 place. > > Which one of the following are you suggesting? > > "^(.+-hog(-[0-9]+)?)$" > > This. The second part of pattern. > > I'll send a patch for dtschema to drop the prefix version. > > Thanks. Also thanks for the other patch. It helped a lot. Please fix your mail client to properly quote replies Rob
Hi Rob, On 1/14/25 17:57, Rob Herring (Arm) wrote: > On Tue, 14 Jan 2025 16:01:37 -0600, Ninad Palsule wrote: >> Allow parsing GPIO controller children nodes with GPIO hogs. >> >> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> >> --- >> .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > > > doc reference errors (make refcheckdocs): I am not seeing any error even after upgrading dtschema. Also this mail also doesn't show any warning. Is this false negative? HOSTLD scripts/dtc/fdtoverlay CHKDT ./Documentation/devicetree/bindings LINT ./Documentation/devicetree/bindings DTEX Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.example.dts DTC [C] Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.example.dtb Regards, Ninad >
Hi Rob, On 1/15/25 08:24, Rob Herring wrote: > > I was about to say that, but this matches what gpio-hog.yaml defines. > Why we did both, I don't remember. We could probably eliminate > 'hog-[0-9]+' as that doesn't appear to be used much. > > Long term, I want to make all gpio controllers reference a gpio > controller schema and put the hog stuff there. Then we have the node > names defined in 1 place. Ok, choosing suffix. Thanks for the review. Regards, Ninad
On Thu, Jan 16, 2025 at 9:04 AM Ninad Palsule <ninad@linux.ibm.com> wrote: > > Hi Rob, > > On 1/14/25 17:57, Rob Herring (Arm) wrote: > > On Tue, 14 Jan 2025 16:01:37 -0600, Ninad Palsule wrote: > >> Allow parsing GPIO controller children nodes with GPIO hogs. > >> > >> Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> > >> --- > >> .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > > My bot found errors running 'make dt_binding_check' on your patch: > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > > > > > doc reference errors (make refcheckdocs): > > I am not seeing any error even after upgrading dtschema. Also this mail > also doesn't show any warning. Is this false negative? I believe this happens when a prior patch in the series has an error. Rob
Hi Rob, >> I am not seeing any error even after upgrading dtschema. Also this mail >> also doesn't show any warning. Is this false negative? > > I believe this happens when a prior patch in the series has an error. Thanks for the response. I have sent a next version.
diff --git a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml index b9afd07a9d24..b9bc4fe4d5a6 100644 --- a/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml +++ b/Documentation/devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml @@ -46,6 +46,12 @@ properties: minimum: 12 maximum: 232 +patternProperties: + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": + type: object + required: + - gpio-hog + required: - compatible - reg
Allow parsing GPIO controller children nodes with GPIO hogs. Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> --- .../devicetree/bindings/gpio/aspeed,ast2400-gpio.yaml | 6 ++++++ 1 file changed, 6 insertions(+)