mbox series

[v1,net-next,0/3] dev: Covnert dev_change_name() to per-netns RTNL.

Message ID 20250115095545.52709-1-kuniyu@amazon.com (mailing list archive)
Headers show
Series dev: Covnert dev_change_name() to per-netns RTNL. | expand

Message

Kuniyuki Iwashima Jan. 15, 2025, 9:55 a.m. UTC
Patch 1 adds a missing netdev_rename_lock in dev_change_name()
and Patch 2 removes unnecessary devnet_rename_sem there.

Patch 3 replaces RTNL with rtnl_net_lock() in dev_ifsioc(),
and now dev_change_name() is always called under per-netns RTNL.

Given it's close to -rc8 and Patch 1 touches the trivial unlikely
path, can Patch 1 go into net-next ?  Otherwise I'll post Patch 2 & 3
separately in the next cycle.


Kuniyuki Iwashima (3):
  dev: Acquire netdev_rename_lock before restoring dev->name in
    dev_change_name().
  dev: Remove devnet_rename_sem.
  dev: Hold rtnl_net_lock() for dev_ifsioc().

 net/core/dev.c            | 25 ++++++-------------------
 net/core/dev_ioctl.c      | 26 +++++++++++++++++---------
 net/core/rtnl_net_debug.c | 15 +++------------
 3 files changed, 26 insertions(+), 40 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Jan. 17, 2025, 1:30 a.m. UTC | #1
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 15 Jan 2025 18:55:42 +0900 you wrote:
> Patch 1 adds a missing netdev_rename_lock in dev_change_name()
> and Patch 2 removes unnecessary devnet_rename_sem there.
> 
> Patch 3 replaces RTNL with rtnl_net_lock() in dev_ifsioc(),
> and now dev_change_name() is always called under per-netns RTNL.
> 
> Given it's close to -rc8 and Patch 1 touches the trivial unlikely
> path, can Patch 1 go into net-next ?  Otherwise I'll post Patch 2 & 3
> separately in the next cycle.
> 
> [...]

Here is the summary with links:
  - [v1,net-next,1/3] dev: Acquire netdev_rename_lock before restoring dev->name in dev_change_name().
    https://git.kernel.org/netdev/net-next/c/e361560a7912
  - [v1,net-next,2/3] dev: Remove devnet_rename_sem.
    https://git.kernel.org/netdev/net-next/c/2f1bb1e2cc00
  - [v1,net-next,3/3] dev: Hold rtnl_net_lock() for dev_ifsioc().
    https://git.kernel.org/netdev/net-next/c/be94cfdb993f

You are awesome, thank you!