| Message ID | ec38214e-0bbb-4c5a-94ff-b2b2d4c3f245@stanley.mountain (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | dmaengine: idxd: Delete unnecessary NULL check | expand |
On 1/8/25 01:13, Dan Carpenter wrote: > The "saved_evl" pointer is a offset into the middle of a non-NULL struct. > It can't be NULL and the check is slightly confusing. Delete the check. > > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Fenghua Yu <fenghua.yu@intel.com> > --- > drivers/dma/idxd/init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c > index b946f78f85e1..fca1d2924999 100644 > --- a/drivers/dma/idxd/init.c > +++ b/drivers/dma/idxd/init.c > @@ -912,8 +912,7 @@ static void idxd_device_config_restore(struct idxd_device *idxd, > > idxd->rdbuf_limit = idxd_saved->saved_idxd.rdbuf_limit; > > - if (saved_evl) > - idxd->evl->size = saved_evl->size; > + idxd->evl->size = saved_evl->size; > > for (i = 0; i < idxd->max_groups; i++) { > struct idxd_group *saved_group, *group; Thanks. -Fenghua
diff --git a/drivers/dma/idxd/init.c b/drivers/dma/idxd/init.c index b946f78f85e1..fca1d2924999 100644 --- a/drivers/dma/idxd/init.c +++ b/drivers/dma/idxd/init.c @@ -912,8 +912,7 @@ static void idxd_device_config_restore(struct idxd_device *idxd, idxd->rdbuf_limit = idxd_saved->saved_idxd.rdbuf_limit; - if (saved_evl) - idxd->evl->size = saved_evl->size; + idxd->evl->size = saved_evl->size; for (i = 0; i < idxd->max_groups; i++) { struct idxd_group *saved_group, *group;
The "saved_evl" pointer is a offset into the middle of a non-NULL struct. It can't be NULL and the check is slightly confusing. Delete the check. Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/dma/idxd/init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)