| Message ID | 20250116-mt8370-enable-gpu-v1-1-0a6b78e925c8@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add Mali GPU support for Mediatek MT8370 SoC | expand |
On Thu, Jan 16, 2025 at 03:25:57PM +0100, Louis-Alexis Eyraud wrote: > This commit adds a compatible for the MediaTek MT8370 SoC, with an Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core). Anyway, your commit msg explains "what" which is obvious. Say something not obvious - e.g. not compatible with 8192? Why not? > > Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> > --- > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index 735c7f06c24e632ab738d062f15378f754c8adaf..6f6211950bb495fa6bfcdfe8d1e27e5ce7aeeae0 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -37,6 +37,7 @@ properties: > - enum: > - mediatek,mt8188-mali > - mediatek,mt8192-mali > + - mediatek,mt8370-mali > - const: arm,mali-valhall-jm # Mali Valhall GPU model/revision is fully discoverable Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 735c7f06c24e632ab738d062f15378f754c8adaf..6f6211950bb495fa6bfcdfe8d1e27e5ce7aeeae0 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -37,6 +37,7 @@ properties: - enum: - mediatek,mt8188-mali - mediatek,mt8192-mali + - mediatek,mt8370-mali - const: arm,mali-valhall-jm # Mali Valhall GPU model/revision is fully discoverable reg: @@ -217,7 +218,9 @@ allOf: properties: compatible: contains: - const: mediatek,mt8186-mali + enum: + - mediatek,mt8186-mali + - mediatek,mt8370-mali then: properties: power-domains:
This commit adds a compatible for the MediaTek MT8370 SoC, with an integrated ARM Mali G57 MC2 GPU (Valhall-JM, dual core). Signed-off-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com> --- Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)