| Message ID | alpine.DEB.2.22.394.2501101117030.1731534@ubuntu-linux-20-04-desktop (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] xen: update pvcalls_front_accept prototype | expand |
On 10.01.25 20:18, Stefano Stabellini wrote: > While currently there are no in-tree callers of these functions, it is > best to keep them up-to-date with the latest network API. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com> What are your future plans regarding usage of this function? I guess you are looking into an addition to the pvcalls driver? If the plan is to use it from a different driver, I'd recommend adding the missing EXPORT_SYMBOL[_GPL]() right away. Juergen
diff --git a/drivers/xen/pvcalls-front.c b/drivers/xen/pvcalls-front.c index b72ee9379d77..cab480059731 100644 --- a/drivers/xen/pvcalls-front.c +++ b/drivers/xen/pvcalls-front.c @@ -769,7 +769,8 @@ int pvcalls_front_listen(struct socket *sock, int backlog) return ret; } -int pvcalls_front_accept(struct socket *sock, struct socket *newsock, int flags) +int pvcalls_front_accept(struct socket *sock, struct socket *newsock, + struct proto_accept_arg *arg) { struct pvcalls_bedata *bedata; struct sock_mapping *map; @@ -788,7 +789,7 @@ int pvcalls_front_accept(struct socket *sock, struct socket *newsock, int flags) return -EINVAL; } - nonblock = flags & SOCK_NONBLOCK; + nonblock = arg->flags & SOCK_NONBLOCK; /* * Backend only supports 1 inflight accept request, will return * errors for the others diff --git a/drivers/xen/pvcalls-front.h b/drivers/xen/pvcalls-front.h index f694ad77379f..881ef14660bc 100644 --- a/drivers/xen/pvcalls-front.h +++ b/drivers/xen/pvcalls-front.h @@ -12,7 +12,7 @@ int pvcalls_front_bind(struct socket *sock, int pvcalls_front_listen(struct socket *sock, int backlog); int pvcalls_front_accept(struct socket *sock, struct socket *newsock, - int flags); + struct proto_accept_arg *arg); int pvcalls_front_sendmsg(struct socket *sock, struct msghdr *msg, size_t len);
While currently there are no in-tree callers of these functions, it is best to keep them up-to-date with the latest network API. Signed-off-by: Stefano Stabellini <stefano.stabellini@amd.com> --- Changes in v3: expand commit message --- drivers/xen/pvcalls-front.c | 5 +++-- drivers/xen/pvcalls-front.h | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)