diff mbox series

ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER

Message ID 20250122065330.1423248-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit a2cd92185db0586f2136feae84d98cc54580f381
Headers show
Series ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER | expand

Commit Message

Arnd Bergmann Jan. 22, 2025, 6:53 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Randconfig builds without dmabuf result in this link error from
the fasl-asrc driver:

ERROR: modpost: "dma_buf_put" [sound/core/snd-compress.ko] undefined!
ERROR: modpost: "dma_buf_export" [sound/soc/fsl/snd-soc-fsl-asrc.ko] undefined!

Add the missing 'select' statement.

Fixes: 24a01710f627 ("ASoC: fsl_asrc_m2m: Add memory to memory function")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 sound/soc/fsl/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Daniel Baluta Jan. 22, 2025, 8:24 a.m. UTC | #1 
On Wed, Jan 22, 2025 at 8:53 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Randconfig builds without dmabuf result in this link error from
> the fasl-asrc driver:
>
> ERROR: modpost: "dma_buf_put" [sound/core/snd-compress.ko] undefined!
> ERROR: modpost: "dma_buf_export" [sound/soc/fsl/snd-soc-fsl-asrc.ko] undefined!
>
> Add the missing 'select' statement.
>
> Fixes: 24a01710f627 ("ASoC: fsl_asrc_m2m: Add memory to memory function")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Mark Brown Jan. 23, 2025, 11:29 a.m. UTC | #2 
On Wed, 22 Jan 2025 07:53:17 +0100, Arnd Bergmann wrote:
> Randconfig builds without dmabuf result in this link error from
> the fasl-asrc driver:
> 
> ERROR: modpost: "dma_buf_put" [sound/core/snd-compress.ko] undefined!
> ERROR: modpost: "dma_buf_export" [sound/soc/fsl/snd-soc-fsl-asrc.ko] undefined!
> 
> Add the missing 'select' statement.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: fsl_asrc_m2m: select CONFIG_DMA_SHARED_BUFFER
      commit: a2cd92185db0586f2136feae84d98cc54580f381

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index e5fbf5305ea2..c4cf3cff58de 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -6,6 +6,7 @@  comment "Common SoC Audio options for Freescale CPUs:"
 config SND_SOC_FSL_ASRC
 	tristate "Asynchronous Sample Rate Converter (ASRC) module support"
 	depends on HAS_DMA
+	select DMA_SHARED_BUFFER
 	select REGMAP_MMIO
 	select SND_SOC_GENERIC_DMAENGINE_PCM
 	select SND_COMPRESS_ACCEL