| Message ID | 20250122094707.24859-2-quic_sachgupt@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | mmc: sdhci-msm: Rectify DLL programming sequence for SDCC | expand |
On 22/01/2025 10:47, Sachin Gupta wrote: > Document the 'dll-hsr-list' property for MMC device tree bindings. > The 'dll-hsr-list' property defines the DLL configurations for HS400 > and HS200 modes. > > Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > index 8b393e26e025..65dc3053df75 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml > @@ -133,6 +133,11 @@ properties: > $ref: /schemas/types.yaml#/definitions/uint32 > description: platform specific settings for DLL_CONFIG reg. > > + qcom,dll-hsr-list: > + maxItems: 10 > + $ref: /schemas/types.yaml#/definitions/uint32 uint32 has only one item. Anyway, there is already DLL there, so don't duplicate or explain why this is different. Explain also why this is not deducible from the compatible. Please provide here link to DTS user so we can validate how you use it. Best regards, Krzysztof
On Wed, 22 Jan 2025 15:17:04 +0530, Sachin Gupta wrote: > Document the 'dll-hsr-list' property for MMC device tree bindings. > The 'dll-hsr-list' property defines the DLL configurations for HS400 > and HS200 modes. > > Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml: properties:qcom,dll-hsr-list:maxItems: False schema does not allow 10 hint: Scalar properties should not have array keywords from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250122094707.24859-2-quic_sachgupt@quicinc.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml index 8b393e26e025..65dc3053df75 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml @@ -133,6 +133,11 @@ properties: $ref: /schemas/types.yaml#/definitions/uint32 description: platform specific settings for DLL_CONFIG reg. + qcom,dll-hsr-list: + maxItems: 10 + $ref: /schemas/types.yaml#/definitions/uint32 + description: platform specific settings for DLL registers. + iommus: minItems: 1 maxItems: 8
Document the 'dll-hsr-list' property for MMC device tree bindings. The 'dll-hsr-list' property defines the DLL configurations for HS400 and HS200 modes. Signed-off-by: Sachin Gupta <quic_sachgupt@quicinc.com> --- Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 5 +++++ 1 file changed, 5 insertions(+)