diff mbox series

[f2fs-dev] f2fs: Clean up the loop outside of f2fs_invalidate_blocks()

Message ID 20250113014702.2312729-1-yi.sun@unisoc.com (mailing list archive)
State Accepted
Commit 6d4008dc4a8e0949afe1d9ff27c93fe68672ea06
Headers show
Series [f2fs-dev] f2fs: Clean up the loop outside of f2fs_invalidate_blocks() | expand

Commit Message

Yi Sun Jan. 13, 2025, 1:47 a.m. UTC 
Now f2fs_invalidate_blocks() supports a continuous range of addresses,
so the for loop can be omitted.

Signed-off-by: Yi Sun <yi.sun@unisoc.com>
Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
---
 fs/f2fs/file.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Chao Yu Jan. 22, 2025, 7:59 a.m. UTC | #1 
On 1/13/25 09:47, Yi Sun wrote:
> Now f2fs_invalidate_blocks() supports a continuous range of addresses,
> so the for loop can be omitted.
> 
> Signed-off-by: Yi Sun <yi.sun@unisoc.com>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>

Actually, this can be merged into "f2fs: add parameter @len to 
f2fs_invalidate_blocks()", but, anyway, I guess it's fine to merge it separately.

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,

> ---
>   fs/f2fs/file.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
> index 9980d17ef9f5..4baafad7a00c 100644
> --- a/fs/f2fs/file.c
> +++ b/fs/f2fs/file.c
> @@ -811,10 +811,8 @@ int f2fs_do_truncate_blocks(struct inode *inode, u64 from, bool lock)
>   	if (IS_DEVICE_ALIASING(inode)) {
>   		struct extent_tree *et = F2FS_I(inode)->extent_tree[EX_READ];
>   		struct extent_info ei = et->largest;
> -		unsigned int i;
>   
> -		for (i = 0; i < ei.len; i++)
> -			f2fs_invalidate_blocks(sbi, ei.blk + i, 1);
> +		f2fs_invalidate_blocks(sbi, ei.blk, ei.len);
>   
>   		dec_valid_block_count(sbi, inode, ei.len);
>   		f2fs_update_time(sbi, REQ_TIME);
patchwork-bot+f2fs--- via Linux-f2fs-devel Jan. 22, 2025, 9:20 p.m. UTC | #2 
Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <jaegeuk@kernel.org>:

On Mon, 13 Jan 2025 09:47:02 +0800 you wrote:
> Now f2fs_invalidate_blocks() supports a continuous range of addresses,
> so the for loop can be omitted.
> 
> Signed-off-by: Yi Sun <yi.sun@unisoc.com>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> ---
>  fs/f2fs/file.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
  - [f2fs-dev] f2fs: Clean up the loop outside of f2fs_invalidate_blocks()
    https://git.kernel.org/jaegeuk/f2fs/c/6d4008dc4a8e

You are awesome, thank you!
diff mbox series

Patch

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 9980d17ef9f5..4baafad7a00c 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -811,10 +811,8 @@  int f2fs_do_truncate_blocks(struct inode *inode, u64 from, bool lock)
 	if (IS_DEVICE_ALIASING(inode)) {
 		struct extent_tree *et = F2FS_I(inode)->extent_tree[EX_READ];
 		struct extent_info ei = et->largest;
-		unsigned int i;
 
-		for (i = 0; i < ei.len; i++)
-			f2fs_invalidate_blocks(sbi, ei.blk + i, 1);
+		f2fs_invalidate_blocks(sbi, ei.blk, ei.len);
 
 		dec_valid_block_count(sbi, inode, ei.len);
 		f2fs_update_time(sbi, REQ_TIME);