| Message ID | 20250122103911.517484-3-john.madieu.xa@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | soc: renesas: Add RZ/G3E SoC detection support | expand |
On Wed, Jan 22, 2025 at 11:39:04AM +0100, John Madieu wrote: > Add RZ/G3E (R9A09G047) variant to the existing RZ/V2H System > Controller (SYS) binding as both IPs are compatible. > > They however have different SoC IDs, RZ/G3E has has VSP control Register > compared to RZ/V2H SYS IP. Hence a new compatible string renesas,r9a09g047-sys > introduced to handle these differences. > > Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com> > --- > .../bindings/soc/renesas/renesas,r9a09g057-sys.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions of patchset, under or above your Signed-off-by tag, unless patch changed significantly (e.g. new properties added to the DT bindings). Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. Please read: https://elixir.bootlin.com/linux/v6.12-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
On 22/01/2025 11:39, John Madieu wrote: > Add RZ/G3E (R9A09G047) variant to the existing RZ/V2H System > Controller (SYS) binding as both IPs are compatible. > > They however have different SoC IDs, RZ/G3E has has VSP control Register And since you have to now resend entire patchset due to not reading submitting patches, then more work: Double 'has' > compared to RZ/V2H SYS IP. Hence a new compatible string renesas,r9a09g047-sys Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Best regards, Krzysztof
Hi Krzysztof, Thanks for your feedback. > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Thursday, January 23, 2025 8:45 AM > Subject: Re: [PATCH v3 2/9] dt-bindings: soc: renesas: Add RZ/G3E variant > SYS binding > > On Wed, Jan 22, 2025 at 11:39:04AM +0100, John Madieu wrote: > > Add RZ/G3E (R9A09G047) variant to the existing RZ/V2H System > > Controller (SYS) binding as both IPs are compatible. > > > > They however have different SoC IDs, RZ/G3E has has VSP control > > Register compared to RZ/V2H SYS IP. Hence a new compatible string > > renesas,r9a09g047-sys introduced to handle these differences. > > > > Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com> > > --- > > .../bindings/soc/renesas/renesas,r9a09g057-sys.yaml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > Thanks for the link[1]. I forgot to add the Rb tag from Rob and I also updated the commit description. I Will fix it in v4. [1] https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 Best regards, John
diff --git a/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml index ebbf0c9109ce..e0f7503a9f35 100644 --- a/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml +++ b/Documentation/devicetree/bindings/soc/renesas/renesas,r9a09g057-sys.yaml @@ -22,7 +22,10 @@ description: | properties: compatible: - const: renesas,r9a09g057-sys + items: + - enum: + - renesas,r9a09g047-sys # RZ/G3E + - renesas,r9a09g057-sys # RZ/V2H reg: maxItems: 1
Add RZ/G3E (R9A09G047) variant to the existing RZ/V2H System Controller (SYS) binding as both IPs are compatible. They however have different SoC IDs, RZ/G3E has has VSP control Register compared to RZ/V2H SYS IP. Hence a new compatible string renesas,r9a09g047-sys introduced to handle these differences. Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com> --- .../bindings/soc/renesas/renesas,r9a09g057-sys.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)