| Message ID | 20250118111344.361617-1-marek.vasut+renesas@mailbox.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 4ac27cac07c1c6a5dd4ffed2797fb18cf866df17 |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [1/5] arm64: dts: renesas: r8a779f0: Add labels for rswitch ports | expand |
Hi Marek, On Sat, Jan 18, 2025 at 12:14 PM Marek Vasut <marek.vasut+renesas@mailbox.org> wrote: > Introduce labels for each rswitch port in the form 'rswitchportN'. > Those can be used to access rswitch port nodes directly, which is > going to be useful in reducing DT indentation slightly as well as > in DT /aliases node to reference the rswitch ports as ethernetN > interfaces. No functional change. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> Thanks for your patch! Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.15. > --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi > @@ -974,15 +974,15 @@ ethernet-ports { > #address-cells = <1>; > #size-cells = <0>; > > - port@0 { > + rswitchport0: port@0 { > reg = <0>; > phys = <ð_serdes 0>; > }; > - port@1 { > + rswitchport1: port@1 { > reg = <1>; > phys = <ð_serdes 1>; > }; > - port@2 { > + rswitchport2: port@2 { > reg = <2>; > phys = <ð_serdes 2>; > }; Would you mind if I would change all rswitchportN to rswitch_portN while applying, for consistency with other Renesas DTS files? Gr{oetje,eeting}s, Geert
On 1/23/25 4:25 PM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Sat, Jan 18, 2025 at 12:14 PM Marek Vasut > <marek.vasut+renesas@mailbox.org> wrote: >> Introduce labels for each rswitch port in the form 'rswitchportN'. >> Those can be used to access rswitch port nodes directly, which is >> going to be useful in reducing DT indentation slightly as well as >> in DT /aliases node to reference the rswitch ports as ethernetN >> interfaces. No functional change. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > > Thanks for your patch! > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > i.e. will queue in renesas-devel for v6.15. > >> --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi >> +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi >> @@ -974,15 +974,15 @@ ethernet-ports { >> #address-cells = <1>; >> #size-cells = <0>; >> >> - port@0 { >> + rswitchport0: port@0 { >> reg = <0>; >> phys = <ð_serdes 0>; >> }; >> - port@1 { >> + rswitchport1: port@1 { >> reg = <1>; >> phys = <ð_serdes 1>; >> }; >> - port@2 { >> + rswitchport2: port@2 { >> reg = <2>; >> phys = <ð_serdes 2>; >> }; > > Would you mind if I would change all rswitchportN to rswitch_portN > while applying, for consistency with other Renesas DTS files? Go ahead, but also keep the commit messages in sync . I can send a V2 too ?
Hi Marek, On Thu, Jan 23, 2025 at 5:20 PM Marek Vasut <marek.vasut@mailbox.org> wrote: > On 1/23/25 4:25 PM, Geert Uytterhoeven wrote: > > On Sat, Jan 18, 2025 at 12:14 PM Marek Vasut > > <marek.vasut+renesas@mailbox.org> wrote: > >> Introduce labels for each rswitch port in the form 'rswitchportN'. > >> Those can be used to access rswitch port nodes directly, which is > >> going to be useful in reducing DT indentation slightly as well as > >> in DT /aliases node to reference the rswitch ports as ethernetN > >> interfaces. No functional change. > >> > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > > > > Thanks for your patch! > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > i.e. will queue in renesas-devel for v6.15. > > > >> --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi > >> +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi > >> @@ -974,15 +974,15 @@ ethernet-ports { > >> #address-cells = <1>; > >> #size-cells = <0>; > >> > >> - port@0 { > >> + rswitchport0: port@0 { > >> reg = <0>; > >> phys = <ð_serdes 0>; > >> }; > >> - port@1 { > >> + rswitchport1: port@1 { > >> reg = <1>; > >> phys = <ð_serdes 1>; > >> }; > >> - port@2 { > >> + rswitchport2: port@2 { > >> reg = <2>; > >> phys = <ð_serdes 2>; > >> }; > > > > Would you mind if I would change all rswitchportN to rswitch_portN > > while applying, for consistency with other Renesas DTS files? > > Go ahead, but also keep the commit messages in sync . Sure ;-) > I can send a V2 too ? No need for that, as I already made these changes locally. Thanks! Gr{oetje,eeting}s, Geert
diff --git a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi index 054498e54730b..8d296d0ebdfdc 100644 --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi @@ -974,15 +974,15 @@ ethernet-ports { #address-cells = <1>; #size-cells = <0>; - port@0 { + rswitchport0: port@0 { reg = <0>; phys = <ð_serdes 0>; }; - port@1 { + rswitchport1: port@1 { reg = <1>; phys = <ð_serdes 1>; }; - port@2 { + rswitchport2: port@2 { reg = <2>; phys = <ð_serdes 2>; };
Introduce labels for each rswitch port in the form 'rswitchportN'. Those can be used to access rswitch port nodes directly, which is going to be useful in reducing DT indentation slightly as well as in DT /aliases node to reference the rswitch ports as ethernetN interfaces. No functional change. Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org> --- Cc: Conor Dooley <conor+dt@kernel.org> Cc: Geert Uytterhoeven <geert+renesas@glider.be> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org> Cc: Rob Herring <robh@kernel.org> Cc: devicetree@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org --- arch/arm64/boot/dts/renesas/r8a779f0.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)