| Message ID | 20250114-omap-gpmc-drop-no-compatible-check-v1-1-262c8d549732@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | memory: omap-gpmc: drop no compatible check | expand |
On Tue, Jan 14, 2025 at 10:36 AM Roger Quadros <rogerq@kernel.org> wrote: > > We are no longer depending on legacy device trees so > drop the no compatible check for NAND and OneNAND > nodes. > > Suggested-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: Roger Quadros <rogerq@kernel.org> > --- > drivers/memory/omap-gpmc.c | 20 -------------------- > 1 file changed, 20 deletions(-) Reviewed-by: Rob Herring (Arm) <robh@kernel.org> Ideally this can be picked up for 6.14 because the of_property_read_bool() calls will generate a warning reading non-bool property. Rob
On Tue, 14 Jan 2025 18:36:28 +0200, Roger Quadros wrote: > We are no longer depending on legacy device trees so > drop the no compatible check for NAND and OneNAND > nodes. > > Applied, thanks! [1/1] memory: omap-gpmc: drop no compatible check https://git.kernel.org/krzk/linux-mem-ctrl/c/304e6c02b76f019016cd492d2d544e07c5753d30 Best regards,
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index 50eb9f49512b..368b0848b64d 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -2245,26 +2245,6 @@ static int gpmc_probe_generic_child(struct platform_device *pdev, goto err; } - if (of_node_name_eq(child, "nand")) { - /* Warn about older DT blobs with no compatible property */ - if (!of_property_read_bool(child, "compatible")) { - dev_warn(&pdev->dev, - "Incompatible NAND node: missing compatible"); - ret = -EINVAL; - goto err; - } - } - - if (of_node_name_eq(child, "onenand")) { - /* Warn about older DT blobs with no compatible property */ - if (!of_property_read_bool(child, "compatible")) { - dev_warn(&pdev->dev, - "Incompatible OneNAND node: missing compatible"); - ret = -EINVAL; - goto err; - } - } - if (of_match_node(omap_nand_ids, child)) { /* NAND specific setup */ val = 8;
We are no longer depending on legacy device trees so drop the no compatible check for NAND and OneNAND nodes. Suggested-by: Rob Herring (Arm) <robh@kernel.org> Signed-off-by: Roger Quadros <rogerq@kernel.org> --- drivers/memory/omap-gpmc.c | 20 -------------------- 1 file changed, 20 deletions(-) --- base-commit: 5bc55a333a2f7316b58edc7573e8e893f7acb532 change-id: 20250114-omap-gpmc-drop-no-compatible-check-c9183d316591 Best regards,