| Message ID | 20250127064940.1360404-1-quic_janathot@quicinc.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Enable Bluetooth on qcs6490-rb3gen2 board | expand |
On 27/01/2025 07:49, Janaki Ramaiah Thota wrote: > Resending the below reviewed patches after fixing the regulator warnings in v7 P1. > - Patch 1/2 Add and enable BT node for qcs6490-rb3gen board. > - Patch 2/2 Use the power sequencer for wcn6750. > > ---- > Changes from v7: > * updated P1 & P2 with tag: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > * Link to v7: https://lore.kernel.org/lkml/20250107134157.211702-1-quic_janathot@quicinc.com/#t > > Changes from v6: > * Elaborated the commit message with more information. > * Link to v6: https://lore.kernel.org/lkml/20241223135700.22660-1-quic_janathot@quicinc.com/ These are entirely different patchsets - bindings only. Why is this v8? Best regards, Krzysztof
On 1/27/2025 12:24 PM, Krzysztof Kozlowski wrote: > On 27/01/2025 07:49, Janaki Ramaiah Thota wrote: >> Resending the below reviewed patches after fixing the regulator warnings in v7 P1. >> - Patch 1/2 Add and enable BT node for qcs6490-rb3gen board. >> - Patch 2/2 Use the power sequencer for wcn6750. >> >> ---- >> Changes from v7: >> * updated P1 & P2 with tag: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> * Link to v7: https://lore.kernel.org/lkml/20250107134157.211702-1-quic_janathot@quicinc.com/#t >> >> Changes from v6: >> * Elaborated the commit message with more information. >> * Link to v6: https://lore.kernel.org/lkml/20241223135700.22660-1-quic_janathot@quicinc.com/ > These are entirely different patchsets - bindings only. > Thanks for the quick review Krzysztof, Initially we are getting below regulator warnings in patch version 5(v5) and we fixed those by patch 1 verion 7(v7-p1) arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'enable-gpios' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'swctrl-gpios' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'vddio-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'vddbtcxmx-supply' is a required property from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: bluetooth: 'vddasd-supply' is a required property Explained complete history here : https://lore.kernel.org/lkml/d3bd97d8-43fb-452b-adca-ad03eb628031@quicinc.com/ > Why is this v8? > To maintain complete history updated to v8 Thanks, Janakiram
On Mon, 27 Jan 2025 12:19:38 +0530, Janaki Ramaiah Thota wrote: > Resending the below reviewed patches after fixing the regulator warnings in v7 P1. > - Patch 1/2 Add and enable BT node for qcs6490-rb3gen board. > - Patch 2/2 Use the power sequencer for wcn6750. > > ---- > Changes from v7: > * updated P1 & P2 with tag: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > * Link to v7: https://lore.kernel.org/lkml/20250107134157.211702-1-quic_janathot@quicinc.com/#t > > Changes from v6: > * Elaborated the commit message with more information. > * Link to v6: https://lore.kernel.org/lkml/20241223135700.22660-1-quic_janathot@quicinc.com/ > > Changes from v5: > * Update the wcn6750 required properties in bindings. > * Link to v5: https://lore.kernel.org/linux-arm-msm/20241209103455.9675-1-quic_janathot@quicinc.com/ > > Changes from v4: > * Added reviewed tag by Krzysztof in p1 > * Updated the p2 commit message with sw_ctrl and wifi-enable are > handled in wifi FW. > * Added blank line between the nodes in p2 > * Placed the structures in proper order in p4 > * Link to v4: https://lore.kernel.org/all/20241204131706.20791-1-quic_janathot@quicinc.com/ > > Changes from v3: > * Defined the PMU node and used the its output to power up BT > * Used power sequencer for wcn wcn6750 module > * Split the patch to multiple as per subtree > * Add description of the PMU of the WCN6750 module > * Include separate UART state node for sleep pin configuarion > * Link to v3: https://lore.kernel.org/linux-arm-msm/20241022104600.3228-1-quic_janathot@quicinc.com/ > > Changes from v2: > * Sorted nodes alphabetically > * Link to v2: https://lore.kernel.org/linux-arm-msm/20241010105107.30118-1-quic_janathot@quicinc.com/ > > Changes from v1: > * Corrected the board name in subject > * Link to v1: https://lore.kernel.org/linux-arm-msm/20241009111436.23473-1-quic_janathot@quicinc.com/ > Janaki Ramaiah Thota (2): > arm64: dts: qcom: qcs6490-rb3gen: add and enable BT node > Bluetooth: hci_qca: use the power sequencer for wcn6750 > > arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 168 ++++++++++++++++++- > drivers/bluetooth/hci_qca.c | 2 +- > 2 files changed, 168 insertions(+), 2 deletions(-) > > -- > > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250127064940.1360404-1-quic_janathot@quicinc.com: arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pmic@2: pwm:nvmem: [[352, 353]] is too short from schema $id: http://devicetree.org/schemas/mfd/qcom,spmi-pmic.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pwm: nvmem: [[352, 353]] is too short from schema $id: http://devicetree.org/schemas/leds/leds-qcom-lpg.yaml# arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dtb: pinctrl@f100000: Unevaluated properties are not allowed ('qup_uart7_sleep' was unexpected) from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sc7280-pinctrl.yaml#