| Message ID | 20250126144155.430263-3-andrey.lalaev@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add driver for HTU31 | expand |
On Sun, Jan 26, 2025 at 03:40:56PM +0100, Andrei Lalaev wrote: > Add trivial binding for HTU31 Temperature and Humidity sensor. > > Signed-off-by: Andrei Lalaev <andrey.lalaev@gmail.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > Please version your patchsets correctly. `git format-patch -v2` or b4. This is not v1 and you could not get my ack on v1. Best regards, Krzysztof
On 27.01.2025 08:07, Krzysztof Kozlowski wrote: > On Sun, Jan 26, 2025 at 03:40:56PM +0100, Andrei Lalaev wrote: >> Add trivial binding for HTU31 Temperature and Humidity sensor. >> >> Signed-off-by: Andrei Lalaev <andrey.lalaev@gmail.com> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> --- >> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> > > Please version your patchsets correctly. `git format-patch -v2` or b4. > > This is not v1 and you could not get my ack on v1. > Oh, my bad, sorry, I manually edited the cover letter and forgot about patches' subjects :/ Should I resend v2 with normal versioning, or would you prefer me to go straight to v3? Best regards, Andrei Lalaev
On 27/01/2025 20:21, Andrei Lalaev wrote: > On 27.01.2025 08:07, Krzysztof Kozlowski wrote: >> On Sun, Jan 26, 2025 at 03:40:56PM +0100, Andrei Lalaev wrote: >>> Add trivial binding for HTU31 Temperature and Humidity sensor. >>> >>> Signed-off-by: Andrei Lalaev <andrey.lalaev@gmail.com> >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >> >> Please version your patchsets correctly. `git format-patch -v2` or b4. >> >> This is not v1 and you could not get my ack on v1. >> > > Oh, my bad, sorry, I manually edited the cover letter and forgot about patches' subjects :/ > > Should I resend v2 with normal versioning, or would you prefer me to go straight to v3? Tools might work fine with it, so no need to resend, unless Guenter asks. But if you send v3 for any reason, be sure to mark all of the patches. Best regards, Krzysztof
On 1/27/25 11:39, Krzysztof Kozlowski wrote: > On 27/01/2025 20:21, Andrei Lalaev wrote: >> On 27.01.2025 08:07, Krzysztof Kozlowski wrote: >>> On Sun, Jan 26, 2025 at 03:40:56PM +0100, Andrei Lalaev wrote: >>>> Add trivial binding for HTU31 Temperature and Humidity sensor. >>>> >>>> Signed-off-by: Andrei Lalaev <andrey.lalaev@gmail.com> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> --- >>>> Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ >>>> 1 file changed, 2 insertions(+) >>>> >>> >>> Please version your patchsets correctly. `git format-patch -v2` or b4. >>> >>> This is not v1 and you could not get my ack on v1. >>> >> >> Oh, my bad, sorry, I manually edited the cover letter and forgot about patches' subjects :/ >> >> Should I resend v2 with normal versioning, or would you prefer me to go straight to v3? > > Tools might work fine with it, so no need to resend, unless Guenter > asks. But if you send v3 for any reason, be sure to mark all of the patches. > Please no resend just to add version numbers to the patches. Guenter
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 6bdcd055e763..294e8f9bfb4a 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -189,6 +189,8 @@ properties: - mcube,mc3230 # Measurement Specialities I2C temperature and humidity sensor - meas,htu21 + # Measurement Specialities I2C temperature and humidity sensor + - meas,htu31 # Measurement Specialities I2C pressure and temperature sensor - meas,ms5637 # Measurement Specialities I2C pressure and temperature sensor