Bluetooth: Unnecessary braces around single line statment.

Commit Message

Jeremy Dean Jan. 25, 2025, 4:58 p.m. UTC

From: Jeremy Clifton <[e-mail]>

Warning found with checkpatch.pl script. Removed unnecessary braces.

Signed-off-by: Jeremy Clifton <[e-mail]>
---
 drivers/bluetooth/bfusb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

[e-mail] Jan. 25, 2025, 6:33 p.m. UTC | #1

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=928341

---Test result---

Test Summary:
CheckPatch                    PENDING   0.38 seconds
GitLint                       PENDING   0.29 seconds
SubjectPrefix                 PASS      0.08 seconds
BuildKernel                   PASS      24.18 seconds
CheckAllWarning               PASS      27.35 seconds
CheckSparse                   PASS      29.96 seconds
BuildKernel32                 PASS      23.86 seconds
TestRunnerSetup               PASS      428.25 seconds
TestRunner_l2cap-tester       PASS      24.14 seconds
TestRunner_iso-tester         PASS      29.51 seconds
TestRunner_bnep-tester        PASS      4.79 seconds
TestRunner_mgmt-tester        PASS      119.15 seconds
TestRunner_rfcomm-tester      PASS      7.47 seconds
TestRunner_sco-tester         PASS      9.27 seconds
TestRunner_ioctl-tester       PASS      7.89 seconds
TestRunner_mesh-tester        PASS      5.93 seconds
TestRunner_smp-tester         PASS      6.85 seconds
TestRunner_userchan-tester    PASS      4.94 seconds
IncrementalBuild              PENDING   1.12 seconds

Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:

##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:

##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series
Output:



---
Regards,
Linux Bluetooth

Paul Menzel Jan. 26, 2025, 8:02 a.m. UTC | #2

Dear Jeremy,


Thank you for your patch. Could you please make the summary/title a 
statement, and remove the dot/period at the end:

Bluetooth: Remove unnecessary braces around single line statement

Am 25.01.25 um 17:58 schrieb [e-mail]:
> From: Jeremy Clifton <[e-mail]>
> 
> Warning found with checkpatch.pl script. Removed unnecessary braces.

I’d use imperative mood for the second sentence:

Remove unnecessary braces.

Also please add a Fixes: tag.

> Signed-off-by: Jeremy Clifton <[e-mail]>
> ---
>   drivers/bluetooth/bfusb.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
> index cab93935cc7f..0d6ad50da046 100644
> --- a/drivers/bluetooth/bfusb.c
> +++ b/drivers/bluetooth/bfusb.c
> @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb)
>   			buf   += 3;
>   		}
>   
> -		if (count < len) {
> +		if (count < len)
>   			bt_dev_err(data->hdev, "block extends over URB buffer ranges");
> -		}
>   
>   		if ((hdr & 0xe1) == 0xc1)
>   			bfusb_recv_block(data, hdr, buf, len);

Reviewed-by: Paul Menzel <[e-mail]>


Kind regards,

Paul

Jeremy Dean Jan. 26, 2025, 7:27 p.m. UTC | #3

Dear Paul,

I have changed the subject. 

Fixes: Coding style, unnecessary braces

On Sun, Jan 26, 2025 at 09:02:04AM +0100, Paul Menzel wrote:
> Dear Jeremy,
> 
> 
> Thank you for your patch. Could you please make the summary/title a
> statement, and remove the dot/period at the end:
> 
> Bluetooth: Remove unnecessary braces around single line statement
> 
> Am 25.01.25 um 17:58 schrieb [e-mail]:
> > From: Jeremy Clifton <[e-mail]>
> > 
> > Warning found with checkpatch.pl script. Removed unnecessary braces.
> 
> I’d use imperative mood for the second sentence:
> 
> Remove unnecessary braces.
> 
> Also please add a Fixes: tag.
> 
> > Signed-off-by: Jeremy Clifton <[e-mail]>
> > ---
> >   drivers/bluetooth/bfusb.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
> > index cab93935cc7f..0d6ad50da046 100644
> > --- a/drivers/bluetooth/bfusb.c
> > +++ b/drivers/bluetooth/bfusb.c
> > @@ -365,9 +365,8 @@ static void bfusb_rx_complete(struct urb *urb)
> >   			buf   += 3;
> >   		}
> > -		if (count < len) {
> > +		if (count < len)
> >   			bt_dev_err(data->hdev, "block extends over URB buffer ranges");
> > -		}
> >   		if ((hdr & 0xe1) == 0xc1)
> >   			bfusb_recv_block(data, hdr, buf, len);
> 
> Reviewed-by: Paul Menzel <[e-mail]>
> 
> 
> Kind regards,
> 
> Paul

Markus Elfring Jan. 27, 2025, 4:17 p.m. UTC | #4

> I have changed the subject.
>
> Fixes: Coding style, unnecessary braces

See also once more:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145

Is such a tag really relevant for a coding style adjustment?


https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22

Regards,
Markus

Jeremy Dean Jan. 27, 2025, 9:30 p.m. UTC | #5

On Mon, Jan 27, 2025 at 05:17:20PM +0100, Markus Elfring wrote:
> See also once more:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145

I read it.

> Is such a tag really relevant for a coding style adjustment?
Is it? I think it would work. So before I submit my patch I'll need to add
a Fixes: line. I have already edited my commit message. How can I find
the SHA-1code of my commit from 1-25

Luiz Augusto von Dentz Jan. 27, 2025, 9:38 p.m. UTC | #6

Hi Jeremy,

On Mon, Jan 27, 2025 at 4:30 PM Jeremy Dean <[e-mail]> wrote:
>
> On Mon, Jan 27, 2025 at 05:17:20PM +0100, Markus Elfring wrote:
> > See also once more:
> > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.13#n145
>
> I read it.
>
> > Is such a tag really relevant for a coding style adjustment?
> Is it? I think it would work. So before I submit my patch I'll need to add
> a Fixes: line. I have already edited my commit message. How can I find
> the SHA-1code of my commit from 1-25

I normally don't require Fixes tag for coding style adjustments
submitted to bluetooth-next, these are not typically backported since
there is no change on the logic or final binary.

Jeremy Dean Jan. 27, 2025, 9:52 p.m. UTC | #7

On Mon, Jan 27, 2025 at 04:38:22PM -0500, Luiz Augusto von Dentz wrote:
Luiz,

> I normally don't require Fixes tag for coding style adjustments
> submitted to bluetooth-next, these are not typically backported since
> there is no change on the logic or final binary.

And so the only thing you need is the subject/title rewritten?

Regards, Jeremy

Luiz Augusto von Dentz Jan. 27, 2025, 10:02 p.m. UTC | #8

Hi Jeremy,

On Mon, Jan 27, 2025 at 4:52 PM Jeremy Dean <[e-mail]> wrote:
>
> On Mon, Jan 27, 2025 at 04:38:22PM -0500, Luiz Augusto von Dentz wrote:
> Luiz,
>
> > I normally don't require Fixes tag for coding style adjustments
> > submitted to bluetooth-next, these are not typically backported since
> > there is no change on the logic or final binary.
>
> And so the only thing you need is the subject/title rewritten?

Are referring to:

https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]/?

Id just include the output of checkpatch and perhaps reword it to
something like:

Bluetooth: Fix code style warning

Subject should be short so it fits on 80 columns, the description can
have output of things like checkpatch, compiler warnings, etc, but
otherwise also limit to 80 columns or rather 72 since git log does add
its own indentation.


> Regards, Jeremy

Jeremy Dean Jan. 28, 2025, 6:09 a.m. UTC | #9

On Mon, Jan 27, 2025 at 05:02:22PM -0500, Luiz Augusto von Dentz wrote:
Luiz,
> Are referring to:
> 
> https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]/?
> 
> Id just include the output of checkpatch and perhaps reword it to
> something like:
> 
> Bluetooth: Fix code style warning
I could not find a way to change the subject/title to remove the typo
in my first patch submision. For this reason I created a new patch
it can be found at the following link:

https://patchwork.kernel.org/project/bluetooth/patch/[e-mail]/

This submission is perferred because it removes the typo. 

The question remains: How do I close this patch submission?


Jeremy D C

[e-mail] Jan. 29, 2025, 8:20 p.m. UTC | #10

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Sat, 25 Jan 2025 17:58:02 +0100 you wrote:
> From: Jeremy Clifton <[e-mail]>
> 
> Warning found with checkpatch.pl script. Removed unnecessary braces.
> 
> Signed-off-by: Jeremy Clifton <[e-mail]>
> ---
>  drivers/bluetooth/bfusb.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Here is the summary with links:
  - Bluetooth: Unnecessary braces around single line statment.
    https://git.kernel.org/bluetooth/bluetooth-next/c/a2a245849af8

You are awesome, thank you!

Patch

diff --git a/drivers/bluetooth/bfusb.c b/drivers/bluetooth/bfusb.c
index cab93935cc7f..0d6ad50da046 100644
--- a/drivers/bluetooth/bfusb.c
+++ b/drivers/bluetooth/bfusb.c
@@ -365,9 +365,8 @@  static void bfusb_rx_complete(struct urb *urb)
 			buf   += 3;
 		}
 
-		if (count < len) {
+		if (count < len)
 			bt_dev_err(data->hdev, "block extends over URB buffer ranges");
-		}
 
 		if ((hdr & 0xe1) == 0xc1)
 			bfusb_recv_block(data, hdr, buf, len);