diff mbox series

[v6,1/3] dt-bindings: iio: adf4371: add refin mode

Message ID 20250127101026.5320-2-antoniu.miclaus@analog.com (mailing list archive)
State New
Headers show
Series ADF4371 refin mode and doubler support | expand

Commit Message

Miclaus, Antoniu Jan. 27, 2025, 10:10 a.m. UTC
Add support for selecting between single-ended and differential
reference input.

Input frequency boundaries are change based on the mode selected
(single-ended/differential).

Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
---
no changes in v6.
 Documentation/devicetree/bindings/iio/frequency/adf4371.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Conor Dooley Jan. 27, 2025, 5:53 p.m. UTC | #1
On Mon, Jan 27, 2025 at 12:10:21PM +0200, Antoniu Miclaus wrote:
> Add support for selecting between single-ended and differential
> reference input.
> 
> Input frequency boundaries are change based on the mode selected
> (single-ended/differential).
> 
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> ---
> no changes in v6.

Why'd you not pick up my ack?
https://lore.kernel.org/all/20250121-crumb-dispense-b455b591481a@spud/
:
>  Documentation/devicetree/bindings/iio/frequency/adf4371.yaml | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> index 1cb2adaf66f9..53d607441612 100644
> --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> @@ -30,8 +30,9 @@ properties:
>  
>    clock-names:
>      description:
> -      Must be "clkin"
> -    maxItems: 1
> +      Must be "clkin" if the input reference is single ended or "clkin-diff"
> +      if the input reference is differential.
> +    enum: [clkin, clkin-diff]
>  
>    adi,mute-till-lock-en:
>      type: boolean
> -- 
> 2.48.1
>
Miclaus, Antoniu Jan. 28, 2025, 10:24 a.m. UTC | #2
> On Mon, Jan 27, 2025 at 12:10:21PM +0200, Antoniu Miclaus wrote:
> > Add support for selecting between single-ended and differential
> > reference input.
> >
> > Input frequency boundaries are change based on the mode selected
> > (single-ended/differential).
> >
> > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > ---
> > no changes in v6.
> 
> Why'd you not pick up my ack?
> https://lore.kernel.org/all/20250121-crumb-dispense-
> b455b591481a@spud/
I'm sorry, I missed it. Should I send a new version with it?
> >  Documentation/devicetree/bindings/iio/frequency/adf4371.yaml | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > index 1cb2adaf66f9..53d607441612 100644
> > --- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > +++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
> > @@ -30,8 +30,9 @@ properties:
> >
> >    clock-names:
> >      description:
> > -      Must be "clkin"
> > -    maxItems: 1
> > +      Must be "clkin" if the input reference is single ended or "clkin-diff"
> > +      if the input reference is differential.
> > +    enum: [clkin, clkin-diff]
> >
> >    adi,mute-till-lock-en:
> >      type: boolean
> > --
> > 2.48.1
> >
Conor Dooley Jan. 28, 2025, 5:08 p.m. UTC | #3
On Tue, Jan 28, 2025 at 10:24:37AM +0000, Miclaus, Antoniu wrote:
> > On Mon, Jan 27, 2025 at 12:10:21PM +0200, Antoniu Miclaus wrote:
> > > Add support for selecting between single-ended and differential
> > > reference input.
> > >
> > > Input frequency boundaries are change based on the mode selected
> > > (single-ended/differential).
> > >
> > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
> > > ---
> > > no changes in v6.
> > 
> > Why'd you not pick up my ack?
> > https://lore.kernel.org/all/20250121-crumb-dispense-
> > b455b591481a@spud/
> I'm sorry, I missed it. Should I send a new version with it?

No.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
index 1cb2adaf66f9..53d607441612 100644
--- a/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
+++ b/Documentation/devicetree/bindings/iio/frequency/adf4371.yaml
@@ -30,8 +30,9 @@  properties:
 
   clock-names:
     description:
-      Must be "clkin"
-    maxItems: 1
+      Must be "clkin" if the input reference is single ended or "clkin-diff"
+      if the input reference is differential.
+    enum: [clkin, clkin-diff]
 
   adi,mute-till-lock-en:
     type: boolean