| Message ID | 20250201100833.34642-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: platform: exynos4-is: Use of_get_available_child_by_name() | expand |
On 01/02/2025 11:08, Biju Das wrote: > Simplify fimc_md_is_isp_available() by using > of_get_available_child_by_name(). > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > This patch is only compile tested and depend upon[1] > [1] https://lore.kernel.org/all/20250201093126.7322-1-biju.das.jz@bp.renesas.com/ > --- Dependency won't be in 6.14-rc1, so you will need to send it for cycle after that. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi Krzysztof Kozlowski, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 01 February 2025 11:59 > Subject: Re: [PATCH] media: platform: exynos4-is: Use of_get_available_child_by_name() > > On 01/02/2025 11:08, Biju Das wrote: > > Simplify fimc_md_is_isp_available() by using > > of_get_available_child_by_name(). > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > This patch is only compile tested and depend upon[1] [1] > > https://lore.kernel.org/all/20250201093126.7322-1-biju.das.jz@bp.renes > > as.com/ > > --- > > Dependency won't be in 6.14-rc1, so you will need to send it for cycle after that. OK. Will do. Cheers, Biju
diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.h b/drivers/media/platform/samsung/exynos4-is/media-dev.h index a50e58ab7ef7..ce89465c22de 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.h +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.h @@ -179,8 +179,8 @@ int fimc_md_set_camclk(struct v4l2_subdev *sd, bool on); static inline bool fimc_md_is_isp_available(struct device_node *node) { struct device_node *child __free(device_node) = - of_get_child_by_name(node, FIMC_IS_OF_NODE_NAME); - return child ? of_device_is_available(child) : false; + of_get_available_child_by_name(node, FIMC_IS_OF_NODE_NAME); + return child != NULL; } #else #define fimc_md_is_isp_available(node) (false)
Simplify fimc_md_is_isp_available() by using of_get_available_child_by_name(). Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- This patch is only compile tested and depend upon[1] [1] https://lore.kernel.org/all/20250201093126.7322-1-biju.das.jz@bp.renesas.com/ --- drivers/media/platform/samsung/exynos4-is/media-dev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)