| Message ID | 20250202-arm-brbe-v19-v19-1-1c1300802385@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64/perf: Enable branch stack sampling | expand |
On 2/3/25 06:12, Rob Herring (Arm) wrote: > Counting events related to setup of the PMU is not desired, but > kvm_vcpu_pmu_resync_el0() is called just after the PMU counters have > been enabled. Move the call to before enabling the counters. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > drivers/perf/arm_pmuv3.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c > index 0e360feb3432..9ebc950559c0 100644 > --- a/drivers/perf/arm_pmuv3.c > +++ b/drivers/perf/arm_pmuv3.c > @@ -825,10 +825,10 @@ static void armv8pmu_start(struct arm_pmu *cpu_pmu) > else > armv8pmu_disable_user_access(); > > + kvm_vcpu_pmu_resync_el0(); > + > /* Enable all counters */ > armv8pmu_pmcr_write(armv8pmu_pmcr_read() | ARMV8_PMU_PMCR_E); > - > - kvm_vcpu_pmu_resync_el0(); > } > > static void armv8pmu_stop(struct arm_pmu *cpu_pmu) > Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c index 0e360feb3432..9ebc950559c0 100644 --- a/drivers/perf/arm_pmuv3.c +++ b/drivers/perf/arm_pmuv3.c @@ -825,10 +825,10 @@ static void armv8pmu_start(struct arm_pmu *cpu_pmu) else armv8pmu_disable_user_access(); + kvm_vcpu_pmu_resync_el0(); + /* Enable all counters */ armv8pmu_pmcr_write(armv8pmu_pmcr_read() | ARMV8_PMU_PMCR_E); - - kvm_vcpu_pmu_resync_el0(); } static void armv8pmu_stop(struct arm_pmu *cpu_pmu)
Counting events related to setup of the PMU is not desired, but kvm_vcpu_pmu_resync_el0() is called just after the PMU counters have been enabled. Move the call to before enabling the counters. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/perf/arm_pmuv3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)