| Message ID | 20250202-arm-brbe-v19-v19-4-1c1300802385@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64/perf: Enable branch stack sampling | expand |
On 2/3/25 06:12, Rob Herring (Arm) wrote: > The function calls for enabling/disabling counters and interrupts are > pretty obvious as to what they are doing, and the comments don't add > any additional value. > > Signed-off-by: Rob Herring (Arm) <robh@kernel.org> > --- > drivers/perf/arm_v7_pmu.c | 44 -------------------------------------------- > 1 file changed, 44 deletions(-) > > diff --git a/drivers/perf/arm_v7_pmu.c b/drivers/perf/arm_v7_pmu.c > index 420cadd108e7..7fa88e3b64e0 100644 > --- a/drivers/perf/arm_v7_pmu.c > +++ b/drivers/perf/arm_v7_pmu.c > @@ -857,14 +857,6 @@ static void armv7pmu_enable_event(struct perf_event *event) > return; > } > > - /* > - * Enable counter and interrupt, and set the counter to count > - * the event that we're interested in. > - */ > - > - /* > - * Disable counter > - */ > armv7_pmnc_disable_counter(idx); > > /* > @@ -875,14 +867,7 @@ static void armv7pmu_enable_event(struct perf_event *event) > if (cpu_pmu->set_event_filter || idx != ARMV7_IDX_CYCLE_COUNTER) > armv7_pmnc_write_evtsel(idx, hwc->config_base); > > - /* > - * Enable interrupt for this counter > - */ > armv7_pmnc_enable_intens(idx); > - > - /* > - * Enable counter > - */ > armv7_pmnc_enable_counter(idx); > } > > @@ -898,18 +883,7 @@ static void armv7pmu_disable_event(struct perf_event *event) > return; > } > > - /* > - * Disable counter and interrupt > - */ > - > - /* > - * Disable counter > - */ > armv7_pmnc_disable_counter(idx); > - > - /* > - * Disable interrupt for this counter > - */ > armv7_pmnc_disable_intens(idx); > } > > @@ -1476,12 +1450,6 @@ static void krait_pmu_enable_event(struct perf_event *event) > struct hw_perf_event *hwc = &event->hw; > int idx = hwc->idx; > > - /* > - * Enable counter and interrupt, and set the counter to count > - * the event that we're interested in. > - */ > - > - /* Disable counter */ > armv7_pmnc_disable_counter(idx); > > /* > @@ -1494,10 +1462,7 @@ static void krait_pmu_enable_event(struct perf_event *event) > else > armv7_pmnc_write_evtsel(idx, hwc->config_base); > > - /* Enable interrupt for this counter */ > armv7_pmnc_enable_intens(idx); > - > - /* Enable counter */ > armv7_pmnc_enable_counter(idx); > } > > @@ -1797,12 +1762,6 @@ static void scorpion_pmu_enable_event(struct perf_event *event) > struct hw_perf_event *hwc = &event->hw; > int idx = hwc->idx; > > - /* > - * Enable counter and interrupt, and set the counter to count > - * the event that we're interested in. > - */ > - > - /* Disable counter */ > armv7_pmnc_disable_counter(idx); > > /* > @@ -1815,10 +1774,7 @@ static void scorpion_pmu_enable_event(struct perf_event *event) > else if (idx != ARMV7_IDX_CYCLE_COUNTER) > armv7_pmnc_write_evtsel(idx, hwc->config_base); > > - /* Enable interrupt for this counter */ > armv7_pmnc_enable_intens(idx); > - > - /* Enable counter */ > armv7_pmnc_enable_counter(idx); > } > > Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
diff --git a/drivers/perf/arm_v7_pmu.c b/drivers/perf/arm_v7_pmu.c index 420cadd108e7..7fa88e3b64e0 100644 --- a/drivers/perf/arm_v7_pmu.c +++ b/drivers/perf/arm_v7_pmu.c @@ -857,14 +857,6 @@ static void armv7pmu_enable_event(struct perf_event *event) return; } - /* - * Enable counter and interrupt, and set the counter to count - * the event that we're interested in. - */ - - /* - * Disable counter - */ armv7_pmnc_disable_counter(idx); /* @@ -875,14 +867,7 @@ static void armv7pmu_enable_event(struct perf_event *event) if (cpu_pmu->set_event_filter || idx != ARMV7_IDX_CYCLE_COUNTER) armv7_pmnc_write_evtsel(idx, hwc->config_base); - /* - * Enable interrupt for this counter - */ armv7_pmnc_enable_intens(idx); - - /* - * Enable counter - */ armv7_pmnc_enable_counter(idx); } @@ -898,18 +883,7 @@ static void armv7pmu_disable_event(struct perf_event *event) return; } - /* - * Disable counter and interrupt - */ - - /* - * Disable counter - */ armv7_pmnc_disable_counter(idx); - - /* - * Disable interrupt for this counter - */ armv7_pmnc_disable_intens(idx); } @@ -1476,12 +1450,6 @@ static void krait_pmu_enable_event(struct perf_event *event) struct hw_perf_event *hwc = &event->hw; int idx = hwc->idx; - /* - * Enable counter and interrupt, and set the counter to count - * the event that we're interested in. - */ - - /* Disable counter */ armv7_pmnc_disable_counter(idx); /* @@ -1494,10 +1462,7 @@ static void krait_pmu_enable_event(struct perf_event *event) else armv7_pmnc_write_evtsel(idx, hwc->config_base); - /* Enable interrupt for this counter */ armv7_pmnc_enable_intens(idx); - - /* Enable counter */ armv7_pmnc_enable_counter(idx); } @@ -1797,12 +1762,6 @@ static void scorpion_pmu_enable_event(struct perf_event *event) struct hw_perf_event *hwc = &event->hw; int idx = hwc->idx; - /* - * Enable counter and interrupt, and set the counter to count - * the event that we're interested in. - */ - - /* Disable counter */ armv7_pmnc_disable_counter(idx); /* @@ -1815,10 +1774,7 @@ static void scorpion_pmu_enable_event(struct perf_event *event) else if (idx != ARMV7_IDX_CYCLE_COUNTER) armv7_pmnc_write_evtsel(idx, hwc->config_base); - /* Enable interrupt for this counter */ armv7_pmnc_enable_intens(idx); - - /* Enable counter */ armv7_pmnc_enable_counter(idx); }
The function calls for enabling/disabling counters and interrupts are pretty obvious as to what they are doing, and the comments don't add any additional value. Signed-off-by: Rob Herring (Arm) <robh@kernel.org> --- drivers/perf/arm_v7_pmu.c | 44 -------------------------------------------- 1 file changed, 44 deletions(-)