| Message ID | 20250201193044.28856-2-funderscore@postmarketos.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for Xiaomi Mi TV Stick | expand |
On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote: > From: Ferass El Hafidi <funderscore@postmarketos.org> > > Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka. > xiaomi-aquaman). The S805Y is very similar to the S805X, with just a > few minor differences. > > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org> Please run checkpatch. You have from/SoB mismatch. > --- > Documentation/devicetree/bindings/arm/amlogic.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) Best regards, Krzysztof
Hi, On Sun Feb 2, 2025 at 1:54 PM UTC, Krzysztof Kozlowski wrote: > On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote: > > From: Ferass El Hafidi <funderscore@postmarketos.org> > > > > Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka. > > xiaomi-aquaman). The S805Y is very similar to the S805X, with just a > > few minor differences. > > > > Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org> > > Please run checkpatch. You have from/SoB mismatch. I don't see any mismatch. Maybe it complains because of a spurious non-breaking space? Regards.
On 02/02/2025 14:55, Ferass El Hafidi wrote: > Hi, > > On Sun Feb 2, 2025 at 1:54 PM UTC, Krzysztof Kozlowski wrote: >> On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote: >>> From: Ferass El Hafidi <funderscore@postmarketos.org> >>> >>> Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka. >>> xiaomi-aquaman). The S805Y is very similar to the S805X, with just a >>> few minor differences. >>> >>> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org> >> >> Please run checkpatch. You have from/SoB mismatch. > > I don't see any mismatch. Maybe it complains because of a spurious > non-breaking space? > Could be, no clue. I copied them to editor and it also sees mismatch - both entries just do not match. Best regards, Krzysztof
On Sun Feb 2, 2025 at 2:07 PM UTC, Krzysztof Kozlowski wrote: > On 02/02/2025 14:55, Ferass El Hafidi wrote: > > Hi, > > > > On Sun Feb 2, 2025 at 1:54 PM UTC, Krzysztof Kozlowski wrote: > >> On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote: > >>> From: Ferass El Hafidi <funderscore@postmarketos.org> > >>> > >>> Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka. > >>> xiaomi-aquaman). The S805Y is very similar to the S805X, with just a > >>> few minor differences. > >>> > >>> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org> > >> > >> Please run checkpatch. You have from/SoB mismatch. > > > > I don't see any mismatch. Maybe it complains because of a spurious > > non-breaking space? > > > Could be, no clue. I copied them to editor and it also sees mismatch - > both entries just do not match. OK, I'll see what I can do. > > Best regards, > Krzysztof Cheers.
Hi Krzysztof, On Sun Feb 2, 2025 at 2:07 PM UTC, Krzysztof Kozlowski wrote: > On 02/02/2025 14:55, Ferass El Hafidi wrote: > > Hi, > > > > On Sun Feb 2, 2025 at 1:54 PM UTC, Krzysztof Kozlowski wrote: > >> On Sat, Feb 01, 2025 at 07:30:43PM +0000, Ferass El Hafidi wrote: > >>> From: Ferass El Hafidi <funderscore@postmarketos.org> > >>> > >>> Add support for the Amlogic S805Y SoC and the Xiaomi Mi TV Stick (aka. > >>> xiaomi-aquaman). The S805Y is very similar to the S805X, with just a > >>> few minor differences. > >>> > >>> Signed-off-by: Ferass El Hafidi <funderscore@postmarketos.org> > >> > >> Please run checkpatch. You have from/SoB mismatch. > > > > I don't see any mismatch. Maybe it complains because of a spurious > > non-breaking space? > > > Could be, no clue. I copied them to editor and it also sees mismatch - > both entries just do not match. The From/SoB mismatch should be fixed in the v3: https://lore.kernel.org/linux-amlogic/20250203091453.15751-1-funderscore@postmarketos.org/T/#u Thanks. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml index 0647851ae..3403362e0 100644 --- a/Documentation/devicetree/bindings/arm/amlogic.yaml +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml @@ -73,6 +73,13 @@ properties: - const: amlogic,s805x - const: amlogic,meson-gxl + - description: Boards with the Amlogic Meson GXL S805Y SoC + items: + - enum: + - xiaomi,aquaman + - const: amlogic,s805y + - const: amlogic,meson-gxl + - description: Boards with the Amlogic Meson GXL S905W SoC items: - enum: