mbox series

[bpf-next,v1,0/2] selftests: fix two small compilation errors

Message ID 20250204023946.16031-1-kerneljasonxing@gmail.com (mailing list archive)
Headers show
Series selftests: fix two small compilation errors | expand

Message

Jason Xing Feb. 4, 2025, 2:39 a.m. UTC 
Fix them separately in each patch.

Jason Xing (2):
  bpf: changes_pkt_data: correct the 'main' error
  bpf: sockopt_sk: fix 'undeclared' definition error

 .../selftests/bpf/prog_tests/changes_pkt_data.c      | 12 ++++++------
 tools/testing/selftests/bpf/prog_tests/sockopt_sk.c  |  2 +-
 2 files changed, 7 insertions(+), 7 deletions(-)

Comments

Daniel Xu Feb. 6, 2025, 10:21 a.m. UTC | #1 
Hi Jason,

cc bpf@vger

On 2/5/25 11:56 PM, Jason Xing wrote:
> On Thu, Feb 6, 2025 at 5:28 AM <bot+bpf-ci@kernel.org> wrote:
>> Dear patch submitter,
>>
>> CI has tested the following submission:
>> Status:     FAILURE
>> Name:       [bpf-next,v1,0/2] selftests: fix two small compilation errors
>> Patchwork:  https://patchwork.kernel.org/project/netdevbpf/list/?series=930276&state=*
>> Matrix:     https://github.com/kernel-patches/bpf/actions/runs/13165816880
>>
>> Failed jobs:
>> test_progs-aarch64-gcc: https://github.com/kernel-patches/bpf/actions/runs/13165816880/job/36746357575
> I'm afraid this has nothing to do with the series?
> Traceback (most recent call last):
> 5288 File "/tmp/work/_actions/libbpf/ci/v3/run-vmtest/print_test_summary.py",
> line 85, in <module>
> 5289 json_summary = json.load(f)
> 5290 ^^^^^^^^^^^^
> 5291 File "/usr/lib/python3.12/json/__init__.py", line 293, in load
> 5292 return loads(fp.read(),
> 5293 ^^^^^^^^^^^^^^^^
> 5294 File "/usr/lib/python3.12/json/__init__.py", line 346, in loads
> 5295 return _default_decoder.decode(s)
> 5296 ^^^^^^^^^^^^^^^^^^^^^^^^^^
> 5297 File "/usr/lib/python3.12/json/decoder.py", line 337, in decode
> 5298 obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> 5299 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 5300 File "/usr/lib/python3.12/json/decoder.py", line 355, in raw_decode
> 5301 raise JSONDecodeError("Expecting value", s, err.value) from None
> 5302json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
> 5303Error: Process completed with exit code 2
>
> Am I missing something?

If you expand the "test_progs" section right above that, you'll see:

   Caught signal #11!
   Stack trace:
   ./test_progs(crash_handler+0x34)[0xaaaad4e05bfc]
   linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0xffff85106850]
   ./test_progs(+0x45874)[0xaaaad4a25874]
   ./test_progs(htab_lookup_elem+0x3c)[0xaaaad4a258e4]
   ./test_progs(+0x45b74)[0xaaaad4a25b74]
   ./test_progs(+0x4646c)[0xaaaad4a2646c]
   ./test_progs(test_arena_htab+0x48)[0xaaaad4a264f4]
   ./test_progs(+0x426258)[0xaaaad4e06258]
   ./test_progs(main+0x694)[0xaaaad4e080a0]
   /lib/aarch64-linux-gnu/libc.so.6(+0x284c4)[0xffff84eb84c4]
/lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0x98)[0xffff84eb8598]
   ./test_progs(_start+0x30)[0xaaaad4a1faf0]
   /tmp/work/_actions/libbpf/ci/v3/run-vmtest/run-bpf-selftests.sh: line 
26:   101 Segmentation fault      ./${selftest} ${args} --json-summary 
"${json_file}"

The infra couldn't parse the stack as json (rightly so).


Thanks,

Daniel
Jason Xing Feb. 6, 2025, 12:13 p.m. UTC | #2 
On Thu, Feb 6, 2025 at 6:21 PM Daniel Xu <dlxu@meta.com> wrote:
>
> Hi Jason,
>
> cc bpf@vger
>
> On 2/5/25 11:56 PM, Jason Xing wrote:
> > On Thu, Feb 6, 2025 at 5:28 AM <bot+bpf-ci@kernel.org> wrote:
> >> Dear patch submitter,
> >>
> >> CI has tested the following submission:
> >> Status:     FAILURE
> >> Name:       [bpf-next,v1,0/2] selftests: fix two small compilation errors
> >> Patchwork:  https://patchwork.kernel.org/project/netdevbpf/list/?series=930276&state=*
> >> Matrix:     https://github.com/kernel-patches/bpf/actions/runs/13165816880
> >>
> >> Failed jobs:
> >> test_progs-aarch64-gcc: https://github.com/kernel-patches/bpf/actions/runs/13165816880/job/36746357575
> > I'm afraid this has nothing to do with the series?
> > Traceback (most recent call last):
> > 5288 File "/tmp/work/_actions/libbpf/ci/v3/run-vmtest/print_test_summary.py",
> > line 85, in <module>
> > 5289 json_summary = json.load(f)
> > 5290 ^^^^^^^^^^^^
> > 5291 File "/usr/lib/python3.12/json/__init__.py", line 293, in load
> > 5292 return loads(fp.read(),
> > 5293 ^^^^^^^^^^^^^^^^
> > 5294 File "/usr/lib/python3.12/json/__init__.py", line 346, in loads
> > 5295 return _default_decoder.decode(s)
> > 5296 ^^^^^^^^^^^^^^^^^^^^^^^^^^
> > 5297 File "/usr/lib/python3.12/json/decoder.py", line 337, in decode
> > 5298 obj, end = self.raw_decode(s, idx=_w(s, 0).end())
> > 5299 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > 5300 File "/usr/lib/python3.12/json/decoder.py", line 355, in raw_decode
> > 5301 raise JSONDecodeError("Expecting value", s, err.value) from None
> > 5302json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
> > 5303Error: Process completed with exit code 2
> >
> > Am I missing something?
>
> If you expand the "test_progs" section right above that, you'll see:
>
>    Caught signal #11!
>    Stack trace:
>    ./test_progs(crash_handler+0x34)[0xaaaad4e05bfc]
>    linux-vdso.so.1(__kernel_rt_sigreturn+0x0)[0xffff85106850]
>    ./test_progs(+0x45874)[0xaaaad4a25874]
>    ./test_progs(htab_lookup_elem+0x3c)[0xaaaad4a258e4]
>    ./test_progs(+0x45b74)[0xaaaad4a25b74]
>    ./test_progs(+0x4646c)[0xaaaad4a2646c]
>    ./test_progs(test_arena_htab+0x48)[0xaaaad4a264f4]
>    ./test_progs(+0x426258)[0xaaaad4e06258]
>    ./test_progs(main+0x694)[0xaaaad4e080a0]
>    /lib/aarch64-linux-gnu/libc.so.6(+0x284c4)[0xffff84eb84c4]
> /lib/aarch64-linux-gnu/libc.so.6(__libc_start_main+0x98)[0xffff84eb8598]
>    ./test_progs(_start+0x30)[0xaaaad4a1faf0]
>    /tmp/work/_actions/libbpf/ci/v3/run-vmtest/run-bpf-selftests.sh: line
> 26:   101 Segmentation fault      ./${selftest} ${args} --json-summary
> "${json_file}"
>
> The infra couldn't parse the stack as json (rightly so).

Thanks for the reply. I'm surprised that this error is related to this
series, really? Could you point out why these two patches cause the
segfault please?

Thanks,
Jason
Jason Xing Feb. 11, 2025, 7:52 a.m. UTC | #3 
Hi Maintainers from bpf,

On Tue, Feb 4, 2025 at 10:39 AM Jason Xing <kerneljasonxing@gmail.com> wrote:
>
> Fix them separately in each patch.

I'd like to know if it's possible to merge the series because it does
harm to some old distro with only updating the kernel?

Thanks,
Jason

>
> Jason Xing (2):
>   bpf: changes_pkt_data: correct the 'main' error
>   bpf: sockopt_sk: fix 'undeclared' definition error
>
>  .../selftests/bpf/prog_tests/changes_pkt_data.c      | 12 ++++++------
>  tools/testing/selftests/bpf/prog_tests/sockopt_sk.c  |  2 +-
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> --
> 2.43.5
>