| Message ID | 20250204133209.403327-2-tzimmermann@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/ast: astdp: Improve mode handling | expand |
On 04/02/2025 14:26, Thomas Zimmermann wrote: > Add dedicated connector state for ASTDP connectors. The state will > store values for programming the transmitter chip. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> > > Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > drivers/gpu/drm/ast/ast_dp.c | 62 ++++++++++++++++++++++++++++++++---- > 1 file changed, 56 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/ast/ast_dp.c b/drivers/gpu/drm/ast/ast_dp.c > index db3eb9ce1498..9c49b507a0d2 100644 > --- a/drivers/gpu/drm/ast/ast_dp.c > +++ b/drivers/gpu/drm/ast/ast_dp.c > @@ -42,6 +42,16 @@ static const struct ast_astdp_mode_index_table_entry ast_astdp_mode_index_table[ > { 0 } > }; > > +struct ast_astdp_connector_state { > + struct drm_connector_state base; > +}; > + > +static struct ast_astdp_connector_state * > +to_ast_astdp_connector_state(const struct drm_connector_state *state) > +{ > + return container_of(state, struct ast_astdp_connector_state, base); > +} > + > static int __ast_astdp_get_mode_index(unsigned int hdisplay, unsigned int vdisplay) > { > const struct ast_astdp_mode_index_table_entry *entry = ast_astdp_mode_index_table; > @@ -442,18 +452,58 @@ static const struct drm_connector_helper_funcs ast_astdp_connector_helper_funcs > .detect_ctx = ast_astdp_connector_helper_detect_ctx, > }; > > -/* > - * Output > - */ > +static void ast_astdp_connector_reset(struct drm_connector *connector) > +{ > + struct ast_astdp_connector_state *astdp_state = > + kzalloc(sizeof(*astdp_state), GFP_KERNEL); > + > + if (connector->state) > + connector->funcs->atomic_destroy_state(connector, connector->state); > + > + if (astdp_state) > + __drm_atomic_helper_connector_reset(connector, &astdp_state->base); > + else > + __drm_atomic_helper_connector_reset(connector, NULL); > +} > + > +static struct drm_connector_state * > +ast_astdp_connector_atomic_duplicate_state(struct drm_connector *connector) > +{ > + struct ast_astdp_connector_state *new_astdp_state; > + struct drm_device *dev = connector->dev; > + > + if (drm_WARN_ON(dev, !connector->state)) > + return NULL; > + > + new_astdp_state = kmalloc(sizeof(*new_astdp_state), GFP_KERNEL); > + if (!new_astdp_state) > + return NULL; > + __drm_atomic_helper_connector_duplicate_state(connector, &new_astdp_state->base); > + > + return &new_astdp_state->base; > +} > + > +static void ast_astdp_connector_atomic_destroy_state(struct drm_connector *connector, > + struct drm_connector_state *state) > +{ > + struct ast_astdp_connector_state *astdp_state = to_ast_astdp_connector_state(state); > + > + __drm_atomic_helper_connector_destroy_state(&astdp_state->base); > + kfree(astdp_state); > +} > > static const struct drm_connector_funcs ast_astdp_connector_funcs = { > - .reset = drm_atomic_helper_connector_reset, > + .reset = ast_astdp_connector_reset, > .fill_modes = drm_helper_probe_single_connector_modes, > .destroy = drm_connector_cleanup, > - .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, > - .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, > + .atomic_duplicate_state = ast_astdp_connector_atomic_duplicate_state, > + .atomic_destroy_state = ast_astdp_connector_atomic_destroy_state, > }; > > +/* > + * Output > + */ > + > int ast_astdp_output_init(struct ast_device *ast) > { > struct drm_device *dev = &ast->base;
diff --git a/drivers/gpu/drm/ast/ast_dp.c b/drivers/gpu/drm/ast/ast_dp.c index db3eb9ce1498..9c49b507a0d2 100644 --- a/drivers/gpu/drm/ast/ast_dp.c +++ b/drivers/gpu/drm/ast/ast_dp.c @@ -42,6 +42,16 @@ static const struct ast_astdp_mode_index_table_entry ast_astdp_mode_index_table[ { 0 } }; +struct ast_astdp_connector_state { + struct drm_connector_state base; +}; + +static struct ast_astdp_connector_state * +to_ast_astdp_connector_state(const struct drm_connector_state *state) +{ + return container_of(state, struct ast_astdp_connector_state, base); +} + static int __ast_astdp_get_mode_index(unsigned int hdisplay, unsigned int vdisplay) { const struct ast_astdp_mode_index_table_entry *entry = ast_astdp_mode_index_table; @@ -442,18 +452,58 @@ static const struct drm_connector_helper_funcs ast_astdp_connector_helper_funcs .detect_ctx = ast_astdp_connector_helper_detect_ctx, }; -/* - * Output - */ +static void ast_astdp_connector_reset(struct drm_connector *connector) +{ + struct ast_astdp_connector_state *astdp_state = + kzalloc(sizeof(*astdp_state), GFP_KERNEL); + + if (connector->state) + connector->funcs->atomic_destroy_state(connector, connector->state); + + if (astdp_state) + __drm_atomic_helper_connector_reset(connector, &astdp_state->base); + else + __drm_atomic_helper_connector_reset(connector, NULL); +} + +static struct drm_connector_state * +ast_astdp_connector_atomic_duplicate_state(struct drm_connector *connector) +{ + struct ast_astdp_connector_state *new_astdp_state; + struct drm_device *dev = connector->dev; + + if (drm_WARN_ON(dev, !connector->state)) + return NULL; + + new_astdp_state = kmalloc(sizeof(*new_astdp_state), GFP_KERNEL); + if (!new_astdp_state) + return NULL; + __drm_atomic_helper_connector_duplicate_state(connector, &new_astdp_state->base); + + return &new_astdp_state->base; +} + +static void ast_astdp_connector_atomic_destroy_state(struct drm_connector *connector, + struct drm_connector_state *state) +{ + struct ast_astdp_connector_state *astdp_state = to_ast_astdp_connector_state(state); + + __drm_atomic_helper_connector_destroy_state(&astdp_state->base); + kfree(astdp_state); +} static const struct drm_connector_funcs ast_astdp_connector_funcs = { - .reset = drm_atomic_helper_connector_reset, + .reset = ast_astdp_connector_reset, .fill_modes = drm_helper_probe_single_connector_modes, .destroy = drm_connector_cleanup, - .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state, - .atomic_destroy_state = drm_atomic_helper_connector_destroy_state, + .atomic_duplicate_state = ast_astdp_connector_atomic_duplicate_state, + .atomic_destroy_state = ast_astdp_connector_atomic_destroy_state, }; +/* + * Output + */ + int ast_astdp_output_init(struct ast_device *ast) { struct drm_device *dev = &ast->base;
Add dedicated connector state for ASTDP connectors. The state will store values for programming the transmitter chip. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> --- drivers/gpu/drm/ast/ast_dp.c | 62 ++++++++++++++++++++++++++++++++---- 1 file changed, 56 insertions(+), 6 deletions(-)