| Message ID | 20250206085034.1978172-3-sumang@marvell.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add af_xdp support for cn10k | expand |
On Thu, Feb 06, 2025 at 02:20:30PM +0530, Suman Ghosh wrote: > Set xdp rx ring memory type as MEM_TYPE_PAGE_POOL for > af-xdp to work. This is needed since xdp_return_frame > internally will use page pools. > > Fixes: 06059a1a9a4a ("octeontx2-pf: Add XDP support to netdev PF") > Signed-off-by: Suman Ghosh <sumang@marvell.com> Hi Suman, If this is a bug fix then it should be targeted at net, which implies splitting it out of this patch-set. If, on the other hand, it is not a fix then it should not have a Fixes tag. In that case you can cite a commit using this syntax: commit 06059a1a9a4a ("octeontx2-pf: Add XDP support to netdev PF") Unlike a Fixes tag it: * Should be in the body of the patch description, rather than part of the tags at the bottom of the patch description * May be line wrapped * Can me included in a sentence
>Hi Suman, > >If this is a bug fix then it should be targeted at net, which implies >splitting it out of this patch-set. > >If, on the other hand, it is not a fix then it should not have a Fixes >tag. >In that case you can cite a commit using this syntax: > >commit 06059a1a9a4a ("octeontx2-pf: Add XDP support to netdev PF") > >Unlike a Fixes tag it: >* Should be in the body of the patch description, > rather than part of the tags at the bottom of the patch description >* May be line wrapped >* Can me included in a sentence [Suman] Hi Simon, This was suggested the Paolo in v3. He suggested this to simplify the merging process but to add the fix tag.
On Tue, Feb 11, 2025 at 07:07:02AM +0000, Suman Ghosh wrote: > >Hi Suman, > > > >If this is a bug fix then it should be targeted at net, which implies > >splitting it out of this patch-set. > > > >If, on the other hand, it is not a fix then it should not have a Fixes > >tag. > >In that case you can cite a commit using this syntax: > > > >commit 06059a1a9a4a ("octeontx2-pf: Add XDP support to netdev PF") > > > >Unlike a Fixes tag it: > >* Should be in the body of the patch description, > > rather than part of the tags at the bottom of the patch description > >* May be line wrapped > >* Can me included in a sentence > [Suman] Hi Simon, > This was suggested the Paolo in v3. He suggested this to simplify the merging process but to add the fix tag. Thanks Suman, Sorry for missing Paolo's advice on v3 [1]. [1] https://lore.kernel.org/netdev/dddca9a4-9ee3-4da1-b68d-26f208566d5d@redhat.com/
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c index 2b49bfec7869..161cf33ef89e 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c @@ -1047,6 +1047,7 @@ static int otx2_cq_init(struct otx2_nic *pfvf, u16 qidx) int err, pool_id, non_xdp_queues; struct nix_aq_enq_req *aq; struct otx2_cq_queue *cq; + struct otx2_pool *pool; cq = &qset->cq[qidx]; cq->cq_idx = qidx; @@ -1055,8 +1056,13 @@ static int otx2_cq_init(struct otx2_nic *pfvf, u16 qidx) cq->cq_type = CQ_RX; cq->cint_idx = qidx; cq->cqe_cnt = qset->rqe_cnt; - if (pfvf->xdp_prog) + if (pfvf->xdp_prog) { + pool = &qset->pool[qidx]; xdp_rxq_info_reg(&cq->xdp_rxq, pfvf->netdev, qidx, 0); + xdp_rxq_info_reg_mem_model(&cq->xdp_rxq, + MEM_TYPE_PAGE_POOL, + pool->page_pool); + } } else if (qidx < non_xdp_queues) { cq->cq_type = CQ_TX; cq->cint_idx = qidx - pfvf->hw.rx_queues;
Set xdp rx ring memory type as MEM_TYPE_PAGE_POOL for af-xdp to work. This is needed since xdp_return_frame internally will use page pools. Fixes: 06059a1a9a4a ("octeontx2-pf: Add XDP support to netdev PF") Signed-off-by: Suman Ghosh <sumang@marvell.com> --- drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)