| Message ID | 20250214-spi-s3c64xx-fifo-depth-v1-1-e1b1915e3ee7@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | spi: s3c64xx: extend description of compatible's fifo_depth | expand |
On 14/02/2025 08:32, Tudor Ambarus wrote: > The FIFO depth specified with the compatibles's data is used where all > the instances of the IP define the same FIFO depth. It naturally has > higher precedence than the FIFO depth specified via DT. Specifying FIFO > depth in DT becomes superfluous in this case. Extend comment about > compatible's FIFO depth. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Feb 14, 2025 at 1:32 AM Tudor Ambarus <tudor.ambarus@linaro.org> wrote: > > The FIFO depth specified with the compatibles's data is used where all > the instances of the IP define the same FIFO depth. It naturally has > higher precedence than the FIFO depth specified via DT. Specifying FIFO > depth in DT becomes superfluous in this case. Extend comment about > compatible's FIFO depth. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > drivers/spi/spi-s3c64xx.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 389275dbc003..9c47f5741c5f 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -139,7 +139,9 @@ struct s3c64xx_spi_dma_data { > * struct s3c64xx_spi_port_config - SPI Controller hardware info > * @fifo_lvl_mask: [DEPRECATED] use @{rx, tx}_fifomask instead. > * @rx_lvl_offset: [DEPRECATED] use @{rx,tx}_fifomask instead. > - * @fifo_depth: depth of the FIFO. > + * @fifo_depth: depth of the FIFOs. Used by compatibles where all the instances > + * of the IP define the same FIFO depth. It has higher precedence > + * than the FIFO depth specified via DT. > * @rx_fifomask: SPI_STATUS.RX_FIFO_LVL mask. Shifted mask defining the field's > * length and position. > * @tx_fifomask: SPI_STATUS.TX_FIFO_LVL mask. Shifted mask defining the field's > > --- > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > change-id: 20250214-spi-s3c64xx-fifo-depth-6787f108be83 > > Best regards, > -- > Tudor Ambarus <tudor.ambarus@linaro.org> >
On Fri, 14 Feb 2025 07:32:51 +0000, Tudor Ambarus wrote: > The FIFO depth specified with the compatibles's data is used where all > the instances of the IP define the same FIFO depth. It naturally has > higher precedence than the FIFO depth specified via DT. Specifying FIFO > depth in DT becomes superfluous in this case. Extend comment about > compatible's FIFO depth. > > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: s3c64xx: extend description of compatible's fifo_depth commit: cb15abd47806b449e853caf43f41573c4c82fed3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 389275dbc003..9c47f5741c5f 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -139,7 +139,9 @@ struct s3c64xx_spi_dma_data { * struct s3c64xx_spi_port_config - SPI Controller hardware info * @fifo_lvl_mask: [DEPRECATED] use @{rx, tx}_fifomask instead. * @rx_lvl_offset: [DEPRECATED] use @{rx,tx}_fifomask instead. - * @fifo_depth: depth of the FIFO. + * @fifo_depth: depth of the FIFOs. Used by compatibles where all the instances + * of the IP define the same FIFO depth. It has higher precedence + * than the FIFO depth specified via DT. * @rx_fifomask: SPI_STATUS.RX_FIFO_LVL mask. Shifted mask defining the field's * length and position. * @tx_fifomask: SPI_STATUS.TX_FIFO_LVL mask. Shifted mask defining the field's
The FIFO depth specified with the compatibles's data is used where all the instances of the IP define the same FIFO depth. It naturally has higher precedence than the FIFO depth specified via DT. Specifying FIFO depth in DT becomes superfluous in this case. Extend comment about compatible's FIFO depth. Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org> --- drivers/spi/spi-s3c64xx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b change-id: 20250214-spi-s3c64xx-fifo-depth-6787f108be83 Best regards,