diff mbox series

[1/4] platform/x86: dell: dell-wmi-sysman: Use *-y instead of *-objs in Makefile

Message ID 20250218194113.26589-2-kuurtb@gmail.com (mailing list archive)
State New
Headers show
Series platform-x86: Use *-y instead of *-objs in Makefiles | expand

Commit Message

Kurt Borja Feb. 18, 2025, 7:41 p.m. UTC
The `objs` suffix is reserved for user-space tools. Use the `y` suffix
instead, which is usually used for kernel drivers.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
 drivers/platform/x86/dell/dell-wmi-sysman/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

andriy.shevchenko@linux.intel.com Feb. 19, 2025, 2:35 p.m. UTC | #1
On Tue, Feb 18, 2025 at 02:41:08PM -0500, Kurt Borja wrote:
> The `objs` suffix is reserved for user-space tools. Use the `y` suffix
> instead, which is usually used for kernel drivers.

I haven't received a cover letter. Please, make sure when you send a version of
the few patches under the same thread you add a cover letter. You may consider
using my "smart" (not really) script [1] to send patch series to LKML.

[1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh
Kurt Borja Feb. 20, 2025, 4:13 p.m. UTC | #2
On Wed Feb 19, 2025 at 9:35 AM -05, Andy Shevchenko wrote:
> On Tue, Feb 18, 2025 at 02:41:08PM -0500, Kurt Borja wrote:
>> The `objs` suffix is reserved for user-space tools. Use the `y` suffix
>> instead, which is usually used for kernel drivers.
>
> I haven't received a cover letter. Please, make sure when you send a version of
> the few patches under the same thread you add a cover letter. You may consider
> using my "smart" (not really) script [1] to send patch series to LKML.

Hi Andy,

Yes, I messed up the Cc list.

>
> [1]: https://github.com/andy-shev/home-bin-tools/blob/master/ge2maintainer.sh

Thank you very much!! I'm using that from now on :)
diff mbox series

Patch

diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/Makefile b/drivers/platform/x86/dell/dell-wmi-sysman/Makefile
index 825fb2fbeea8..0a6df449e222 100644
--- a/drivers/platform/x86/dell/dell-wmi-sysman/Makefile
+++ b/drivers/platform/x86/dell/dell-wmi-sysman/Makefile
@@ -1,5 +1,5 @@ 
 obj-$(CONFIG_DELL_WMI_SYSMAN)  += dell-wmi-sysman.o
-dell-wmi-sysman-objs := 	sysman.o		\
+dell-wmi-sysman-y :=		sysman.o		\
 				enum-attributes.o	\
 				int-attributes.o	\
 				string-attributes.o	\