| Message ID | 20250219062701.995955-1-m-malladi@ti.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fixes for perout configuration in IEP driver | expand |
On 2/18/2025 10:26 PM, Meghana Malladi wrote: > IEP driver supports both pps and perout signal generation using testptp > application. Currently the driver is missing to incorporate the perout > signal configuration. This series introduces fixes in the driver to > configure perout signal based on the arguments passed by the perout > request. > This could be interpreted as a feature implementation rather than a fix. Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > v1: https://lore.kernel.org/all/20250211103527.923849-1-m-malladi@ti.com/ > > Meghana Malladi (2): > net: ti: icss-iep: Fix pwidth configuration for perout signal > net: ti: icss-iep: Fix phase offset configuration for perout signal > > drivers/net/ethernet/ti/icssg/icss_iep.c | 44 ++++++++++++++++++++++-- > 1 file changed, 41 insertions(+), 3 deletions(-) > > > base-commit: 071ed42cff4fcdd89025d966d48eabef59913bf2
On Wed, 19 Feb 2025 15:37:16 -0800 Jacob Keller wrote: > On 2/18/2025 10:26 PM, Meghana Malladi wrote: > > IEP driver supports both pps and perout signal generation using testptp > > application. Currently the driver is missing to incorporate the perout > > signal configuration. This series introduces fixes in the driver to > > configure perout signal based on the arguments passed by the perout > > request. > > > > This could be interpreted as a feature implementation rather than a fix. > > Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> Agreed, ideally we should get a patch for net which rejects all currently (as in - in Linus's tree) unsupported settings. That would be a fix. Then once that's merged add support for the new settings in net-next. Hope that makes sense?
On 2/20/2025 5:24 PM, Jakub Kicinski wrote: > On Wed, 19 Feb 2025 15:37:16 -0800 Jacob Keller wrote: >> On 2/18/2025 10:26 PM, Meghana Malladi wrote: >>> IEP driver supports both pps and perout signal generation using testptp >>> application. Currently the driver is missing to incorporate the perout >>> signal configuration. This series introduces fixes in the driver to >>> configure perout signal based on the arguments passed by the perout >>> request. >>> >> >> This could be interpreted as a feature implementation rather than a fix. >> >> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > > Agreed, ideally we should get a patch for net which rejects > all currently (as in - in Linus's tree) unsupported settings. > That would be a fix. > > Then once that's merged add support for the new settings in net-next. > > Hope that makes sense? +1 on this direction, its important that the driver does not accept configuration which is incorrect. Reminds me of my backlog to refactor this whole mess into a supported_flags field in the PTP ops structure. Maybe it is again time to revive that. Thanks, Jake