| Message ID | 20250221054137.1631765-2-superm1@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | ucsi_ccg: Compat with non-NVIDIA | expand |
On Thu, Feb 20, 2025 at 11:40:03PM -0600, Mario Limonciello wrote: > From: Mario Limonciello <mario.limonciello@amd.com> > > The error `failed to get FW build information` is added for what looks > to be for misdetection of the device property firmware-name. > > If the property is missing (such as on non-nvidia HW) this error shows up. > Move the error into the scope of the property parser for "firmware-name" > to avoid showing errors on systems without the firmware-name property. > > Fixes: 5c9ae5a87573d ("usb: typec: ucsi: ccg: add firmware flashing support") > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/usb/typec/ucsi/ucsi_ccg.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c > index 740171f24ef9f..663aca9421410 100644 > --- a/drivers/usb/typec/ucsi/ucsi_ccg.c > +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c > @@ -1432,11 +1432,10 @@ static int ucsi_ccg_probe(struct i2c_client *client) > uc->fw_build = CCG_FW_BUILD_NVIDIA_TEGRA; > else if (!strcmp(fw_name, "nvidia,gpu")) > uc->fw_build = CCG_FW_BUILD_NVIDIA; > + if (!uc->fw_build) > + dev_err(uc->dev, "failed to get FW build information\n"); > } > > - if (!uc->fw_build) > - dev_err(uc->dev, "failed to get FW build information\n"); > - > /* reset ccg device and initialize ucsi */ > status = ucsi_ccg_init(uc); > if (status < 0) { > -- > 2.43.0 > > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - You have marked a patch with a "Fixes:" tag for a commit that is in an older released kernel, yet you do not have a cc: stable line in the signed-off-by area at all, which means that the patch will not be applied to any older kernel releases. To properly fix this, please follow the documented rules in the Documentation/process/stable-kernel-rules.rst file for how to resolve this. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot
diff --git a/drivers/usb/typec/ucsi/ucsi_ccg.c b/drivers/usb/typec/ucsi/ucsi_ccg.c index 740171f24ef9f..663aca9421410 100644 --- a/drivers/usb/typec/ucsi/ucsi_ccg.c +++ b/drivers/usb/typec/ucsi/ucsi_ccg.c @@ -1432,11 +1432,10 @@ static int ucsi_ccg_probe(struct i2c_client *client) uc->fw_build = CCG_FW_BUILD_NVIDIA_TEGRA; else if (!strcmp(fw_name, "nvidia,gpu")) uc->fw_build = CCG_FW_BUILD_NVIDIA; + if (!uc->fw_build) + dev_err(uc->dev, "failed to get FW build information\n"); } - if (!uc->fw_build) - dev_err(uc->dev, "failed to get FW build information\n"); - /* reset ccg device and initialize ucsi */ status = ucsi_ccg_init(uc); if (status < 0) {