| Message ID | 20250221090918.1487689-2-j2anfernee@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: adc: add Nuvoton NCT7201 ADC driver | expand |
On 2/21/25 3:09 AM, Eason Yang wrote: > Add a binding specification for the Nuvoton NCT7201/NCT7202 up to 12-bit > ADCs with I2C interface. > > Signed-off-by: Eason Yang <j2anfernee@gmail.com> > --- > .../bindings/iio/adc/nuvoton,nct7201.yaml | 57 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > new file mode 100644 > index 000000000000..830c37fd9f22 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nct7201.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton nct7201 and similar ADCs > + > +maintainers: > + - Eason Yang <j2anfernee@gmail.com> > + > +description: | > + The NCT7201/NCT7202 is a Nuvoton Hardware Monitor IC, contains up to 12 voltage > + monitoring channels, with SMBus interface, and up to 4 sets SMBus address > + selection by ADDR connection. It also provides ALERT# signal for event > + notification and reset input RSTIN# to recover it from a fault condition. > + > +properties: > + compatible: > + enum: > + - nuvoton,nct7201 > + - nuvoton,nct7202 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + Maybe this was brought up before, but no power supply? > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@1d { > + compatible = "nuvoton,nct7202"; > + reg = <0x1d>; > + interrupt-parent = <&gpio3>; > + interrupts = <30 IRQ_TYPE_LEVEL_LOW>; > + reset-gpios = <&gpio3 28 GPIO_ACTIVE_LOW>; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 3864d473f52f..fdc4aa5c7eff 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2831,6 +2831,7 @@ L: openbmc@lists.ozlabs.org (moderated for non-subscribers) > S: Supported > F: Documentation/devicetree/bindings/*/*/*npcm* > F: Documentation/devicetree/bindings/*/*npcm* > +F: Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml This (ARM/NUVOTON NPCM ARCHITECTURE) doesn't look like the right place for adding a stand-alone chip. You will need to start a new section like: NUVOTON NCT7201 IIO DRIVER > F: Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml > F: arch/arm/boot/dts/nuvoton/nuvoton-npcm* > F: arch/arm/mach-npcm/
On Fri, Feb 21, 2025 at 05:09:17PM +0800, Eason Yang wrote: > Add a binding specification for the Nuvoton NCT7201/NCT7202 up to 12-bit > ADCs with I2C interface. > > Signed-off-by: Eason Yang <j2anfernee@gmail.com> > --- > .../bindings/iio/adc/nuvoton,nct7201.yaml | 57 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > new file mode 100644 > index 000000000000..830c37fd9f22 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nct7201.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Nuvoton nct7201 and similar ADCs > + > +maintainers: > + - Eason Yang <j2anfernee@gmail.com> > + > +description: | > + The NCT7201/NCT7202 is a Nuvoton Hardware Monitor IC, contains up to 12 voltage > + monitoring channels, with SMBus interface, and up to 4 sets SMBus address > + selection by ADDR connection. It also provides ALERT# signal for event > + notification and reset input RSTIN# to recover it from a fault condition. > + > +properties: > + compatible: > + enum: > + - nuvoton,nct7201 > + - nuvoton,nct7202 When you respin, please add a note about what differs between these devices that requires different handling in the driver. Cheers, Conor. > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + > + #include <dt-bindings/gpio/gpio.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@1d { > + compatible = "nuvoton,nct7202"; > + reg = <0x1d>; > + interrupt-parent = <&gpio3>; > + interrupts = <30 IRQ_TYPE_LEVEL_LOW>; > + reset-gpios = <&gpio3 28 GPIO_ACTIVE_LOW>; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 3864d473f52f..fdc4aa5c7eff 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -2831,6 +2831,7 @@ L: openbmc@lists.ozlabs.org (moderated for non-subscribers) > S: Supported > F: Documentation/devicetree/bindings/*/*/*npcm* > F: Documentation/devicetree/bindings/*/*npcm* > +F: Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml > F: Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml > F: arch/arm/boot/dts/nuvoton/nuvoton-npcm* > F: arch/arm/mach-npcm/ > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml new file mode 100644 index 000000000000..830c37fd9f22 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml @@ -0,0 +1,57 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/nuvoton,nct7201.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Nuvoton nct7201 and similar ADCs + +maintainers: + - Eason Yang <j2anfernee@gmail.com> + +description: | + The NCT7201/NCT7202 is a Nuvoton Hardware Monitor IC, contains up to 12 voltage + monitoring channels, with SMBus interface, and up to 4 sets SMBus address + selection by ADDR connection. It also provides ALERT# signal for event + notification and reset input RSTIN# to recover it from a fault condition. + +properties: + compatible: + enum: + - nuvoton,nct7201 + - nuvoton,nct7202 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + reset-gpios: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + + #include <dt-bindings/gpio/gpio.h> + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + adc@1d { + compatible = "nuvoton,nct7202"; + reg = <0x1d>; + interrupt-parent = <&gpio3>; + interrupts = <30 IRQ_TYPE_LEVEL_LOW>; + reset-gpios = <&gpio3 28 GPIO_ACTIVE_LOW>; + }; + }; +... diff --git a/MAINTAINERS b/MAINTAINERS index 3864d473f52f..fdc4aa5c7eff 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2831,6 +2831,7 @@ L: openbmc@lists.ozlabs.org (moderated for non-subscribers) S: Supported F: Documentation/devicetree/bindings/*/*/*npcm* F: Documentation/devicetree/bindings/*/*npcm* +F: Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml F: Documentation/devicetree/bindings/rtc/nuvoton,nct3018y.yaml F: arch/arm/boot/dts/nuvoton/nuvoton-npcm* F: arch/arm/mach-npcm/
Add a binding specification for the Nuvoton NCT7201/NCT7202 up to 12-bit ADCs with I2C interface. Signed-off-by: Eason Yang <j2anfernee@gmail.com> --- .../bindings/iio/adc/nuvoton,nct7201.yaml | 57 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/nuvoton,nct7201.yaml