diff mbox series

[1/1] dt-bindings: mmc: Change to additionalProperties to fix fail detect Unevaluated property

Message ID 20250220164655.2081224-1-Frank.Li@nxp.com (mailing list archive)
State New
Headers show
Series [1/1] dt-bindings: mmc: Change to additionalProperties to fix fail detect Unevaluated property | expand

Commit Message

Frank Li Feb. 20, 2025, 4:46 p.m. UTC
mmc-controller.yaml is common schema file. According to writing-schema.rst,

* additionalProperties: true
   Rare case, used for schemas implementing common set of properties. Such
   schemas are supposed to be referenced by other schemas, which then use
   'unevaluatedProperties: false'.  Typically bus or common-part schemas.

Reproduce steps:
1. Add unevaluated property 'abc' at example of fsl-imx-esdhc.yaml
2. Run make dt_binding_check DT_SCHEMA_FILES=fsl-imx-esdhc.yaml

No any warning report. But suppose report below warning:
mmc@70004000: Unevaluated properties are not allowed ('abc' was unexpected)

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Rob Herring (Arm) Feb. 21, 2025, 11:22 p.m. UTC | #1
On Thu, 20 Feb 2025 11:46:54 -0500, Frank Li wrote:
> mmc-controller.yaml is common schema file. According to writing-schema.rst,
> 
> * additionalProperties: true
>    Rare case, used for schemas implementing common set of properties. Such
>    schemas are supposed to be referenced by other schemas, which then use
>    'unevaluatedProperties: false'.  Typically bus or common-part schemas.
> 
> Reproduce steps:
> 1. Add unevaluated property 'abc' at example of fsl-imx-esdhc.yaml
> 2. Run make dt_binding_check DT_SCHEMA_FILES=fsl-imx-esdhc.yaml
> 
> No any warning report. But suppose report below warning:
> mmc@70004000: Unevaluated properties are not allowed ('abc' was unexpected)
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index 9d7a1298c4554..26e4f0f8dc1ce 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -24,7 +24,7 @@  properties:
   $nodename:
     pattern: "^mmc(@.*)?$"
 
-unevaluatedProperties: true
+additionalProperties: true
 
 examples:
   - |