| Message ID | 20250219-netdev-secs-to-jiffies-part-2-v1-0-c484cc63611b@linux.microsoft.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Converge on using secs_to_jiffies() part two | expand |
On Wed, 19 Feb 2025 20:30:35 +0000 Easwar Hariharan wrote: > The conversion is made with Coccinelle with the secs_to_jiffies() script > in scripts/coccinelle/misc. Attention is paid to what the best change > can be rather than restricting to what the tool provides. > > The non-netdev patches that include the update to secs_to_jiffies.cocci to address > expressions are here: https://lore.kernel.org/all/20250203-converge-secs-to-jiffies-part-two-v2-0-d7058a01fd0e@linux.microsoft.com Can the secs_to_jiffies cocci check script finally run in report mode? I think that needs to be fixed first, before we start "cleaning up" existing code under net.
This is the second series (part 1*) that converts users of msecs_to_jiffies() that either use the multiply pattern of either of: - msecs_to_jiffies(N*1000) or - msecs_to_jiffies(N*MSEC_PER_SEC) where N is a constant or an expression, to avoid the multiplication. The conversion is made with Coccinelle with the secs_to_jiffies() script in scripts/coccinelle/misc. Attention is paid to what the best change can be rather than restricting to what the tool provides. The non-netdev patches that include the update to secs_to_jiffies.cocci to address expressions are here: https://lore.kernel.org/all/20250203-converge-secs-to-jiffies-part-two-v2-0-d7058a01fd0e@linux.microsoft.com This series is based on net-next. Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> * https://lore.kernel.org/all/20241212-netdev-converge-secs-to-jiffies-v4-0-6dac97a6d6ab@linux.microsoft.com/ --- Easwar Hariharan (3): net/smc: convert timeouts to secs_to_jiffies() netfilter: xt_IDLETIMER: convert timeouts to secs_to_jiffies() net: ipconfig: convert timeouts to secs_to_jiffies() net/ipv4/ipconfig.c | 6 +++--- net/netfilter/xt_IDLETIMER.c | 12 ++++++------ net/smc/af_smc.c | 3 +-- 3 files changed, 10 insertions(+), 11 deletions(-) --- base-commit: de7a88b639d488607352a270ef2e052c4442b1b3 change-id: 20250128-netdev-secs-to-jiffies-part-2-8f0d2535096a Best regards,