diff mbox series

[1/2] ARM: dts: bcm2711: PL011 UARTs are actually r1p5

Message ID 20250223125614.3592-2-wahrenst@gmx.net (mailing list archive)
State New
Headers show
Series ARM: dts: bcm271x: Adjust PL011 primecell-periphid | expand

Commit Message

Stefan Wahren Feb. 23, 2025, 12:56 p.m. UTC 
From: Phil Elwell <phil@raspberrypi.com>

The ARM PL011 UART instances in BCM2711 are r1p5 spec, which means they
have 32-entry FIFOs. The correct periphid value for this is 0x00341011.
Thanks to N Buchwitz for pointing this out.

Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
---
 arch/arm/boot/dts/broadcom/bcm2711.dtsi | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

--
2.34.1

Comments

Florian Fainelli Feb. 23, 2025, 4:58 p.m. UTC | #1 
On 23/02/2025 04:56, Stefan Wahren wrote:
> From: Phil Elwell <phil@raspberrypi.com>
> 
> The ARM PL011 UART instances in BCM2711 are r1p5 spec, which means they
> have 32-entry FIFOs. The correct periphid value for this is 0x00341011.
> Thanks to N Buchwitz for pointing this out.

Should not that require warrant a Reported-by here?

> 
> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>

Some people might consider this to be a bug fix, mind adding a Fixes tag?

Thanks!
Stefan Wahren Feb. 23, 2025, 9:17 p.m. UTC | #2 
Am 23.02.25 um 17:58 schrieb Florian Fainelli:
>
>
> On 23/02/2025 04:56, Stefan Wahren wrote:
>> From: Phil Elwell <phil@raspberrypi.com>
>>
>> The ARM PL011 UART instances in BCM2711 are r1p5 spec, which means they
>> have 32-entry FIFOs. The correct periphid value for this is 0x00341011.
>> Thanks to N Buchwitz for pointing this out.
>
> Should not that require warrant a Reported-by here?
I tried to find the original discussion, but i couldn't find it. Also I
don't know if this person wants their mail address published.
>
>>
>> Signed-off-by: Phil Elwell <phil@raspberrypi.com>
>> Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
>
> Some people might consider this to be a bug fix, mind adding a Fixes tag?
tbh, i'm not aware of any (real) negative impact, but yes i'm fine to
add it.
>
> Thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/broadcom/bcm2711.dtsi b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
index 7cf93fdc676c..cdccdef267f7 100644
--- a/arch/arm/boot/dts/broadcom/bcm2711.dtsi
+++ b/arch/arm/boot/dts/broadcom/bcm2711.dtsi
@@ -134,7 +134,7 @@  uart2: serial@7e201400 {
 			clocks = <&clocks BCM2835_CLOCK_UART>,
 				 <&clocks BCM2835_CLOCK_VPU>;
 			clock-names = "uartclk", "apb_pclk";
-			arm,primecell-periphid = <0x00241011>;
+			arm,primecell-periphid = <0x00341011>;
 			status = "disabled";
 		};

@@ -145,7 +145,7 @@  uart3: serial@7e201600 {
 			clocks = <&clocks BCM2835_CLOCK_UART>,
 				 <&clocks BCM2835_CLOCK_VPU>;
 			clock-names = "uartclk", "apb_pclk";
-			arm,primecell-periphid = <0x00241011>;
+			arm,primecell-periphid = <0x00341011>;
 			status = "disabled";
 		};

@@ -156,7 +156,7 @@  uart4: serial@7e201800 {
 			clocks = <&clocks BCM2835_CLOCK_UART>,
 				 <&clocks BCM2835_CLOCK_VPU>;
 			clock-names = "uartclk", "apb_pclk";
-			arm,primecell-periphid = <0x00241011>;
+			arm,primecell-periphid = <0x00341011>;
 			status = "disabled";
 		};

@@ -167,7 +167,7 @@  uart5: serial@7e201a00 {
 			clocks = <&clocks BCM2835_CLOCK_UART>,
 				 <&clocks BCM2835_CLOCK_VPU>;
 			clock-names = "uartclk", "apb_pclk";
-			arm,primecell-periphid = <0x00241011>;
+			arm,primecell-periphid = <0x00341011>;
 			status = "disabled";
 		};

@@ -1175,6 +1175,7 @@  &txp {
 };

 &uart0 {
+	arm,primecell-periphid = <0x00341011>;
 	interrupts = <GIC_SPI 121 IRQ_TYPE_LEVEL_HIGH>;
 };