| Message ID | 20250223122227.725233-7-ivo.ivanov.ivanov1@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | phy: samsung: add Exynos2200 SNPS eUSB2 driver | expand |
On Sun, Feb 23, 2025 at 02:22:25PM +0200, Ivaylo Ivanov wrote: > Some SoCs don't provide explicit reset lines, so make them optional. Is there an external reset or some other signal? > > Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> > --- > drivers/phy/phy-snps-eusb2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
On 2/24/25 01:48, Dmitry Baryshkov wrote: > On Sun, Feb 23, 2025 at 02:22:25PM +0200, Ivaylo Ivanov wrote: >> Some SoCs don't provide explicit reset lines, so make them optional. > Is there an external reset or some other signal? Well.. There probably are on a hardware level, but there's no interface that exposes them to the kernel.. as far as I've seen. Resets are usually managed via the blocks' registers. I can't say with certainty because I don't have access to TRMs. I can reword this commit message to make that clear. Best regards, Ivaylo > >> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> >> --- >> drivers/phy/phy-snps-eusb2.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >
diff --git a/drivers/phy/phy-snps-eusb2.c b/drivers/phy/phy-snps-eusb2.c index dcc69c00a..7a242fe32 100644 --- a/drivers/phy/phy-snps-eusb2.c +++ b/drivers/phy/phy-snps-eusb2.c @@ -420,7 +420,7 @@ static int snps_eusb2_hsphy_probe(struct platform_device *pdev) if (IS_ERR(phy->base)) return PTR_ERR(phy->base); - phy->phy_reset = devm_reset_control_get_exclusive(dev, NULL); + phy->phy_reset = devm_reset_control_get_optional_exclusive(dev, NULL); if (IS_ERR(phy->phy_reset)) return PTR_ERR(phy->phy_reset);
Some SoCs don't provide explicit reset lines, so make them optional. Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> --- drivers/phy/phy-snps-eusb2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)