| Message ID | 20250224141242.1370280-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] kbuild: hdrcheck: fix cross build with clang | expand |
On Mon, Feb 24, 2025 at 03:12:36PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The headercheck tries to call clang with a mix of compiler arguments > that don't include the target architecture. When building e.g. x86 > headers on arm64, this produces a warning like > > clang: warning: unknown platform, assuming -mfloat-abi=soft > > Add in the CLANG_FLAGS, which contain the target, in order to make it Small nit, this should probably be KBUILD_CPPFLAGS now. > build properly. > > See also 1b71c2fb04e7 ("kbuild: userprogs: fix bitsize and target > > detection on clang"). Extra '>' I think? > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Nathan Chancellor <nathan@kernel.org> Perhaps this wants the same Fixes tag as the above referenced patch since I think that is the one that broke this? Fixes: feb843a469fb ("kbuild: add $(CLANG_FLAGS) to KBUILD_CPPFLAGS") > --- > v2: use same approach as the other patch. > --- > usr/include/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/usr/include/Makefile b/usr/include/Makefile > index 58a9cbe4eba4..b9a2640b4bb7 100644 > --- a/usr/include/Makefile > +++ b/usr/include/Makefile > @@ -10,7 +10,7 @@ UAPI_CFLAGS := -std=c90 -Wall -Werror=implicit-function-declaration > > # In theory, we do not care -m32 or -m64 for header compile tests. > # It is here just because CONFIG_CC_CAN_LINK is tested with -m32 or -m64. > -UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CFLAGS)) > +UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS)) > > # USERCFLAGS might contain sysroot location for CC. > UAPI_CFLAGS += $(USERCFLAGS) > -- > 2.39.5 >
diff --git a/usr/include/Makefile b/usr/include/Makefile index 58a9cbe4eba4..b9a2640b4bb7 100644 --- a/usr/include/Makefile +++ b/usr/include/Makefile @@ -10,7 +10,7 @@ UAPI_CFLAGS := -std=c90 -Wall -Werror=implicit-function-declaration # In theory, we do not care -m32 or -m64 for header compile tests. # It is here just because CONFIG_CC_CAN_LINK is tested with -m32 or -m64. -UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CFLAGS)) +UAPI_CFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS)) # USERCFLAGS might contain sysroot location for CC. UAPI_CFLAGS += $(USERCFLAGS)