| Message ID | 20250223233613.100518-2-thorsten.blum@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | [net-next] net: ethernet: renesas: rcar_gen4_ptp: Remove bool conversion | expand |
On Mon, 24 Feb 2025 at 00:37, Thorsten Blum <thorsten.blum@linux.dev> wrote: > Remove the unnecessary bool conversion and simplify the code. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert
Hi Thorsten, Thanks for your work. On 2025-02-24 00:36:11 +0100, Thorsten Blum wrote: > Remove the unnecessary bool conversion and simplify the code. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c > index 72e7fcc56693..4c3e8cc5046f 100644 > --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c > +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c > @@ -29,8 +29,8 @@ static const struct rcar_gen4_ptp_reg_offset gen4_offs = { > static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) > { > struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp); > - bool neg_adj = scaled_ppm < 0 ? true : false; > s64 addend = ptp_priv->default_addend; > + bool neg_adj = scaled_ppm < 0; > s64 diff; > > if (neg_adj) > -- > 2.48.1 > >
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 24 Feb 2025 00:36:11 +0100 you wrote: > Remove the unnecessary bool conversion and simplify the code. > > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> > --- > drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net-next] net: ethernet: renesas: rcar_gen4_ptp: Remove bool conversion https://git.kernel.org/netdev/net-next/c/6538c8ca8ee1 You are awesome, thank you!
diff --git a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c index 72e7fcc56693..4c3e8cc5046f 100644 --- a/drivers/net/ethernet/renesas/rcar_gen4_ptp.c +++ b/drivers/net/ethernet/renesas/rcar_gen4_ptp.c @@ -29,8 +29,8 @@ static const struct rcar_gen4_ptp_reg_offset gen4_offs = { static int rcar_gen4_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) { struct rcar_gen4_ptp_private *ptp_priv = ptp_to_priv(ptp); - bool neg_adj = scaled_ppm < 0 ? true : false; s64 addend = ptp_priv->default_addend; + bool neg_adj = scaled_ppm < 0; s64 diff; if (neg_adj)
Remove the unnecessary bool conversion and simplify the code. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- drivers/net/ethernet/renesas/rcar_gen4_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)